Received-SPF: pass (google.com: domain of linux-kernel+bounces-215006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 14 Jun 2024 16:17:30 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>, netdev@vger.kernel.org,
	davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
	bryan.whitehead@microchip.com, sbauer@blackbox.su,
	hmehrtens@maxlinear.com, lxu@maxlinear.com, hkallweit1@gmail.com,
	edumazet@google.com, pabeni@redhat.com, wojciech.drewek@intel.com,
	UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net V4 1/3] net: lan743x: disable WOL upon resume to
 restore full data path operation
Message-ID: <052f32e1-0a6b-4eae-a4d8-727a0d933d7e@lunn.ch>
References: <20240612172539.28565-1-Raju.Lakkaraju@microchip.com>
 <20240612172539.28565-2-Raju.Lakkaraju@microchip.com>
 <ZmqjYEs0G9pGQTog@shell.armlinux.org.uk>
 <ZmvHgg5SDYlrO9yB@HYD-DK-UNGSW21.microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmvHgg5SDYlrO9yB@HYD-DK-UNGSW21.microchip.com>

On Fri, Jun 14, 2024 at 10:00:58AM +0530, Raju Lakkaraju wrote:
> Hi Russell King,
> 
> The 06/13/2024 08:44, Russell King (Oracle) wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Wed, Jun 12, 2024 at 10:55:37PM +0530, Raju Lakkaraju wrote:
> > > @@ -3728,6 +3729,30 @@ static int lan743x_pm_resume(struct device *dev)
> > >               return ret;
> > >       }
> > >
> > > +     ret = lan743x_csr_read(adapter, MAC_WK_SRC);
> > > +     netif_info(adapter, drv, adapter->netdev,
> > > +                "Wakeup source : 0x%08X\n", ret);
> > 
> > Does this need to be printed at info level, or is it a debug message?
> 
> Print at info level helps the tester/sqa team to identify the root cause of
> the wake and confirm the test cases.
> In general, tester does not enable debug level messages for testing.
> 
> Still, if we need to change from info to debug, i can change.
> Please let me know.

We are not really writing a kernel for the tester/SQA team, but the
end users. Do the end users find this log message useful? Can they
decode some hex value into something meaningful?

I'm surprised the test case cares what caused the wakeup. So long as
it does wake up, does it really matter what the source was?

	Andrew