Received-SPF: pass (google.com: domain of linux-kernel+bounces-215036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240614141640.59324-1-andrey.konovalov@linux.dev> <CANpmjNO0T-sooJYs2ZCAzFUs6NVkV7iacY=hzB0JtGAyKhEmzw@mail.gmail.com>
In-Reply-To: <CANpmjNO0T-sooJYs2ZCAzFUs6NVkV7iacY=hzB0JtGAyKhEmzw@mail.gmail.com>
From: Andrey Konovalov <andreyknvl@gmail.com>
Date: Fri, 14 Jun 2024 16:33:25 +0200
Message-ID: <CA+fCnZfRtGNYw953NMm9s3JTsv6gNQJSbREcnbcUe6Zsgeh_6Q@mail.gmail.com>
Subject: Re: [PATCH] kasan: fix bad call to unpoison_slab_object
To: Marco Elver <elver@google.com>
Cc: andrey.konovalov@linux.dev, Andrew Morton <akpm@linux-foundation.org>, 
	Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, 
	Andrey Ryabinin <ryabinin.a.a@gmail.com>, kasan-dev@googlegroups.com, linux-mm@kvack.org, 
	Brad Spengler <spender@grsecurity.net>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 14, 2024 at 4:29=E2=80=AFPM Marco Elver <elver@google.com> wrot=
e:
>
> On Fri, 14 Jun 2024 at 16:16, <andrey.konovalov@linux.dev> wrote:
> >
> > From: Andrey Konovalov <andreyknvl@gmail.com>
> >
> > Commit 29d7355a9d05 ("kasan: save alloc stack traces for mempool") mess=
ed
> > up one of the calls to unpoison_slab_object: the last two arguments are
> > supposed to be GFP flags and whether to init the object memory.
> >
> > Fix the call.
> >
> > Without this fix, unpoison_slab_object provides the object's size as
> > GFP flags to unpoison_slab_object, which can cause LOCKDEP reports
> > (and probably other issues).
> >
> > Fixes: 29d7355a9d05 ("kasan: save alloc stack traces for mempool")
> > Reported-by: Brad Spengler <spender@grsecurity.net>
> > Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
>
> Oof.
>
> Acked-by: Marco Elver <elver@google.com>
>
> mm needs explicit Cc: stable, right? If so, we better add Cc: stable as w=
ell.

Makes sense, sent v2 with CC stable and a commit message fix.

Thanks!