Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp865582lqs; Fri, 14 Jun 2024 07:54:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUq9dfBhOSPOnIRi9wt4cIoSp9AZx/8PCtIamcUvj3+g1rVtx0olz/WColtuwT2EzVI3eryxpARVPrJjhU5ShRCAePZXo1fl+Sry1J2/g== X-Google-Smtp-Source: AGHT+IE3M0VcIus4q+pxa0bRFq/5wTOAv1aUARGBcBh1o6hJ6bnwj1mtgIHltbki6s75HnV7I938 X-Received: by 2002:a05:6a21:2790:b0:1b4:b4af:6052 with SMTP id adf61e73a8af0-1bae7f93cd1mr3767139637.23.1718376887865; Fri, 14 Jun 2024 07:54:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718376887; cv=pass; d=google.com; s=arc-20160816; b=Lc2UYlw3uDHxZgEDxXidaLRn06AEAj5C+o7WMQV2TncTDObSeP/1jch0lVDyHgJI6y Ln/ADo8VntneXkXS3mDWOvrAH7ucckyibyGByz0G73F0CpTkx6JkysOiEdhlVdUiJSgY EvWiwb66HHL33has7F8o5Gslgg243wTW5HiHzM4O5ea7X8pMWtWpS5F92GTzCHgagTEk 113zETqKPuC7BkU0YGq4sjThxGRkm3MAfOGJuCakdRCCFw2elFFDmz14YaNHbxZu0Wiu TQ0tPzycrv5Fv6xI2uSKoycb5wABPURmlx9nAvGrKvl5U6JAxFqa77zZHVx23VPej18f priA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:date:from :dkim-signature; bh=toQ+ualqefklSSAYbJZD4lZ0SocHnFoNzAn0Uopd3HA=; fh=IwOmwJLXS3khFysc5IG5d+LjktMODNZQTWeXb9ecmGc=; b=BSmUYG48FYGzzKagB4sLTFB+Ez7GXjdBsBJX+reURAiYT0x4/3WsT3NJzHbC6EMBb3 hrFwxWv7zG+PF9TIfjEYOuV3qI/w+UnTeRjrOdGoIQG+F1/xs0OTrflJNsZluQhuXVCc pD7nWrd6NGAAXw8C792+1Voxp0VOLpvG9vP56Kz3+lI17em5E8mXV7hvELipB8qJWmp2 IRdhZbQ03Ou16Id705rYylisuRMlTiHTh3SuL+6XU0JepDPCELhiY8xYTDp+A2WO3JgN QYDJtbmdyEihCAHM3+8dph1MI5mb6tPuizofYuQhTlrWrc54r5AY2tw+PotJJq8mFuQk TzRA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eDU4D1ca; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-215053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215053-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6fee5775d24si3574820a12.742.2024.06.14.07.54.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 07:54:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eDU4D1ca; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-215053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215053-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 789162815D3 for ; Fri, 14 Jun 2024 14:54:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DAF9917555; Fri, 14 Jun 2024 14:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eDU4D1ca" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F9D64C96; Fri, 14 Jun 2024 14:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718376880; cv=none; b=ovj+TT/xbKt9EJFdmgAmXQK4EbSlf1XzK+eMsEmLYo663sNbNaiCsgjAriUzxgG7m/RWIHP7vQ3whZS6hiPORqpF6/Z9cMr5slqrtTE850tSelR6+DxrBPC2ggZsgWVAP4SrVIodv7F5Wprju+kiGAp0AjRL1Hmsq8TVsixGvyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718376880; c=relaxed/simple; bh=OzFYerauOBqolouxgkZVxe0lW7TOcqR6/DYM51DUUMo=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=AzQfkfWaX2ahNHp6im6qnGuFe+Av1KzQY5eM0CDe1/akiK68RUUXPyefivBP2Q/RdSYaXoJcNe97UceDkFe/1CP81Q8mViUJ3zzdyCagCxeGevbfC5/anrIjlsBF8mxGbnGgRQcG2oeDD05lzMPnsFfAqiCzK+WQPlMd2PMq1UM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eDU4D1ca; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718376879; x=1749912879; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=OzFYerauOBqolouxgkZVxe0lW7TOcqR6/DYM51DUUMo=; b=eDU4D1caGHUBMAtXm+zvBgM1Vq7PPFTR3SFgHDDrBnVjpcRBQoKIGrEJ EeN6QzwLWc/nFf+0I6G8CyTu2HdAVBYe/nQDJdNfPEadVWy+ttXH31wuJ sDGT7rB5HXqcz97RtfOwCK8z5yZ0D2A0iPVc0MRKQzwS6HUHlRHfdQUxS PXi+c2ASyNzSpAAHEu4oOk7MCCEkF7asJUmDw4uwNaJDn5xEwphDdWsay IH+AsakVfo0zMW4Mz/fpK4xpgqy1pKj4goKXshBHMYH7QArGuEoBby/sb QJf3OjmY1fZpD1CKvEaG+5+91jrjd34PIEhq4sd7nVidpBVxL+hkb78Qi g==; X-CSE-ConnectionGUID: VIBWGouGRuKMyKNfwSIgtg== X-CSE-MsgGUID: xS3bVmX9TWWH4m8FuMSe2w== X-IronPort-AV: E=McAfee;i="6700,10204,11103"; a="14997210" X-IronPort-AV: E=Sophos;i="6.08,238,1712646000"; d="scan'208";a="14997210" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2024 07:54:38 -0700 X-CSE-ConnectionGUID: +PcahY8mTLKwdfa1YAsVXw== X-CSE-MsgGUID: Wz+fHa1oRq2VAKHfFneYkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,238,1712646000"; d="scan'208";a="78002414" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.245.247.222]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2024 07:54:34 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Fri, 14 Jun 2024 17:54:30 +0300 (EEST) To: Li zeming cc: jgross@suse.com, bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?ISO-8859-7?Q?Re=3A_=5BPATCH=5D_x86=3A_pci=3A_xen=3A_Remove_?= =?ISO-8859-7?Q?unnecessary_=A10=A2_values_from_ret?= In-Reply-To: <20240612092406.39007-1-zeming@nfschina.com> Message-ID: References: <20240612092406.39007-1-zeming@nfschina.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 12 Jun 2024, Li zeming wrote: > ret is assigned first, so it does not need to initialize the assignment. While the patch seems fine, this description and the shortlog are confusing. -- i. > Signed-off-by: Li zeming > --- > arch/x86/pci/xen.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c > index 652cd53e77f6..67cb9dc9b2e7 100644 > --- a/arch/x86/pci/xen.c > +++ b/arch/x86/pci/xen.c > @@ -267,7 +267,7 @@ static bool __read_mostly pci_seg_supported = true; > > static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > { > - int ret = 0; > + int ret; > struct msi_desc *msidesc; > > msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_NOTASSOCIATED) { > @@ -353,7 +353,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > > bool xen_initdom_restore_msi(struct pci_dev *dev) > { > - int ret = 0; > + int ret; > > if (!xen_initial_domain()) > return true; >