Received-SPF: pass (google.com: domain of linux-kernel+bounces-215064-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240614023009.221547-1-jhubbard@nvidia.com> <20240614023009.221547-3-jhubbard@nvidia.com>
 <4c6ffb1e-0381-4d5e-afa2-f8809f0b445f@redhat.com>
In-Reply-To: <4c6ffb1e-0381-4d5e-afa2-f8809f0b445f@redhat.com>
From: Jeff Xu <jeffxu@chromium.org>
Date: Fri, 14 Jun 2024 07:56:57 -0700
Message-ID: <CABi2SkXcb_GaSomWrj+n8tEg-VmR3e5bLpqw0-h9K=6gkiBxow@mail.gmail.com>
Subject: Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test
 macros and other duplicated items
To: David Hildenbrand <david@redhat.com>
Cc: John Hubbard <jhubbard@nvidia.com>, Andrew Morton <akpm@linux-foundation.org>, 
	Shuah Khan <shuah@kernel.org>, Andrei Vagin <avagin@google.com>, 
	Axel Rasmussen <axelrasmussen@google.com>, Christian Brauner <brauner@kernel.org>, 
	Kees Cook <kees@kernel.org>, Kent Overstreet <kent.overstreet@linux.dev>, 
	"Liam R . Howlett" <Liam.Howlett@oracle.com>, Muhammad Usama Anjum <usama.anjum@collabora.com>, 
	Peter Xu <peterx@redhat.com>, Rich Felker <dalias@libc.org>, linux-mm@kvack.org, 
	linux-kselftest@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 14, 2024 at 5:28=E2=80=AFAM David Hildenbrand <david@redhat.com=
> wrote:
>
> On 14.06.24 04:30, John Hubbard wrote:
> > Clean up and move some copy-pasted items into a new mseal_helpers.h.
> >
> > 1. The test macros can be made safer and simpler, by observing that the=
y
> > are invariably called when about to return. This means that the macros
> > do not need an intrusive label to goto; they can simply return.
> >
> > 2. PKEY* items. We cannot, unfortunately use pkey-helpers.h. The best w=
e
> > can do is to factor out these few items into mseal_helpers.h.
> >
> > 3. These tests still need their own definition of u64, so also move tha=
t
> > to the header file.
> >
> > Cc: Jeff Xu <jeffxu@chromium.org>
> > Cc: David Hildenbrand <david@redhat.com>
> > Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> > ---
>
> Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Jeff Xu <jeffxu@google.com>

>
> --
> Cheers,
>
> David / dhildenb
>