Received-SPF: pass (google.com: domain of linux-kernel+bounces-215143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 14 Jun 2024 16:26:22 +0100
From: Conor Dooley <conor@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: dmitry.torokhov@gmail.com, dan.carpenter@linaro.org,
	dianders@chromium.org, robh@kernel.org, krzk+dt@kernel.org,
	jikos@kernel.org, bentiss@kernel.org, hbarnor@chromium.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Message-ID: <20240614-renewably-snowless-861ca2ab9c93@spud>
References: <20240614121538.236727-1-charles.goodix@gmail.com>
 <20240614121538.236727-3-charles.goodix@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="sIpVdyPJbqU7YAg0"
Content-Disposition: inline
In-Reply-To: <20240614121538.236727-3-charles.goodix@gmail.com>


--sIpVdyPJbqU7YAg0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 14, 2024 at 08:15:38PM +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
>=20
> Signed-off-by: Charles Wang <charles.goodix@gmail.com>
> ---
>  .../bindings/input/goodix,gt7986u.yaml        | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986=
u.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml =
b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml
> new file mode 100644
> index 000000000..1c518d03b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GOODIX GT7986U SPI HID Touchscreen
> +
> +maintainers:
> +  - Charles Wang <charles.goodix@gmail.com>
> +
> +description:
> +  Supports the Goodix GT7986U touchscreen.
> +  This touch controller reports data packaged according to the HID proto=
col,
> +  but is incompatible with Microsoft's HID-over-SPI protocol.
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - goodix,gt7986u
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: reset gpio the chip is connected to.
> +
> +  goodix,hid-report-addr:
> +    description: the register address for retrieving HID report data.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +additionalProperties: false

unevaluatedProperties: false.

Please test your binding w/ dt_binding_check.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - goodix,hid-report-addr
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +    spi {
> +      #address-cells =3D <1>;
> +      #size-cells =3D <0>;
> +      num-cs =3D <1>;
> +      cs-gpios =3D <&gpio 2 GPIO_ACTIVE_HIGH>;

cs-gpios shouldn't be needed for a basic example.

Blank line here before the child node please.

Thanks,
Conor.

> +      touchscreen@0 {
> +        compatible =3D "goodix,gt7986u";
> +        reg =3D <0>;
> +        interrupt-parent =3D <&gpio>;
> +        interrupts =3D <25 IRQ_TYPE_LEVEL_LOW>;
> +        reset-gpios =3D <&gpio1 1 GPIO_ACTIVE_LOW>;
> +        spi-max-frequency =3D <10000000>;
> +        goodix,hid-report-addr =3D <0x22c8c>;
> +      };
> +    };
> --=20
> 2.43.0
>=20
>=20

--sIpVdyPJbqU7YAg0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZmxhHgAKCRB4tDGHoIJi
0jvDAQDDtZyVi/8NgabB8fDEa1enuIUIT8ggVNgMugIqpQnRNAEA+oBaBQsso5Pk
mO2mB6FIEIQiIEctAIhGz5QpwWq+aAQ=
=Ez+U
-----END PGP SIGNATURE-----

--sIpVdyPJbqU7YAg0--