Received-SPF: pass (google.com: domain of linux-kernel+bounces-215148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 14 Jun 2024 16:27:52 +0100
From: Conor Dooley <conor@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: dmitry.torokhov@gmail.com, dan.carpenter@linaro.org,
	dianders@chromium.org, robh@kernel.org, krzk+dt@kernel.org,
	jikos@kernel.org, bentiss@kernel.org, hbarnor@chromium.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Message-ID: <20240614-blah-sworn-1e13ec9c0e94@spud>
References: <20240614121538.236727-1-charles.goodix@gmail.com>
 <20240614121538.236727-3-charles.goodix@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="tW7EexHhrd4LQWuH"
Content-Disposition: inline
In-Reply-To: <20240614121538.236727-3-charles.goodix@gmail.com>


--tW7EexHhrd4LQWuH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 14, 2024 at 08:15:38PM +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.

> +properties:
> +  compatible:
> +    enum:
> +      - goodix,gt7986u

> +  goodix,hid-report-addr:
> +    description: the register address for retrieving HID report data.
> +    $ref: /schemas/types.yaml#/definitions/uint32

You're also missing an explanation anywhere in the patch for why this
address varies between gt7986u devices.

--tW7EexHhrd4LQWuH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZmxheAAKCRB4tDGHoIJi
0p0WAP0bcvR8lBU9nHpM3WHqK5MvJz4Cu+Rc33nsJemIQuIlCQEAl9PCkGiuPulC
vPaBvZRIVYfCIyBYcQiKakHRBUeAfAM=
=U5GX
-----END PGP SIGNATURE-----

--tW7EexHhrd4LQWuH--