Received-SPF: pass (google.com: domain of linux-kernel+bounces-215095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ced7a67e-8db9-4422-889e-76ee4958a622@gmail.com>
Date: Fri, 14 Jun 2024 16:02:37 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/2] mm: store zero pages to be swapped out in a bitmap
To: Andi Kleen <ak@linux.intel.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, shakeel.butt@linux.dev,
 david@redhat.com, ying.huang@intel.com, hughd@google.com,
 willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com,
 chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 kernel-team@meta.com
References: <20240614100902.3469724-1-usamaarif642@gmail.com>
 <20240614100902.3469724-2-usamaarif642@gmail.com>
 <87ed8zmvla.fsf@linux.intel.com>
Content-Language: en-US
From: Usama Arif <usamaarif642@gmail.com>
In-Reply-To: <87ed8zmvla.fsf@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 14/06/2024 15:45, Andi Kleen wrote:
> Usama Arif <usamaarif642@gmail.com> writes:
>
>> Approximately 10-20% of pages to be swapped out are zero pages [1].
>> Rather than reading/writing these pages to flash resulting
>> in increased I/O and flash wear, a bitmap can be used to mark these
>> pages as zero at write time, and the pages can be filled at
>> read time if the bit corresponding to the page is set.
>> With this patch, NVMe writes in Meta server fleet decreased
>> by almost 10% with conventional swap setup (zswap disabled).
>>
>> [1] https://lore.kernel.org/all/20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1/
> But how much did the CPU time increase? Surely the new loop is not free?
>
> -Andi

It is negligible.

For a zero filled page, without zero-fill optimization, the CPU would 
have to do page compression in zswap or dispatch write to disk, so this 
optimization is just replacing the CPU usage for these tasks with CPU 
usage for checking if page is zero-filled. This is the reason why 
same-filled optimization was there in zswap. Zswap should focus on 
actual compression and this series is just moving the optimization to swap.

For a non-zero filled page, the loop quits the first instance you see 
non zero data and checks the last word first, so its likely going to 
quite very early on in the loop.