Received-SPF: pass (google.com: domain of linux-kernel+bounces-215127-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f45d0cba3e3fc087d0a3b8c5af5401a5c38ec162.camel@gmail.com>
Subject: Re: [PATCH v2 3/5] iio: adc: ad7292: use
 devm_regulator_get_enable_read_voltage
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>, Jonathan Cameron
 <jic23@kernel.org>
Cc: Marcelo Schmitt <marcelo.schmitt1@gmail.com>, Nuno =?ISO-8859-1?Q?S=E1?=
 <nuno.sa@analog.com>, Michael Hennerich <Michael.Hennerich@analog.com>,
 Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 linux-iio@vger.kernel.org,  linux-kernel@vger.kernel.org
Date: Fri, 14 Jun 2024 17:11:39 +0200
In-Reply-To: <20240612-iio-adc-ref-supply-refactor-v2-3-fa622e7354e9@baylibre.com>
References: 
	<20240612-iio-adc-ref-supply-refactor-v2-0-fa622e7354e9@baylibre.com>
	 <20240612-iio-adc-ref-supply-refactor-v2-3-fa622e7354e9@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-12 at 16:03 -0500, David Lechner wrote:
> This makes use of the new devm_regulator_get_enable_read_voltage()
> function to reduce boilerplate code.
>=20
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> v2 changes:
> * avoid else in return value check
> * use macro instead of comment to document internal reference voltage
> ---
> =C2=A0drivers/iio/adc/ad7292.c | 36 ++++++------------------------------
> =C2=A01 file changed, 6 insertions(+), 30 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> index 6aadd14f459d..87ffe66058a1 100644
> --- a/drivers/iio/adc/ad7292.c
> +++ b/drivers/iio/adc/ad7292.c
> @@ -17,6 +17,8 @@
> =C2=A0
> =C2=A0#define ADI_VENDOR_ID 0x0018
> =C2=A0
> +#define AD7292_INTERNAL_REF_MV 1250
> +
> =C2=A0/* AD7292 registers definition */
> =C2=A0#define AD7292_REG_VENDOR_ID		0x00
> =C2=A0#define AD7292_REG_CONF_BANK		0x05
> @@ -79,7 +81,6 @@ static const struct iio_chan_spec ad7292_channels_diff[=
] =3D {
> =C2=A0
> =C2=A0struct ad7292_state {
> =C2=A0	struct spi_device *spi;
> -	struct regulator *reg;
> =C2=A0	unsigned short vref_mv;
> =C2=A0
> =C2=A0	__be16 d16 __aligned(IIO_DMA_MINALIGN);
> @@ -250,13 +251,6 @@ static const struct iio_info ad7292_info =3D {
> =C2=A0	.read_raw =3D ad7292_read_raw,
> =C2=A0};
> =C2=A0
> -static void ad7292_regulator_disable(void *data)
> -{
> -	struct ad7292_state *st =3D data;
> -
> -	regulator_disable(st->reg);
> -}
> -
> =C2=A0static int ad7292_probe(struct spi_device *spi)
> =C2=A0{
> =C2=A0	struct ad7292_state *st;
> @@ -277,29 +271,11 @@ static int ad7292_probe(struct spi_device *spi)
> =C2=A0		return -EINVAL;
> =C2=A0	}
> =C2=A0
> -	st->reg =3D devm_regulator_get_optional(&spi->dev, "vref");
> -	if (!IS_ERR(st->reg)) {
> -		ret =3D regulator_enable(st->reg);
> -		if (ret) {
> -			dev_err(&spi->dev,
> -				"Failed to enable external vref supply\n");
> -			return ret;
> -		}
> -
> -		ret =3D devm_add_action_or_reset(&spi->dev,
> -					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ad7292_regulator_disable, st);
> -		if (ret)
> -			return ret;
> -
> -		ret =3D regulator_get_voltage(st->reg);
> -		if (ret < 0)
> -			return ret;
> +	ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vref");
> +	if (ret < 0 && ret =3D=3D -ENODEV)

ret !=3D -ENODEV?

- Nuno S=C3=A1