Received-SPF: pass (google.com: domain of linux-kernel+bounces-215202-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a5326e77-bb19-a92f-6beb-7d2c64866891@amd.com>
Date: Fri, 14 Jun 2024 11:08:53 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] virt/coco/sev-guest: Don't free decrypted memory
Content-Language: en-US
To: Li RongQing <lirongqing@baidu.com>, dan.j.williams@intel.com,
 bp@alien8.de, linux-kernel@vger.kernel.org
References: <20240614051036.41983-1-lirongqing@baidu.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240614051036.41983-1-lirongqing@baidu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SHVVUGRKdnZyZ2NKMTIzclJSemRBMWxRN2ZEekxudjRHcTJWeHZGVjg5UjlL?=
 =?utf-8?B?WENycVg1ZGxnSXBMMzlUTXRMejBId2tmTTJnM2Z4dGhnSjYzWWozOFJGK3JI?=
 =?utf-8?B?YlA0N0tpdGE2NTJJRTY1aHN5blVIaGlwM0NuS3JIVmI3S1U5YmI4RzBvQU1M?=
 =?utf-8?B?WWZsY044NWFXQy9WU0JTQVJGbFlPelBzSU9QSDZLN1BFT01RSzNyUTB3NmVD?=
 =?utf-8?B?Ui9vcTlDalRHS3B2eVhrbk9oVTFCYmJBWXdudTFuZ2E5YjFRQlNLbjVyOTRq?=
 =?utf-8?B?aFQvcG9VRDR6S1VEUXgvREk1YkFjQ3NPa2JiMjZsa2hVd2xNclA4MGRxR0lx?=
 =?utf-8?B?ejFxVUZqcy9YQWUvemQ5dTJ0VEQvMStncWsrWFFYRk91Tk5MK2d0aUY4RXJ2?=
 =?utf-8?B?MzIzV1NhM3g3QStmNWlmelNxNDVld0QxbUJrVXZZek1QRENBbjVkdi9pRFJz?=
 =?utf-8?B?RG1HcXA1UW95NjRMbEZzekJYdFdEcnlocmNqdDdVZ095UVp5Wjdxa2ord21s?=
 =?utf-8?B?QUQ0WGhQS0N0Q2J0dml3SXhEa05SbHkzRXdGZldCSzNwODl0TDV1dzhIOW5N?=
 =?utf-8?B?ZitYS0FRU2Urc1BnMVVUL01HSUhzVGdOL3l1QWZjMzNvVnlsdnorOTVoc0p0?=
 =?utf-8?B?SXZXdlNWRldrUE54MHlXRlJlbTBDQ1J3QkkyUlJUT2JqT1JXN0xSS21TVDh3?=
 =?utf-8?B?MXBLdUJmNEFETG5zMXNKSXJTZnhtZW41dllqbzB4QTRnZHRIb1ZkRFNPbE5C?=
 =?utf-8?B?U3RzcHFwVHJOSlhSWUI4dDhBN21BcU5TQ2laRko4ZlhIZ0htcGN6dmFKekRT?=
 =?utf-8?B?cWxwL1B0SUI5SUJjSE5iK0xpUFpHemdhU0Mzd25ETEliTFFPcXdMKzlLUzA4?=
 =?utf-8?B?WkppcXV6cmFYOU9PT0Z4V0RyOW9jdVNEMDBtUXZWR1JKendUZDBFVUFPeEY3?=
 =?utf-8?B?aUpRakZleFR6bzA1b3dWQXBqTUJoM1VWQlV4Rk9jdmtMcTFGZ0NOa3JJSHVi?=
 =?utf-8?B?aHA0YmtZRUR1a3p1bDBWWlJMamR6Z0RSbDd3a1Z3Z1NNQSszT01PdVgyMDIx?=
 =?utf-8?B?VjM1ZWVsOWk4QzMwYTJnbkJXYVFpeHd1dEVLbHdXM3ZCN2RkSlpvYURMUTdv?=
 =?utf-8?B?N0ZGbEJ5TFhnbFRNQVdhaWpaa0I4UFFpRmRpTTloVE5pczk0WXMzeGg0cG5v?=
 =?utf-8?B?YUVVMnIxK2h4TkdHNWczcVlFVW1yTTZUc3VmVVpMUHpURGkxWXVBU3NLb1NS?=
 =?utf-8?B?Y2lRVUJOR3BQOVdWOXlEalRRU0pVYXVQaFUxck9vK3lKRlhyeGhQMnZQRDBR?=
 =?utf-8?B?NjVHWUxoRTZubDJPb2d4c28rR251dUdGNWQwVkl3Y0JGMVZubWtSc2RZdGJ2?=
 =?utf-8?B?aFN1cmFnTWJaNHNHUHdHSk04SUc3TWc5eU1KNlVML29RSDdDWnRMYnRvZ3di?=
 =?utf-8?B?NmwzSDlTcENzVW5qSkNxU0w4OFZrTm9ISDNKSXdNaXZ6d2VoVFIvZmkrQ2tU?=
 =?utf-8?B?anhrR0ZGMWgvVjM4bmJ2ekdObk8xUzR3TDB0dC9qQTNDRXRwc1BxZVFmWExD?=
 =?utf-8?B?NW1objFyWEVUNVNjVHRvRzZKbzROaU9mWXJmSllRR0tXZms1aFU2N1U4VkdG?=
 =?utf-8?B?VXhnQkxWQXNQNjhzK1ZMeENvcHkvTnZoSDA1SDFXTW81cDdNMmwrT1QvbWdv?=
 =?utf-8?B?bXNVem5mR1Mrbi8rbjVaK3NuQ3l6SEI5T0NrbjJPUzZJMUhzaHZGSDNFdGJQ?=
 =?utf-8?B?SEFNck1sNVJuNVltc2twYmpQN3MrbnYzT0hrVklNVTNWbkd0T1N1TVg2L2sv?=
 =?utf-8?B?WHNRYlowbll1aVJZb3k5S2xvcThFSkJxU3pxbkhYbzhjbTBHZTkvU2JGa1Fj?=
 =?utf-8?B?cVV2TklWdXhlRmI0Skw0MUVFeXgwU2FxWEsxRzQ4S2JRYXhXYWVzeC9BZDA5?=
 =?utf-8?B?ODk0ckE1NjFBVktJVjNtZDAzSDkxZUR1UzJ6eUN2U0Z5MTYrY3JkMEY1dGd2?=
 =?utf-8?B?dkwreXZsTXQrWEZSck9JTVhjd0h3UVdpOXZ6SGV1T0FkcExqR1hYMXR1TENk?=
 =?utf-8?B?c0VxWVQxdVcwM1dpWUFqSEtPc2N1K29KRE5MelhPSUhPYjVHN1ErQ3VtQnds?=
 =?utf-8?Q?+3l9CaMPi1em9us2JkB+m3eW2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e385109-db04-4196-daa7-08dc8c8c493a
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 16:08:53.3116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2HEugkZgc0yLRw4LkaMRYS5aRuAXlLgeGSMnHG6rN8ezz1lCtHGYlDLM7TN9we1BNX5kbaeaxohuDlGq5WdEHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6430

On 6/14/24 00:10, Li RongQing wrote:
> In CoCo VMs, it is possible for the untrusted host to cause
> set_memory_decrypted() to fail such that an error is returned
> and the resulting memory is shared. Callers need to take care

Can you explain how it would fail or where in the call path it would fail? 
Are you referring to the the Page State Change being performed by the host 
but it returns a failure?

As long as the encryption bit hasn't been cleared in any of the guest 
pagetables for the page range, then there should not be an issue. When the 
page is referenced it will generate a #NPF and the host will have to make 
that page a private page in order for forward progress to be made. But, 
that page will already have been PVALIDATEd previously, so the resulting 
#VC for the page no longer being PVALIDATEd will allow the guest to detect 
the malicious hypervisor and terminate.

If we fail during the __change_page_attr_set_clr() call and we get a mix 
of pagetable entries that could be a problem, so leaking the pages would 
be best in that case.

And since the failure reason isn't clear after the call, leaking the pages 
is probably the safest thing.

Thanks,
Tom

> to handle these errors to avoid returning decrypted (shared)
> memory to the page allocator, which could lead to functional
> or security issues. so don't free decrypted memory
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>   drivers/virt/coco/sev-guest/sev-guest.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
> index 654290a8e..799563a 100644
> --- a/drivers/virt/coco/sev-guest/sev-guest.c
> +++ b/drivers/virt/coco/sev-guest/sev-guest.c
> @@ -730,8 +730,7 @@ static void *alloc_shared_pages(struct device *dev, size_t sz)
>   
>   	ret = set_memory_decrypted((unsigned long)page_address(page), npages);
>   	if (ret) {
> -		dev_err(dev, "failed to mark page shared, ret=%d\n", ret);
> -		__free_pages(page, get_order(sz));
> +		dev_err(dev, "failed to mark page shared, leak page, ret=%d\n", ret);
>   		return NULL;
>   	}
>