Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp920485lqs; Fri, 14 Jun 2024 09:15:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU1HlYS1hUHzMp0bT4Nmuhzie7BuDahPxpqNA3rdBg2GR6Kdizfujsj9ZsDpNQeh0WAIz203lEf1EJlZub5P6kyF0tWbRVk4ZvfrmZYOw== X-Google-Smtp-Source: AGHT+IHuBbnSd+KSrdKc1DzIZjyBuEt9mz/7lr7hW7WXAwOW7Yk44uS5XsYowWnJfAWiGTj1Q3yF X-Received: by 2002:a17:906:3e13:b0:a6f:da1:d077 with SMTP id a640c23a62f3a-a6f60d296f3mr208251766b.25.1718381749289; Fri, 14 Jun 2024 09:15:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718381749; cv=pass; d=google.com; s=arc-20160816; b=N9LFZ9VaEKLE3FIDKD9MgO68Glp59RDgXA1GXHunUaygt9OPsGxJHKwbsZHrYIa3u5 Nfr5c4Idn3xsu53anmIRQb1OcUHYpaOQon3EaIi3llTVEsuWc+aIatfUBwVBovUamA61 Q845rmlwWhQAB/kV0axlvNXLZpFq5mgVNoMZk6730dGPOOPXjiMJHfuXAK6YUYiwurF2 Lwfzz0rfwC122tg1hNJDegFW38ImNt2HYPNOEf0IV6iAYxD84sg0vpA/efWfP5jKQgiD 8Qf5mNs2hwApG+KOV+kVkSEkm0m5Xn7DGj0npkQWZc0/FynZ04nOm/uK2e6Yde2pBHFA xr1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wwHXnjZTjzTLEZMiQyEwDy1felvNeA9oem+W0AanWzM=; fh=4hSbemFIETWIDEU/Jm/H51PKcfuWrghtcNgiVXhxM3k=; b=ocfE6CSzQ9dwSVsSCiKF+98YyNWzHMymq48WbaOUcyzQSWZ19a/LNTcHcTQapYSAeC FvKCz+sELeLFJIIirlfvybGedAmFRQPvDPw7kHTQSa4vPnbCRTAn/TviB3FyLH5/+9by 0CJ9Sa/IVtp+Ow6ns7H0M6FL4eWYqEI3hb56qJfxygROtxAjaLsWqm/NNRWarvAPPPgk ymMtqrtqsZovy6KFWy6vCMgsV1T46//oeD1sSmiQLEK61eJrgxxu4aVVxaumIiSTRIGk 7TGwYHR9mQz/8DMpL+kYVKsNRxNGWutc3c2TzmveJnL6mmVwWIbNtAh9PnR/gekSCcgS SH0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P4FzgjLd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-215214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215214-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f6ad2cbaasi49619466b.777.2024.06.14.09.15.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 09:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P4FzgjLd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-215214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215214-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 994ED1F237F0 for ; Fri, 14 Jun 2024 16:15:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A24A16F83E; Fri, 14 Jun 2024 16:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P4FzgjLd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F7C02232A; Fri, 14 Jun 2024 16:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381739; cv=none; b=SmbOewHjVKBr/31ZagPObp1RX7jNHt9wXVAIEz5dg7MBTloJX1zJ+Wc3XAoikYHaTgCdLy/pw/SRudn9ZvA1o4YIFaZlttLS+xPt8YqfZj8F9ixjU6dk9tR0VCklYMv/tYy1yNxQ2/30a2h61hTOUyW488hLcUFWC1VVCQZ1ByY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381739; c=relaxed/simple; bh=lLNDiROxpO6pLANFAbPa5fupMdZGiml5z4NIV4Owxxg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kZVluSrdCDuAhnnRHt0E0gHVVYJma6IamsRcGfnMDh18k800RaPqkFI7aOB6q2HBpyw68dRXOUn4AzDN2AJvGG2opo+o3aWvT0NFMpn7Vo0cLImhrhuCr7ALgn9GLzsdfvZIyh210+AMb0P7qOkXeZllrSBNhY3JAQg+z7u/DmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P4FzgjLd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A95DC2BD10; Fri, 14 Jun 2024 16:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718381739; bh=lLNDiROxpO6pLANFAbPa5fupMdZGiml5z4NIV4Owxxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P4FzgjLd3XJALTHDN5SZ0DxcxIl2HYKxFd1d1aBzzoSRnUkpUmVCpZXm/xtvyBN80 PZrbxByDpl6sJNTS3KK/kPylUy1+Bj2tygRjWXU+UxESnLf9B3wxhBPozqq4MfNlTm LbSi2Qa8ryW7VvzIorqf0YOhGAzxZ3IbJ3e84oJGUHLN/CTEZE2TTEtcFO4PhlsuY7 O9w2KFqxI31a6py5slXQiTIjMwlSV77lsFw5yl/lyfZiJooqBJ/3QYl/NoGVbDAkbH OY3EH9pOmIXepJF5k/2H9YGR1Z6AAh1ZMpZ/gCI7wn4dp6bl/fUTsgqrlM057+o+DD KkmKhHyb4MUMg== Date: Fri, 14 Jun 2024 17:15:34 +0100 From: Simon Horman To: Adrian Moreno Cc: netdev@vger.kernel.org, aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org, dev@openvswitch.org, Yotam Gigi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 3/9] net: psample: skip packet copy if no listeners Message-ID: <20240614161534.GT8447@kernel.org> References: <20240603185647.2310748-1-amorenoz@redhat.com> <20240603185647.2310748-4-amorenoz@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603185647.2310748-4-amorenoz@redhat.com> On Mon, Jun 03, 2024 at 08:56:37PM +0200, Adrian Moreno wrote: > If nobody is listening on the multicast group, generating the sample, > which involves copying packet data, seems completely unnecessary. > > Return fast in this case. > > Signed-off-by: Adrian Moreno Reviewed-by: Simon Horman