Received-SPF: pass (google.com: domain of linux-kernel+bounces-215231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 14 Jun 2024 16:22:54 +0000
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Brian Foster <bfoster@redhat.com>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH 1/2] bcachefs: use FGP_WRITEBEGIN instead of combining
 individual flags
Message-ID: <20240614162254.wwuoftv6cbm5x5t7@quentin>
References: <20240614105031.57032-1-kernel@pankajraghav.com>
 <20240614105031.57032-2-kernel@pankajraghav.com>
 <ZmxVZiveDdzyByTQ@casper.infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmxVZiveDdzyByTQ@casper.infradead.org>

On Fri, Jun 14, 2024 at 03:36:22PM +0100, Matthew Wilcox wrote:
> On Fri, Jun 14, 2024 at 10:50:30AM +0000, Pankaj Raghav (Samsung) wrote:
> >  	ret = bch2_filemap_get_contig_folios_d(mapping, pos, end,
> > -				   FGP_LOCK|FGP_WRITE|FGP_STABLE|FGP_CREAT,
> > -				   mapping_gfp_mask(mapping),
> > -				   &fs);
> > +					       FGP_WRITEBEGIN,
> > +					       mapping_gfp_mask(mapping), &fs);
> 
> Don't change the indentation here.  In the next patch it makes the
> lines too long.

I used clangd to do the formatting. I will probably stick without
changing the format in this patch

Thanks.
> 
> In general, don't change the indentation.  It's been one of the biggest
> pains of the folio conversion.  "Oh, you changed the name of this
> function and now the arguments don't line up".  Don't line up the
> arguments with the opening paren.