Received-SPF: pass (google.com: domain of linux-kernel+bounces-215305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <af6d496e-2f49-4f12-bc12-426e06d24494@collabora.com>
Date: Fri, 14 Jun 2024 14:03:48 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/ci: mark kms_addfb_basic@addfb25-bad-modifier as
 passing on msm
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
 Marijn Suijten <marijn.suijten@somainline.org>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20240613-msm-pass-addfb25-bad-modifier-v1-1-23c556e96c8a@linaro.org>
 <8aa99c1d-ca6a-a26b-96b5-82fc35cea0fa@quicinc.com>
 <CAA8EJpr5r=5MP8DqGPV7Ndz0zKy4Ar3u+RiqocLyt6eZWuifnw@mail.gmail.com>
Content-Language: en-US
From: Helen Koike <helen.koike@collabora.com>
In-Reply-To: <CAA8EJpr5r=5MP8DqGPV7Ndz0zKy4Ar3u+RiqocLyt6eZWuifnw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 13/06/2024 14:55, Dmitry Baryshkov wrote:
> On Thu, 13 Jun 2024 at 20:49, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>
>>
>>
>> On 6/13/2024 9:33 AM, Dmitry Baryshkov wrote:
>>> The commit b228501ff183 ("drm/msm: merge dpu format database to MDP
>>> formats") made get_format take modifiers into account. This makes
>>> kms_addfb_basic@addfb25-bad-modifier pass on MDP4 and MDP5 platforms.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>>    drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 1 -
>>>    drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt | 1 -
>>>    2 files changed, 2 deletions(-)
>>>
>>
>> Would be good to also give a link to the CI for the CI maintainers.
>>
>> But otherwise, LGTM
>>
>> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> 
> Yes, good idea: https://gitlab.freedesktop.org/drm/msm/-/merge_requests/119


Nice to see new tests passing!

Acked-by: Helen Koike <helen.koike@collabora.com>

I'm applying it to drm-misc-next

Thanks,
Helen

> 
>>
>>
>>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> index 3dfbabdf905e..6e7fd1ccd1e3 100644
>>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> @@ -4,7 +4,6 @@ device_reset@unbind-cold-reset-rebind,Fail
>>>    device_reset@unbind-reset-rebind,Fail
>>>    dumb_buffer@invalid-bpp,Fail
>>>    kms_3d,Fail
>>> -kms_addfb_basic@addfb25-bad-modifier,Fail
>>>    kms_cursor_legacy@forked-move,Fail
>>>    kms_cursor_legacy@single-bo,Fail
>>>    kms_cursor_legacy@torture-bo,Fail
>>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
>>> index 23a5f6f9097f..46ca69ce2ffe 100644
>>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
>>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
>>> @@ -4,6 +4,5 @@ device_reset@unbind-cold-reset-rebind,Fail
>>>    device_reset@unbind-reset-rebind,Fail
>>>    dumb_buffer@invalid-bpp,Fail
>>>    kms_3d,Fail
>>> -kms_addfb_basic@addfb25-bad-modifier,Fail
>>>    kms_lease@lease-uevent,Fail
>>>    tools_test@tools_test,Fail
>>>
>>> ---
>>> base-commit: 6b4468b0c6ba37a16795da567b58dc80bc7fb439
>>> change-id: 20240613-msm-pass-addfb25-bad-modifier-c461fd9c02bb
>>>
>>> Best regards,
> 
> 
>