Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp961202lqs; Fri, 14 Jun 2024 10:21:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVCoxZxMFWuENlr2xk2rd1VBZ/oJYe8GXS+AUvnPxR0ZsQPtzif/WjfZsHdNnXpBe/49jUxAreMRyX9Ourl+gdqhZV5m/cMidfoRIu+SA== X-Google-Smtp-Source: AGHT+IGdsjS5Fy68tuSawQDSgCtqYVh1cF+xK+OS/ph3K98HhzeSiyNjdOWRTzZH9uW6AXQFW1I2 X-Received: by 2002:a05:6830:1084:b0:6f9:610b:48cb with SMTP id 46e09a7af769-6fb93891a34mr3312117a34.35.1718385717218; Fri, 14 Jun 2024 10:21:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718385717; cv=pass; d=google.com; s=arc-20160816; b=Y+4MNwR0PZQ3S0XIQuq46CP9D6+GSlpGDWJFYRI3Yija3hdNmpbfgqb/rlnvu/cOd6 V6Cqgz16kgxOaNAuu8rIx+3YtV+898VpqsyBzl4BO1qDpNdeZ9EhqsNqy290UIJWdxuW sIKUQNGI4xMQ9whtLuiep88JBYQR5u+lQsxDRIQ/o43TZSaGUcHR4By7LSxMeWiarV63 ZqS+Urur9DNdKOwChVk/twQ2ELJmVsPG/AAhjIYFFC9Nwr5mpOHdq0HnzwjPbUEW2Ke1 keuM/a5XATcYqRhctVy+4tQbDkOUonGA6zUzjQTnetCVbNA2YIA1Gdwk+VSnnNW1VzFc LXMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=7WxTEYKOsZR4+Yha2WQiGOVRWeuktRbQ1fQvrPu2i9M=; fh=qheDvxMn+Xy71TkmmoZqTuwehC3+LzqqDS9YT2mYwfM=; b=inYoOK+Y9glh47VSkFdJTidKVb5cJSs6xQCgBtR3Jnanqiv6gc9g7p64kMWxzHAFXd QSAyqu83jFSozwYnN4j1Fg4vdIClzwPiDxWVuKyfh0WeIa7da5bgf8mB8hgvlUmdBNb8 jVHMKDPvyUFdxngdRRX8IJOn6ApNbOGG0XAYm5RocN4HfkMO6XTlRK/pp/nosG8xMTbd uyrHtua4Xwt8lkcPkESGInah8pLn/JVDcp6kjMscrF+0mtuq06GgPblvq1lGYpG10hHM HOANV5Hl4tA4COXnzurQeWpbKO+Nth+BSaI5eeV+J3T5zj3LioNgtZlfdlWnKs1wM/w7 2PXg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=CDBUNfek; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-215335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215335-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-798abe5c1a8si407103785a.645.2024.06.14.10.21.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 10:21:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=CDBUNfek; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-215335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215335-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6F8381C20A97 for ; Fri, 14 Jun 2024 17:21:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3DD319ADB3; Fri, 14 Jun 2024 17:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="CDBUNfek" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC3E815FD13; Fri, 14 Jun 2024 17:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718385711; cv=none; b=DaaEIticxNS0Ts2drIGsmUhIXFLocSsgAoVn3qtiNRDHqJzgybMqpsM4B13mm8RYaDfm02K4ZNVtV2Uiw+zPoGNR9lcnsWRiv2SUaSTV83oCGeUJkQSJNX1Ij652/DenhNw4fm5zM4zo5Bj0Pgq3znJMqIVRZAObAxNYByanbxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718385711; c=relaxed/simple; bh=P6JtOjCs6Jj3m4upHVfTuWBdfTxPaTKNa00iSGnrSbA=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=TpE4cYXLuOLtCduvuAry9iffXLKhaK7Ru7U/+Q5SJa1PlxQOrb1jB5O6kHO9ITjGryk54Pjp6uTvgyaDNF7BJvcUZElDfdVPS+Y1Y0BTMWeI1WKa9dRO57XGISIllhbNLXj2nEhfR1QdSOqFpXTe8AtfA3mNnV/9kkgmo4BqoVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=CDBUNfek; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D4C8C2BD10; Fri, 14 Jun 2024 17:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718385710; bh=P6JtOjCs6Jj3m4upHVfTuWBdfTxPaTKNa00iSGnrSbA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CDBUNfekePxrjpUgM4+htLAUDXr17ezDLUgCh/vX5jXsJno6qwWfIAwXMgT+egUYB AOkEkoFrE6ugrNb6ANRtEJrDYc11NMyFmOiHBpLDNiwXlf97VqpbfNql98B+po6h7e gntqUfebPK6yjawrUFef5RAjC22kEder7Y95AccQ= Date: Fri, 14 Jun 2024 10:21:49 -0700 From: Andrew Morton To: "Liam R. Howlett" Cc: Bert Karwatzki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: commit 1c29a32ce65f4cd0f1c causes Bad rss-counter state and firefox-esr crash in linux-next-20240613 Message-Id: <20240614102149.f752c1609106b97ea302ccf0@linux-foundation.org> In-Reply-To: References: <20240613170351.cc3e7ccfa1bb198b57f31352@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Jun 2024 08:30:20 -0400 "Liam R. Howlett" wrote: > > > > > (these are the error messages of several crashes and the error seems to affect > > > other processes, too (T1)) > > > > > > The crash can be provoked to appear in ~1min by opening large numbers of tabs in > > > firefox-esr (by holding pressing ctrl+t for some time). With this I bisected the > > > error to commit "1c29a32ce65f mm/mmap: use split munmap calls for MAP_FIXED" and > > > reverting this commit in linux-next-20240613 fixes the issue for me. > > > > Thanks, that must have taken a lot of time. > > Yes, thank you for all that work and apologies in creating this > frustrating situation. > > Andrew, please drop the set from your branch. I need to write some more > tests, but I suspect I will need to do some work around the vma_merge() > function, which is never a fun endeavor. Dropped, thanks.