Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp972809lqs; Fri, 14 Jun 2024 10:44:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWnKB/hmo5QXptKrJHiWPXu8NzmBcOIMeM7qcdo3utuKhuNqbTx+zPLsjqdHf0cuLVOxzYicJfQ91NqdmOTX0zEQrACqgzUyJn7MIPshA== X-Google-Smtp-Source: AGHT+IEl4c3BaP4qPrxmT7Ybxdf3pPkFrLAO8xJquOqT84M4Mc9BwewfEexaaZqHs5druopk3c8q X-Received: by 2002:a17:90a:f488:b0:2c2:faf7:67a0 with SMTP id 98e67ed59e1d1-2c4db24d28emr3536849a91.16.1718387048866; Fri, 14 Jun 2024 10:44:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718387048; cv=pass; d=google.com; s=arc-20160816; b=vM72O+n9qOpFZAO95wfGAVBeeyrQuehVatIGahXgCzcXhKFEjkd1E2snbCRExk0ExI HX4JqLMHz5uQdPGTRLdtnxklDW/UdQAf3KIM8HWC6uXXkbhGsW3A2JjeE/EAd2GDWpIK 3b2VstPnrhlpxUNGlNm9qVvx/FgY8115NH5r+D+QmzyljX0bfAYAHSiBx75C5cJEwHOP 9CeEI0AcePTx0sTtOfKVG0Ah94pEcNHieT2gnHSVf3A75SrvlMuxfPZbpuhkSUzuwAQf ybfOF7fXOYLa3aKfgltg1ueXjXi5ASUnrYNaIfn3xcb5z9n2IoNVP6PE5rTGtsjNdGVR 9xkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6A2ldgCGRbiaAOg5pCXVmpJrxkciuNJ03uPiR1OSrWk=; fh=3cyO/ZPnSGoCBVQRVo0LLp5jCx9kje+fl3NVYrNe7uM=; b=nc5O6SnhVPD2u1e9uxQXoP5yF0D3UyLXSU7j+LmOTYNqRi6WRnHOH/ZekR9sSPF2Ib yZfw/WKns8Y3/nsN2esq/2PHNlhy2zOW7ZOriz9snFHpERd/UhMaPLI5DWI++NOq1Na2 RoYn9Ituae43uEsNSVHIL4oy2fpZrjZPu9FdkgT/tD8lTWvcSaP4zHf50jLKelMQAs0j JpR3BP/8H0C+13GxPwUBPG8xASPwQKGqcgHP3jJ7WnmTglrOUpj1kSfedi139SAYP9hs fK3YLZaJyWXKM1iHheE4doexvScx6CnTcl4f6mt0LHue54AADn+kalbu6CDPh/3u9gRE 9d5w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k0bI5cyJ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-215380-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215380-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c4c470dba4si4066614a91.95.2024.06.14.10.44.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 10:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215380-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k0bI5cyJ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-215380-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215380-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7C55528B258 for ; Fri, 14 Jun 2024 17:38:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8500E1AC45F; Fri, 14 Jun 2024 17:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k0bI5cyJ" Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787091B0118 for ; Fri, 14 Jun 2024 17:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718386385; cv=none; b=Yqca2xo5xTMcvW1yC+/OtVqMAYmV4c9Tu42aEGhXJukR2vXJKI96P9z5sWhhzOc6SHHAopn299aVXJLVViVbVshFZm3SoDuIgUlwOTTeT2Wo0STSdTXEJRkoQRXEwDXyfVS+Ufg2alFbNKsEz1ljNACwaVu2+DzjhMMfIlQ68eA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718386385; c=relaxed/simple; bh=5JfwGvXC3wQ1kOI8Zh+NA4+SfUuzSprZAy/CCQ3H0sU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IKWEj7zinPBV+qNBo0XMwWJmI7dLcBOzF0EGAoTL50xcYvGmYV4Lf9h3iAGTe2uxbGHBFJkOlKoXypsc3mpLF4N1uUbj6sEjh6WXTLVGMH8Q8cNI0tTwuMoImflsrh6LdHnMMumaZzCZMiBYl3hBzMN8QCbFTH3cmsDVCiB2Yo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k0bI5cyJ; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ebeefb9a6eso24038181fa.1 for ; Fri, 14 Jun 2024 10:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718386381; x=1718991181; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6A2ldgCGRbiaAOg5pCXVmpJrxkciuNJ03uPiR1OSrWk=; b=k0bI5cyJ2RWxOTjr3j4LCy4mtrzAM7so5zwcCWFMg4VBkr2kmFAwaKAlFDUq0QCaoi gGAYCaveZxfLEVw5aVNaNds0zgf0HRpn7hgH5OG2zQ5rsn4ytzE2yq6xLB6hqMHj4QUm fqG0C4bq+c3jruCIh3JpdFZkizSZvMCLMAK+As1d/yGfzJDSf2uSXQ/g9C1HaOwRhWDo 3vZeVr5K7veTuO4PiwAj+9kJTGOyi/a/zjeiEb1LrtV4QhXNUNNRg3YtaSokPm92PMPa 3oSBQ0K3pm6nJf+jB6IpMJkTzM3gOCdiGGzgUaHyyZot75cX/YZujXaxZqoNF2ygWdxW vM2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718386381; x=1718991181; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6A2ldgCGRbiaAOg5pCXVmpJrxkciuNJ03uPiR1OSrWk=; b=UdWIgFiU76CT8e8EZrVHdo0otdYCqXAEpwce7v+PfiEeLQynwhqovTcrnkbCuqw6Lj VtVQ2S0FaL5kwc29UWuo0WBfBXUR3zVfC9bWgmxQOkJroQ/pNuV6/tuzNETQeZAazM/x 4z7gcuCIs3MEmT/2j7CLsIFLwFQ61IcL6K+E7YKB7XdidqM8mC/RmNgCZ5JdjhIsYvgj RWdO5vJ7C2avQWfklt3tWg73ESc4yDi2JrEy9MVfd3DQxdhJqM1CGkgqzkVckBXbD1XE NzILrJ4SmgsivNX5kXbdJtyIqXzsf0mvSqn/g2d2Z5mymti2xuZ+au+/PLqvvuk9RB88 UcOQ== X-Forwarded-Encrypted: i=1; AJvYcCUVAVBIoPitkoVB41na0YpgoUwz0ft/J9KfAGM4hj7SEsdlBBm9jFtW8ZzZsEkoRXHOUmEB7g4H5j/daSAtZGfwY2k6Wt9gWmx6PIQC X-Gm-Message-State: AOJu0YxYXTZZ3LK8wAOv85mGs+GqX8pRGVPfAcSTjgAyhYaSpcjAkJy8 ltX+Dk/8F2YhO8oqkjT2A9JX3MlauBj490mrlY6JA68KgvaEBdLoNk49BRp4c1I= X-Received: by 2002:a05:651c:220b:b0:2ec:165a:2250 with SMTP id 38308e7fff4ca-2ec165a2453mr18905411fa.6.1718386381498; Fri, 14 Jun 2024 10:33:01 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyybrhy-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::b8c]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec05c06fecsm5894881fa.49.2024.06.14.10.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 10:33:01 -0700 (PDT) Date: Fri, 14 Jun 2024 20:32:59 +0300 From: Dmitry Baryshkov To: =?utf-8?B?QW5kcsOp?= Almeida Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel-dev@igalia.com, Melissa Wen , alexander.deucher@amd.com, christian.koenig@amd.com, Simon Ser , Pekka Paalanen , daniel@ffwll.ch, Daniel Stone , 'Marek =?utf-8?B?T2zFocOhayc=?= , Dave Airlie , ville.syrjala@linux.intel.com, Xaver Hugl , Joshua Ashton , Michel =?utf-8?Q?D=C3=A4nzer?= , Sam Ravnborg , Boris Brezillon , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Jani Nikula , Rodrigo Vivi , Karol Herbst , Lyude Paul Subject: Re: [PATCH v6 0/8] drm: Support per-plane async flip configuration Message-ID: References: <20240614153535.351689-1-andrealmeid@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240614153535.351689-1-andrealmeid@igalia.com> On Fri, Jun 14, 2024 at 12:35:27PM GMT, Andr? Almeida wrote: > AMD hardware can do async flips with overlay planes, but currently there's no > easy way to enable that in DRM. To solve that, this patchset creates a new > drm_plane field, bool async_flip, that allows drivers to choose which plane can > or cannot do async flips. This is latter used on drm_atomic_set_property when > users want to do async flips. > > Patch 1 allows async commits with IN_FENCE_ID in any driver. > > Patches 2 to 7 have no function change. As per current code, every driver that > allows async page flips using the atomic API, allows doing it only in the > primary plane. Those patches then enable it for every driver. > > Patch 8 finally enables async flip on overlay planes for amdgpu. > > Changes from v5: > - Instead of enabling plane->async_flip in the common code, move it to driver > code. > - Enable primary plane async flip on every driver > https://lore.kernel.org/dri-devel/20240612193713.167448-1-andrealmeid@igalia.com/ > > Andr? Almeida (8): > drm/atomic: Allow userspace to use explicit sync with atomic async > flips > drm: Support per-plane async flip configuration > drm/amdgpu: Enable async flips on the primary plane > drm: atmel-hlcdc: Enable async flips on the primary plane > drm/i915: Enable async flips on the primary plane > drm/nouveau: Enable async flips on the primary plane > drm/vc4: Enable async flips on the primary plane > drm/amdgpu: Make it possible to async flip overlay planes > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 ++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 +++ > drivers/gpu/drm/drm_atomic_uapi.c | 8 +++++--- > drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++ > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++++ > drivers/gpu/drm/nouveau/dispnv50/wndw.c | 4 ++++ > drivers/gpu/drm/vc4/vc4_plane.c | 4 +++- The main question is why only these drivers were updated. > include/drm/drm_plane.h | 5 +++++ > 8 files changed, 29 insertions(+), 4 deletions(-) > > -- > 2.45.2 > -- With best wishes Dmitry