Received-SPF: pass (google.com: domain of linux-kernel+bounces-214923-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Fri, 14 Jun 2024 16:01:01 +0300 (EEST)
To: Dan Carpenter <dan.carpenter@linaro.org>
cc: Frank Li <Frank.Li@nxp.com>, Jon Mason <jdmason@kudzu.us>, 
    Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>, 
    Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
    =?ISO-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>, 
    Kishon Vijay Abraham I <kishon@kernel.org>, 
    Bjorn Helgaas <bhelgaas@google.com>, ntb@lists.linux.dev, 
    linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
    kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: endpoint: Fix epf_ntb_epc_cleanup() a bit
In-Reply-To: <aaffbe8d-7094-4083-8146-185f4a84e8a1@moroto.mountain>
Message-ID: <7ae11357-6284-9afa-2272-19e796bc2018@linux.intel.com>
References: <aaffbe8d-7094-4083-8146-185f4a84e8a1@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1326312854-1718370061=:1013"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1326312854-1718370061=:1013
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 10 Jun 2024, Dan Carpenter wrote:

> There are two issues related to epf_ntb_epc_cleanup().
> 1) It should call epf_ntb_config_sspad_bar_clear().
> 2) The epf_ntb_bind() function should call epf_ntb_epc_cleanup()
>    to cleanup.
>=20
> I also changed the ordering a bit.  Unwinding should be done in the
> mirror order from how they are allocated.
>=20
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and =
EP")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/=
endpoint/functions/pci-epf-vntb.c
> index 7f05a44e9a9f..874cb097b093 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -799,8 +799,9 @@ static int epf_ntb_epc_init(struct epf_ntb *ntb)
>   */
>  static void epf_ntb_epc_cleanup(struct epf_ntb *ntb)
>  {
> -=09epf_ntb_db_bar_clear(ntb);
>  =09epf_ntb_mw_bar_clear(ntb, ntb->num_mws);
> +=09epf_ntb_db_bar_clear(ntb);
> +=09epf_ntb_config_sspad_bar_clear(ntb);
>  }
> =20
>  #define EPF_NTB_R(_name)=09=09=09=09=09=09\
> @@ -1337,7 +1338,7 @@ static int epf_ntb_bind(struct pci_epf *epf)
>  =09ret =3D pci_register_driver(&vntb_pci_driver);
>  =09if (ret) {
>  =09=09dev_err(dev, "failure register vntb pci driver\n");
> -=09=09goto err_bar_alloc;
> +=09=09goto err_epc_cleanup;
>  =09}
> =20
>  =09ret =3D vpci_scan_bus(ntb);
> @@ -1348,6 +1349,8 @@ static int epf_ntb_bind(struct pci_epf *epf)
> =20
>  err_unregister:
>  =09pci_unregister_driver(&vntb_pci_driver);
> +err_epc_cleanup:
> +=09epf_ntb_epc_cleanup(ntb);
>  err_bar_alloc:
>  =09epf_ntb_config_spad_bar_free(ntb);

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-1326312854-1718370061=:1013--