Received-SPF: pass (google.com: domain of linux-kernel+bounces-215396-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 14 Jun 2024 14:10:58 -0400
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kris Van Hees <kris.van.hees@oracle.com>, linux-kernel@vger.kernel.org,
        linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org,
        Masahiro Yamada <masahiroy@kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Jiri Olsa <olsajiri@gmail.com>,
        Elena Zannoni <elena.zannoni@oracle.com>
Subject: Re: [PATCH v4 1/3] kbuild: add mod(name,file)_flags to assembler
 flags for module objects
Message-ID: <ZmyHsnXQoWgp7F2X@oracle.com>
References: <20240614171428.968174-1-kris.van.hees@oracle.com>
 <20240614171428.968174-2-kris.van.hees@oracle.com>
 <20240614134651.4ed2091d@rorschach.local.home>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240614134651.4ed2091d@rorschach.local.home>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ChT3cPdSHNhXRqSzwtxs6kYlSfSfV7zwZmOXmgMKsRnerrdpfYQzKHMOhlQq?=
 =?us-ascii?Q?zZJRHOqf0YuWkapZFT6ndZwPHVQCgFfgid3B57HE4prae11EVcgNhCrUxmpj?=
 =?us-ascii?Q?hDLvH0lq90MoXjDqGvnSns232b0jv1eVgxggkoyRtfaEGQu5Am5uZ9KlbGQj?=
 =?us-ascii?Q?oSXluoB76qXfeukF4UI8F9hUwNdkswe7D6GCskVtQyW/r6/H+jkDKFpza8yp?=
 =?us-ascii?Q?9ezpYnpdauAcK4OKus+hduPAX1DB/fLQZHT9aVPkjom6U3k/Pr2nPMYSrAAB?=
 =?us-ascii?Q?9jQ7LIQIKvmbHwDyqesu63kUrH3xVJeYHuUXufdASSecnCFVG3y1PBGmVgZS?=
 =?us-ascii?Q?XFcsmnkHaxo+oPmDDVpfwfRp7vwpfPVD7fljSg1bKpCSOTseAUvl4RK5vXFa?=
 =?us-ascii?Q?O/lDLJWbTAxLbJSCpFPTgz822ph2zniUJ8VLO2LxvJ4MaWdPkaR+aZc7x/ym?=
 =?us-ascii?Q?w32z1luM5Grr4qhF34X0uXJ2NxxAgWH+E2rP8YxoVAzlY1z6+/tztIhIa1vP?=
 =?us-ascii?Q?pugbQ3krvq3GsRI60BiZXAtVYbDBI+izVANQ5DS3SZtXgi6EhuPg0HgmxyY7?=
 =?us-ascii?Q?zga3SPRAv1X757bOtN2dUMQzySMRrryIcV5TaU/2L9kW7mpYJ1orB/FdODrq?=
 =?us-ascii?Q?qOj5SG/qnNx92oM46IXzgz7crNUoQ0SuVylR9jmGIPc7OCB/58Tox2d4SIYq?=
 =?us-ascii?Q?6N3+16/FWTJtbXlY2rohFY34ljRct+klEHElIeXMJH7kE0OW26dAD5sGb+1M?=
 =?us-ascii?Q?2JVc39Ma11Asb3VudzvtZ3CbbDh/6+bx75YwysQpW6dkqpx6ttm/cYbPWKoe?=
 =?us-ascii?Q?LzWqLa1qbVmpof2n1s1mXjk+ZNpU+LpLx2Gqzg9QCRX3N5dWpWsHoBcIdhJj?=
 =?us-ascii?Q?4W8j0Yfrc2XO5UCS9YxZ/630h4JSOLABjPhxpkDoo9GVbTerCVI89snIT60T?=
 =?us-ascii?Q?m/+4jCXZ/wRo4X3L3gtwmdKJA4Z5C74OgfvfPEVe0NCNevuaEtttK/WMO0DH?=
 =?us-ascii?Q?uYbJkNnMqIck3AOCmrxrWljc9U+NJppcXwme5dJISsVTgv/MDjp06jcnfGKO?=
 =?us-ascii?Q?91ZgQVNGVRjP5+W9WBiyV4LuFGUVvcenmvjcaXLqEN+YOowa841w08k74tcw?=
 =?us-ascii?Q?uVFoo8DH2KLxbC0Lqcdmd/FdLX5/StmSLNqitAY4DeN+kWMqbeeBR0M21oS2?=
 =?us-ascii?Q?G0Nud7WxmerAJcDZz0qCM6Fk9KQI9AuHVAMFQOOAbaTYAuOtFBJ+Zok2cIWi?=
 =?us-ascii?Q?jxRkRm5yqzkaMSUYbMvaO2VR+ID2M3sOXIRjvrrEx1S9rkOawRjSaycEF1yX?=
 =?us-ascii?Q?ExiH5m9R9apuTIUd+u2B6t+lT0SDismh36eXdMT7Cm/xKEEA/kov6KICIr4H?=
 =?us-ascii?Q?6ffKK2RoY7Qd0viDsYxTH8+DS12MG3ip53taX/8ORNwU3wZCRsG/LAlfF63y?=
 =?us-ascii?Q?VNdT0nRv6WyKsMzSfyGpjKhFwKMSGn9Wd4hAxOGp4htOqoMmJNfuIC6sJrLw?=
 =?us-ascii?Q?DK7Wdda95ylnsTgKk5J6TSAK5mW5v9U/cCMiHSaMg243tYX+7v7GZ3qLouZo?=
 =?us-ascii?Q?SeJ73+Ea2q3I1x8fDSLYXupvtAQPZWn/kOhFTxZ/gIv+I5qZ5VbQXMtvEGae?=
 =?us-ascii?Q?7g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	3kkkD9X7ARIswbYh/Dv+FTG5TnoZ5DA8od/SZevltnKkU5rnnCVDjT8F8vHj6bkD37yHfXywS1xQe7JV+H0/QltvXOhiUxzxqU1yW6GJBSe6ojR6FD7ryHnCujOUjlWskvsifH3TtikeF3xQH3vNxxuDRiFxKUDYn1HNIKc1sV82zwUHJx7EsQ78/fR+w3HyeGM4n4SQDoyZrtzRpX0yetPTrcPmmJhzfZ50nP/fWpmEXjDtU2lfwAFcgBueeCDPWOsUf1ik4oxltRQEG+B1UrEUFE21n/WKpL+7MXlZ4ks0RTAa0DExmit7NimUHl0L9wKSXjKAw/Eql5ViT8hm0PeGiYD/K2jcvJbG1kU7m5inBtSJHx48IxnMs8VW/CsccqmYc1MG+Mkwx0O2AeB+cv5TX5WK0KXfA7BWBIzMMedXVnQEkJrtCkHLMDB5y7dQgnp8UVVQAH1nSPUeYQnz3fblDocvuEKrIx/q21ygrjbyExQ9EW1AdkebTxxxy1b1Rx1DrU52ueBpVRA4c8Ua7uWGZvlqlL3BZQ2DyI9dEZ9gadunJzK8Jqm08mm+VgJXKzRhzvSVTaslnljkx7J0LCh+zh8Xoq26Ko7tylMJB50=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b53a7c8-2643-4b4e-f926-08dc8c9d58bd
X-MS-Exchange-CrossTenant-AuthSource: SN7PR10MB6287.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 18:11:00.7637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U2+AZjfaYDXH8hk+YzKWN1Ln2rbmm7y1LExMoNzG0gNFE4DmmABMiCLqXa2z78Z7c4GVmvlA5OxV7sRGUgkVjDnN9p7jTxaQrNL7zmfR7Lk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5881
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-14_15,2024-06-14_03,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=733
 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2406140125
X-Proofpoint-GUID: 48CZjxQmVoXwKRvn58j2TvOn9Arskzin
X-Proofpoint-ORIG-GUID: 48CZjxQmVoXwKRvn58j2TvOn9Arskzin

On Fri, Jun 14, 2024 at 01:46:51PM -0400, Steven Rostedt wrote:
> On Fri, 14 Jun 2024 13:14:26 -0400
> Kris Van Hees <kris.van.hees@oracle.com> wrote:
> 
> > Module objects compiled from C source can be identified by the presence
> > of -DKBUILD_MODFILE and -DKBUILD_MODNAME on their compile command lines.
> > However, module objects from assembler source do not have this defines.
> > 
> > Add $(modfile_flags) to modkern_aflags (similar to modkern_cflahs), and
> > add $(modname_flags) to a_flags (similar to c_flags).
> 
> You explain what this does but not why it does it.

The first paragraph is meant to estabish the "why" (being able to identify
what objects are module objects, even if they are compiled from assembler
source).

As I mention, for objects compiled from C source code, those defines being
present identifies those objects as belonging to a module.  For objects
compiled from assembler source code, those defines are not present.  Passing
them on the compile command line for assembler source code files for objects
that are part of one or more modules allows us to identify all objects that
are part of modules with a single consistent mechanism.

	Kris