Received-SPF: pass (google.com: domain of linux-kernel+bounces-215394-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9f3d50b9-6acf-4bab-b6ff-cd524ad0a2c8@nvidia.com>
Date: Fri, 14 Jun 2024 11:02:32 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing
 __NR_mseal
To: David Hildenbrand <david@redhat.com>,
 Andrew Morton <akpm@linux-foundation.org>, Jeff Xu <jeffxu@chromium.org>,
 Shuah Khan <shuah@kernel.org>
Cc: Andrei Vagin <avagin@google.com>,
 Axel Rasmussen <axelrasmussen@google.com>,
 Christian Brauner <brauner@kernel.org>, Kees Cook <kees@kernel.org>,
 Kent Overstreet <kent.overstreet@linux.dev>,
 "Liam R . Howlett" <Liam.Howlett@oracle.com>,
 Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Peter Xu <peterx@redhat.com>, Rich Felker <dalias@libc.org>,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>
References: <20240614023009.221547-1-jhubbard@nvidia.com>
 <20240614023009.221547-2-jhubbard@nvidia.com>
 <1ea35568-bfe5-430e-9f4b-edef17f0b22b@redhat.com>
 <e6378446-6087-4ffc-9ce9-320c5e128bd6@redhat.com>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <e6378446-6087-4ffc-9ce9-320c5e128bd6@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WTBGc2xJT3pKaGhwOEJpT1ltNGxqNTA4MnA2bVZEYlZtMWZyNWRheU5pd1lG?=
 =?utf-8?B?VHJIcWJmZmh3N0ZlN2c2ZmpSTjg4L3VvK2luVmdTTFc0RUNaYjBBalpxSUVa?=
 =?utf-8?B?RVhPNnRBZFIrN0tlbnNMVmhRandra1JORDBnWU8zdEZVZTE2UWhyL01lTGdC?=
 =?utf-8?B?RDRXMSs2ZjlzVkNYZmlYR0EzalowTVdqMU5CbnhTeng1bTBCWDhJT1YrSk9O?=
 =?utf-8?B?OXk1N0Y2SmtlcFgxdEhPWklRSHlNaHh6VHQvY3lqYnJ4WXFyT1RWVGZUdkFD?=
 =?utf-8?B?aFlpakx4ci85L3Vma1J0N0U2MG5YQ1pmUWJMNDJHSzBIQi9NbTdzWnJlb0RQ?=
 =?utf-8?B?WlR5bVVzTHRCMXljSXpBclkyYTFIVjVLZjVrVEJDQkdIbG1CY05nZzhDTncv?=
 =?utf-8?B?SEZLcTRqSm9IRGdzZzN5T1RzUzR5S0tDR21QWGNSTW4zdEVSczFlMkE0eG52?=
 =?utf-8?B?R3Y4TGl5QUd0NmhSanpCUTA1L3MrMThHK1dnSVo4aHkrQ1FxWEU4Y2E5WDRy?=
 =?utf-8?B?RTVrSGdNWStYeXJHUE10ck1ab3ZCY2Q0SnRJUTIzTHpxb2JmUHZVMGJwa2JG?=
 =?utf-8?B?cjRFRzlBb2lhNXgzbzkyc3VYd3FKK2k5cDlkZm16T0svK3BOcVZNNFlxVjZE?=
 =?utf-8?B?T0hoaTd5U0Uybys2TUo2RnF0Y2tSeTZ5bytZalIxemhRN1VFL0FEcFI3MW1C?=
 =?utf-8?B?Sjh4bEp4ak82NFdkMnhKbmRwNXRiVmUycUJNTW5majl5dklJa0tWZ1hnY1JN?=
 =?utf-8?B?RWdJeXVTNHF1bW9FcDNhanBFcjVqNU8wblZPeHJkbjNkaE1CamJvUmdkVUVa?=
 =?utf-8?B?QlJEdmhGTUk4V1dMZGV3VDA0cHRMY0NiZHR6QnU0ZTBYc0hZcVdQTk5FYXZQ?=
 =?utf-8?B?eDFSd0t5Q3VaZFB6SngzK1lPa21rSm9DTFBzZmdJdUxqcFpMZ1lPYm54T0R0?=
 =?utf-8?B?aWZmQUp6aTdobW9RRGRDWGw3NmZzY2NWYUR0Q05wVlkzQkMvTmppdXA4bUlJ?=
 =?utf-8?B?QlM1Q00yY2ZnQXN3SkZYZExDdGtsS29xOGhHblQ0ZGtnT3BncDFGNFloOFlr?=
 =?utf-8?B?ZmM2Y2pWNzlOcnJWS2tCU0trWkRyVURPaG4vVm1mWU1EdVk3ampzem0zNmhF?=
 =?utf-8?B?cjVTbzFNbXVSTXJmdHZZUnVKTHBCOU5uSEJwc0FFT29iNGlkSEEvY0QwVTNU?=
 =?utf-8?B?aGIxZ3lJOGxtd1BiMW9zZEE3UkxsRWpXdHZHOHREbzRsdGhWTlFNbGFZZWt0?=
 =?utf-8?B?Zzg3MGIzRnRqbkhUZnBTTlFCY2luZGJOcWtOVTZ6REpBWklsS1Z0SXU0R09V?=
 =?utf-8?B?UFJXUFpZblMvNVJzQThucVNoc1hsY3d0MHVRT1hFdG42bGsvSXQ3WnhXUWIv?=
 =?utf-8?B?RGJPNWgxRVRhenpyRDlvVFJhVGdpSVhYaTdzOXJPakV0eHVVSjRzR0RTcXpL?=
 =?utf-8?B?VUNlS2pxcnBEdjhrQTBLa3ptMXRySnYxODg5dS9FRUhEK1IvN0x4SXZOcXRi?=
 =?utf-8?B?SWxmTG5FV1Mrc1k2UDgrbG1Wd3JqYUQzRjRnTVF2R3ZjOWhKdVIra05VRDdX?=
 =?utf-8?B?NzJmYXhxc1ExSTVjb1A1dmhSTTFtb1VEM2hQU2dza3lDUC80YkVjaVpHZEN5?=
 =?utf-8?B?SUZPS2Q4cmJpTzRmOEdTQVIrZU11b2lvYkdQaHZEaC9rc1BLdGZseVFydmpn?=
 =?utf-8?B?VzBydnNab1B1dVhkc0hzcUIyTVZpc1lnbUVDOEJaZUdwQWdpeGNUd3MwQmVF?=
 =?utf-8?B?VWNKUnE0d2xFUFk1VWZPblhiQVlsTG1ST0plNXhSbUt0Y3FCUHpJM1pxdCs3?=
 =?utf-8?B?TjhXZXRJa1NYUUFFUnNWWk44V0hTc1RHZWJHOHNqQkZXQ0FyVktEaVpZZ1Zx?=
 =?utf-8?B?OTM4d1JKU2xycVN1T0ROSExBNnFLbXIwWUxsVnVubHNLU044a1RIMmpPMThR?=
 =?utf-8?B?ZUVjSWM3WUNBaXh4SkNrS3hFYXl2OHhqbitrRWg4MzEveS9YWWxETDdmWisw?=
 =?utf-8?B?Ly9MRW0yOGZoa2NlOUUxRXBqcElFcEhPTldmbzdRYmd0TUYzcXVRT0Qzb0t3?=
 =?utf-8?B?dE9UN04xdnpCN2liQnFzUGpqMEtHdFN0OVNCTmthWmdWcHE5bjFsOTRZdjMr?=
 =?utf-8?B?anI4OVBPQkVOa0FPYUs5VGNqT3gwalUvaFVxYzEySDZXSWUrUzNJTjM3c3E4?=
 =?utf-8?B?K1E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fdaff84-dae8-4621-5ead-08dc8c9c3f77
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 18:03:08.8570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9NdWvyTeoaMkd53vuaeuYD0jjZGs4NoyvbsLuhMAS5qKAVXTNmg+QAXSmIYrpYaVu/rKb8JPFANLc+iEk58TEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7730

On 6/14/24 5:41 AM, David Hildenbrand wrote:
> On 14.06.24 14:28, David Hildenbrand wrote:
>> On 14.06.24 04:30, John Hubbard wrote:
>>> The selftests/mm build isn't exactly "broken", according to the current
>>> documentation, which still claims that one must run "make headers",
>>> before building the kselftests. However, according to the new plan to
>>> get rid of that requirement [1], they are future-broken: attempting to
>>> build selftests/mm *without* first running "make headers" will fail due
>>> to not finding __NR_mseal.
>>>
>>> Therefore,  add ./usr/include/asm/unistd_[32|x32|64].h (created via
>>> "make headers") to tools/uapi/, and change the selftests/mm files that
>>> require __NR_mseal to include from the correct location. The way to do
>>> so is to include <linux/unistd.h> instead of just <unistd.h>.
>>>
>>> [1] commit e076eaca5906 ("selftests: break the dependency upon local
>>> header files")
>>>
>>> Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing")
>>> Cc: Jeff Xu <jeffxu@chromium.org>
>>> Cc: David Hildenbrand <david@redhat.com>
>>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>>> ---
>>
>> If it works, great
> 
> ... thinking again, are some of these headers arch-specific (IOW, 
> generating them per-arch would result in something slightly different)?

Oh wow, yes they are. I'm guilty of x86-centric thinking (again).

hmm, this is going to make it really a lot of trouble to do this
approach. But there's no point in turning back now, so I guess I'd
better fire up the cross-compilers and generate for all the arches.

> 
> In tools/include/uapi/asm-generic/unistd.h, we already do have 
> __NR_mseal ...

Yes, but it doesn't get used in selftests/mm, with the way headers are
set up right now.


thanks,
-- 
John Hubbard
NVIDIA