Received-SPF: pass (google.com: domain of linux-kernel+bounces-215423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 14 Jun 2024 13:48:04 -0500
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Aditya Garg <gargaditya08@live.com>
CC: "mcgrof@kernel.org" <mcgrof@kernel.org>, "linux-modules@vger.kernel.org"
	<linux-modules@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: Current status and possible improvements in
 CONFIG_MODULE_FORCE_UNLOAD
Message-ID: <2eybrtgvcbrvd63sckzpsldhnolnqve4v7xyqpfoq2uvvskdcv@rpu7vlrbdclk>
References: <MA0P287MB021781F0CCD7C62CAC608714B8FA2@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset="iso-8859-1"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <MA0P287MB021781F0CCD7C62CAC608714B8FA2@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?ZKtMfWlB1SWc+ZLzhgql1p1oOhq9Ap23yCmlpPL4fFA/593pg/+hf+RGBr?=
 =?iso-8859-1?Q?WSJ1lgc7XE9cYXpX2HlL12buEsZsNhOUdsYBeQnpGxwxSYnJqoKdwsdqkW?=
 =?iso-8859-1?Q?SmBs0c7+YY/FoHljarKKa1/mi712p97EEC/wxGXV9oMjy0ObGzuwUn9mn3?=
 =?iso-8859-1?Q?EvKaOwulKN0jabBnWp7tDppi4BVimojBEcmqBRFOgAZFQGwxrRQgePt5SL?=
 =?iso-8859-1?Q?HMIY5yLqJQI5yyRm+xXE9HeDRn8UQFDNdvtcgcSj5zSv+uuTFh+hi7yIE4?=
 =?iso-8859-1?Q?J9UL1TVZKMJQReg0NYS4qA4gLdn8KBemYDBs03Fh9w3k+tzZxAu2D3ldgO?=
 =?iso-8859-1?Q?O5yoWsUIv6WZtAxT136XDdW4DlGnBOAO0jMyyClBUucfmwYW5jFjoqQVDd?=
 =?iso-8859-1?Q?6FDBRXWmYeJwOmrudmOO7gST8XRHrEL+2HwsYcVTz4RID2iMIlAryrenHA?=
 =?iso-8859-1?Q?42y95zDTn5lcUAqVTBTJf7mga4An6SYOMI9KJNCsKpHF20MUQrRTCF31Hf?=
 =?iso-8859-1?Q?bJ3FKx8sM8yezTE41KlPufOhSYOAV8uHlwnOeT00nWZrd0jUxauAOlpP94?=
 =?iso-8859-1?Q?ukCGwTT9BfssCAUvv/KrJUR4w6+j4CkGRGIgz3K/E9Q1k6x4RsA8IYRejb?=
 =?iso-8859-1?Q?pSi293CNYx3jf3sxYG1LkrEo9ui4kxAjgC54dhQpvWe7uaRfNzJBYRsdG4?=
 =?iso-8859-1?Q?n9/voUzf+rACzHYab6rbFRyiD+oS/vD4qbQBXYqaL9h6W6R0b9KaZmScaJ?=
 =?iso-8859-1?Q?jZG+x3ZtqA08p9/fA+2Xgt90bROJPo7GuqT1UrI7bzK/yDzhXDD1nqdF91?=
 =?iso-8859-1?Q?h2C2YJpkrn5wXIC2QYeEJktIPTw43A4Fy/u5m0mW3dgUBgU/XYGMBKmw02?=
 =?iso-8859-1?Q?dY+JEMYCK48BDBaMYiZGYv+FUVfbtlUU+pufutTPOPC/Zb7U4mvJWm/mLG?=
 =?iso-8859-1?Q?CLX/JSLOpKEq+JQduFR9NfQxac++mDFK5pCrbZalT6ulrtjaC5cdWPK9Rx?=
 =?iso-8859-1?Q?RwQVa5AmqkvPKP2cdAlvIdiCKkeMxCKsxmUTR4y2NzLF4RebhWo43U0idU?=
 =?iso-8859-1?Q?udTax/ex6MIGZQfxWVGN988ey3q+T4KC1rsWghSLYGiSrT8A4FkQjx02rJ?=
 =?iso-8859-1?Q?CUPoLb+K6z47VSdvGXMvAA8MYG2O6I9nrEfeE/lRjzLG5gUGDVwYWRFG1Q?=
 =?iso-8859-1?Q?SScSLZUvNmFRjucae/l7ZEaEoBKpVqah/sXXNkI3VwPJ0yUJQRvm4ITaMp?=
 =?iso-8859-1?Q?VOAcvOqbT5IKcUyo1nqCmZRzOa6sG1OMuIrAy7u4+r4+ymc/c6QO8b6Y2F?=
 =?iso-8859-1?Q?toHpxB6K+pXMwDC03dXyvB1YtZ17j7OnQh7LV5/CqMc+oGIDua5TP0iUn0?=
 =?iso-8859-1?Q?7UYJMPovXfE7O06j1vC1KUbHBOqYS4bI5FcEMQBOz0TLafvGsEcekN+RNg?=
 =?iso-8859-1?Q?o5RKD/R4zNWz2XKG6C919M++4HqIfPFiVdhYWxZmO47p93vb+L70VM17OW?=
 =?iso-8859-1?Q?0DntdM7O7dImJ8Ac0jXGi8artevmb8t0zH0h67+1q3roG9fLMX3/FHvmlE?=
 =?iso-8859-1?Q?pmUmjqL54M8rEtdJ7rtM8kXVI6W1jpTyiwKvbWd0r2LE7N+V5U4IxOy4bn?=
 =?iso-8859-1?Q?UUZVmiYI81Vm3O34Ac5tsHnFt/yCuB2wfipECUSy7+MSk3AEwuCF6U1g?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ef0dbdd-3410-43d2-e0c4-08dc8ca289a3
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 18:48:10.3514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EwirsxRLzeWCOhJsFBEPOb4S/8T73XkqYGLWQw/1MDiLhw+8vk1IMHKMLwZwDJInZOGwzmpgDZKvs0VHuDOxiRAsLWGHTAXL81gsrsrGr88=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6552
X-OriginatorOrg: intel.com

On Thu, Jun 06, 2024 at 06:49:59AM GMT, Aditya Garg wrote:
>Hi
>
>I am Aditya Garg. I often require using out of tree drivers to support various hardwares on Linux. Sometimes the provider doesn't write good drivers, and often they have to be force unloaded. It's a common thing in proprietary drivers. I know the author of the driver should take note of the issues, but still the force unloading of the modules does come in handy many times.
>
>Unfortunately if CONFIG_MODULE_FORCE_UNLOAD is not enabled in your kernel, which most probably is not enabled if you are using a Distribution pre compiled kernel, you have to recompile the whole kernel again.

CONFIG_MODULE_FORCE_UNLOAD only ever makes sense on a developer
environment loading/unloading multiple times his own .ko module. Then
the developer knows better the state of the driver and hw to judge if
it's safe to ignore krefs.

>
>I want wondering if instead of a kernel config option, we could use a kernel parameter to enable/disable this feature, I believe it should act as a better alternative. After all there must be people like me who are forced to recompile the whole linux kernel just for the sake of getting a functionality.

Just allowing it like this is not a good thing. You may have a all kind
of issues with use after free, dangling pointers etc.  That would just
make life harder for people not involved with proprietary modules.


>I hope for a reply and suggestions

I?d ask them to upstream their driver and start sending the issues to
their side.

Lucas De Marchi

>
>Regards
>Aditya