Received-SPF: pass (google.com: domain of linux-kernel+bounces-215449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <964821b3-dcbb-42b8-9062-2366a4d30a76@baylibre.com>
Date: Fri, 14 Jun 2024 15:18:12 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iio: adc: adi-axi-adc: improve probe() error messaging
To: =?UTF-8?Q?Nuno_S=C3=A1?= <noname.nuno@gmail.com>,
 Lars-Peter Clausen <lars@metafoo.de>,
 Michael Hennerich <Michael.Hennerich@analog.com>,
 Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240613163407.2147884-1-tgamblin@baylibre.com>
 <57d4659a5abb63d7c085865059b9d71c40371edd.camel@gmail.com>
Content-Language: en-US
From: Trevor Gamblin <tgamblin@baylibre.com>
In-Reply-To: <57d4659a5abb63d7c085865059b9d71c40371edd.camel@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2024-06-14 5:11 a.m., Nuno Sá wrote:
> On Thu, 2024-06-13 at 12:34 -0400, Trevor Gamblin wrote:
>> The current error handling for calls such as devm_clk_get_enabled() in
>> the adi-axi-adc probe() function means that, if a property such as
>> 'clocks' (for example) is not present in the devicetree when booting a
>> kernel with the driver enabled, the resulting error message will be
>> vague, e.g.:
>>
>>> adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with error -2
>> Change the devm_clk_get_enabled(), devm_regmap_init_mmio(), and
>> devm_iio_backend_register() checks to use dev_err_probe() with some
>> context for easier debugging.
>>
>> After the fix:
>>
>>> adi_axi_adc 44a00000.backend: error -ENOENT: failed to get clock
>>> adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with error -2
>> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
>> ---
> Somehow feel that in these cases the error log should come from the functions we're
> calling but bah... likely not going happen/change:
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> (As a suggestion, you may do similar work in the axi-dac driver)

Thanks. I'll send that early next week after a quick test on a board.

Trevor

>
> - Nuno Sá
>
>