Received-SPF: pass (google.com: domain of linux-kernel+bounces-215447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 14 Jun 2024 16:09:46 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Matthias Schwarzott <zzam@gentoo.org>
Cc: dwarves@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bpf@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>,
	Jiri Olsa <jolsa@kernel.org>, Jan Engelhardt <jengelh@inai.de>,
	Viktor Malik <vmalik@redhat.com>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Jan Alexander Steffens <heftig@archlinux.org>,
	Domenico Andreoli <cavok@debian.org>,
	Dominique Leuenberger <dimstar@opensuse.org>,
	Daniel Xu <dxu@dxuuu.xyz>, Yonghong Song <yonghong.song@linux.dev>
Subject: Re: ANNOUNCE: pahole v1.27 (reproducible builds, BTF kfuncs)
Message-ID: <ZmyVehvNnhrMerlv@x1>
References: <ZmjBHWw-Q5hKBiwA@x1>
 <4154d202-5c72-493e-bf3f-bce882a296c6@gentoo.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4154d202-5c72-493e-bf3f-bce882a296c6@gentoo.org>

On Wed, Jun 12, 2024 at 12:07:09PM +0200, Matthias Schwarzott wrote:
> Am 11.06.24 um 23:26 schrieb Arnaldo Carvalho de Melo:
> > Hi,
> > 	The v1.27 release of pahole and its friends is out, supporting
> > parallel reproducible builds and encoding kernel kfuncs in BTF, allowing
> > tools such as bpftrace to enumerate the available kfuncs and obtain its
> > function signatures and return types.
> > 
> 
> Regarding packaging of pahole:
> What is the state of the contained ostra-cg?

I need to make a decision on that, it is used to produce things like:

http://vger.kernel.org/~acme/ostra/callgraphs/sock/0xf61bf500/

As documented in:

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/README.ctracer

But yes, it needs to get retested after all these years to see how
difficult it would be to try and get it back working.

- Arnaldo

> I have no clue what it is and how to use it. Is there still a use-case for
> it?
> 
> Starting it without arguments only shows the usage string.
> Running it with two dummy arguments:
> $ ostra-cg x y
> Traceback (most recent call last):
>   File "/usr/bin/ostra-cg", line 404, in <module>
>     class_def = ostra.class_definition(class_def_file = "%s.fields" %
> traced_class,
> 
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/usr/share/dwarves/runtime/python/ostra.py", line 154, in __init__
>     f = file(class_def_file)
>         ^^^^
> NameError: name 'file' is not defined. Did you mean: 'field'?
> 
> According to
> https://stackoverflow.com/questions/32131230/python-file-function the
> function file() does not exist in python3.
> 
> This part could be fixed by replacing it with open() but I wonder if this is
> worth it.
> 
> As nobody has complained about it being broken:
> Should ostra just be removed?
> 
> Regards
> Matthias