Received-SPF: pass (google.com: domain of linux-kernel+bounces-215504-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 14 Jun 2024 17:47:36 -0400
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	tony.luck@intel.com, x86@kernel.org, avadhut.naik@amd.com,
	john.allen@amd.com
Subject: Re: [PATCH 3/3] x86/mce: Use mce_prep_record() helpers for
 apei_smca_report_x86_error()
Message-ID: <20240614214736.GA726880@yaz-khff2.amd.com>
References: <20240521125434.1555845-1-yazen.ghannam@amd.com>
 <20240521125434.1555845-4-yazen.ghannam@amd.com>
 <20240529172809.GJZldlqSr5km0frQ_o@fat_crate.local>
 <6d508036-befd-4d5c-b02e-abb228ed9144@amd.com>
 <20240603165530.GFZl31gtuABwpe1svP@fat_crate.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240603165530.GFZl31gtuABwpe1svP@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jqpYWAkUmccsoQNLPcPfLcL1+is95sUpwqfB8n2vraFDSiXB++h4N2UlkMoV?=
 =?us-ascii?Q?AcHeYIUCoO/JCVN8tzOdB1kJbSKHWSAFZVXMlTpkv0Z3cdltDLNz3jeIUHVi?=
 =?us-ascii?Q?Te+Xzb+pC4ALuJGuqy2f/rUjOWj2rbqVduDZj9kRsP3pi/yD8wlU9gsXWpn0?=
 =?us-ascii?Q?6CYu2pdarMBKpJgt3RXlr99g7lbN5Ys31HdLACMtckdMXB38SZzmKKA3XScq?=
 =?us-ascii?Q?Sk+UUDD2KuQqN3O4K5NQTJfWxFaiu1Wxj8jpu2IRgjhDxgEQ4jLwcefKkF4D?=
 =?us-ascii?Q?3BhG7ik4Hlb+WVEG2szyMuIxAt7g6IVuV1c4MOy8lAHxf/y6Cs9Z2tUFF6bs?=
 =?us-ascii?Q?sfikne8+gSeTn6pvKVkTdiGUPH7TdRgCTy7rJt44hwMclHEERs6nTQpH0Vaa?=
 =?us-ascii?Q?JZv2QuMbUj5zbMDzt3VgkTyrsP3gvwR1/527z8cBux18UxM/gys7EfPKXCeN?=
 =?us-ascii?Q?PrlB0uvT85J+2d+ohY4eIHDIyoAoFcBXI/W6fDSirwAaeJi3x7B2nbv9c/tx?=
 =?us-ascii?Q?kenMIMWvWgzs19LW6ngvPDEgP7l82y251uzXs3rEssDK2S+kUmJCYCyV3LLU?=
 =?us-ascii?Q?t2h39KUYE+3tfmmdJiMj1LhXd3es4BA/ebslh7Oq+QpD6ZRuZxK3nIIf20vn?=
 =?us-ascii?Q?8/MND8ElXB0W3fghR435idlLX80x9o9o1FwQSKJmUjq0MlBjif9yKf/7Ivam?=
 =?us-ascii?Q?+VgP5WlO0FpgWzDEHCC6kKJgvIlqp0ELOQxpTltNGE6O3w0QcwLKhd51hzyd?=
 =?us-ascii?Q?utgGniwJThzWUKVVa4mUOVcS5xXuumoYnfuEjtG/2Y7TJGMGjsOect/7jgs8?=
 =?us-ascii?Q?xXMEr18OUMUgqhkpUUkn6fybeoV8Sh5REuU+Fp4GRfoTqCuWDM/MDT83wWls?=
 =?us-ascii?Q?aojqEK1tpNhOvui0nJ88Rq93MdiJpokNaAT/41rEGZrV3mHtwgbUYf1wAOLH?=
 =?us-ascii?Q?wxRuU1zqowiYA+x6ERT2QhDFJ0YX0UCZESZQkpoTMyW96mQfgp+wNoRKOPvu?=
 =?us-ascii?Q?grOAF5eycXZG3AbCe3pKK4BUWN4+CjlEFCqKospAsNpF2LDLbb7fITpTg2kx?=
 =?us-ascii?Q?DLR+JkGH7vwrfWpZp8bKF7Y4Pg6BaJ7ByuYAWcGdsWAkNxp2w/yQWQt4ubyv?=
 =?us-ascii?Q?DRxzo1mwDCTc7lM3+Z38wZpADIl2JuNAyZRVqc3GR37WXNcHCx9mxGMtL1se?=
 =?us-ascii?Q?lMmqOUiJxKW0xY/Oijx1e3Pvav/xxmJ4x86jKIKJ6ADD6YLX4pv3/8C3Ww6l?=
 =?us-ascii?Q?aA6QumSvd0o9XixH5kR+2/x/mODQb0/0CYt9l3kvtzhsO4ujBhgTobXjKHop?=
 =?us-ascii?Q?E4hDGTADMQ+nTL0U2LEkYwlzdfiXmzDlH140I4jRKU7PkfvL7e9gOZEx4Hnh?=
 =?us-ascii?Q?Bl8v38OkuB7C9CHuIylhMnAhEaKi0xPwY1z84UDQRMuDTzA0znMzf5gBs4DM?=
 =?us-ascii?Q?QBm1NkqxCo5gbzJSE5IaDfZjglxdyBtl8DkYjf2Sg7yWHpetfA3BIvV+NzcG?=
 =?us-ascii?Q?JXc7zr/geohAIDdd2twSx5f+60H7+XcNEHaWvGj95vbC/I/wRiYGavynBf94?=
 =?us-ascii?Q?/qFScrS+2gJPOfcu5DQ4zM1rzS1nlLOXx36oXIq4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24df80a5-aa10-485e-565c-08dc8cbba139
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 21:47:47.4217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cxRCkN3gHkJn+Hj5LPUK5QV/KRefQmh68M11nL9cXlzQeHlG+wYURm5sjc6xqd8AeJ1v49sVnZSE8VOWCOiPTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8743

On Mon, Jun 03, 2024 at 06:55:30PM +0200, Borislav Petkov wrote:
> On Mon, Jun 03, 2024 at 10:34:10AM -0400, Yazen Ghannam wrote:

[...]

> > This is to catch the case where there was no break from the loop.
> 
> If the CPU is possible != whether there was a apicid match.
> 
> Here's how you do that and I'd let you figure out why yours doesn't
> always work:
>

I don't see why it won't work. If there is no break, then the iterator
ends by setting the variable past the last valid value.

For example, I ran this on a system with 512 CPUs:

        unsigned int cpu;

	/* Loops over CPUs 0-511. */
        for_each_possible_cpu(cpu)
                pr_info("loop: cpu=%d\n", cpu);

	/* CPU is now set to 512. */
        pr_info("final: cpu=%d\n", cpu);

	/* CPU 512 is not possible. */
        pr_info("CPU %d is %s possible\n", cpu, cpu_possible(cpu) ? "" : "not");

But...I like your suggestion as it is much more explicit. And I might be
missing something. :/

> diff --git a/arch/x86/kernel/cpu/mce/apei.c b/arch/x86/kernel/cpu/mce/apei.c
> index 0cbadfaf2400..3885fe05f01e 100644
> --- a/arch/x86/kernel/cpu/mce/apei.c
> +++ b/arch/x86/kernel/cpu/mce/apei.c
> @@ -66,6 +66,7 @@ EXPORT_SYMBOL_GPL(apei_mce_report_mem_error);
>  int apei_smca_report_x86_error(struct cper_ia_proc_ctx *ctx_info, u64 lapic_id)
>  {
>  	const u64 *i_mce = ((const u64 *) (ctx_info + 1));
> +	bool apicid_found = false;
>  	unsigned int cpu;
>  	struct mce m;
>  
> @@ -98,11 +99,13 @@ int apei_smca_report_x86_error(struct cper_ia_proc_ctx *ctx_info, u64 lapic_id)
>  		return -EINVAL;
>  
>  	for_each_possible_cpu(cpu) {
> -		if (cpu_data(cpu).topo.initial_apicid == lapic_id)
> +		if (cpu_data(cpu).topo.initial_apicid == lapic_id) {
> +			apicid_found = true;
>  			break;
> +		}
>  	}
>  
> -	if (!cpu_possible(cpu))
> +	if (!apicid_found)
>  		return -EINVAL;
>  
>  	mce_prep_record_common(&m);
> 
>

Would you like me to send another revision with this change? Do you have
any other comments?

Thanks,
Yazen