Received-SPF: pass (google.com: domain of linux-kernel+bounces-215515-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 14 Jun 2024 16:15:17 -0600
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
 imx@lists.linux.dev, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
 Laurentiu Tudor <laurentiu.tudor@nxp.com>, 
 Stuart Yoder <stuyoder@gmail.com>, Conor Dooley <conor+dt@kernel.org>
In-Reply-To: <20240614213109.2518797-1-Frank.Li@nxp.com>
References: <20240614213109.2518797-1-Frank.Li@nxp.com>
Message-Id: <171840331790.1657462.8424849531522839529.robh@kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: misc: fsl,qoriq-mc: convert to yaml
 format


On Fri, 14 Jun 2024 17:31:03 -0400, Frank Li wrote:
> Convert fsl,qoriq-mc from txt to yaml format.
> 
> Addition changes:
> - Child node name allow 'ethernet'.
> - Use 32bit address in example.
> - Fixed missed ';' in example.
> - Allow dma-coherent.
> - Remove smmu, its part in example.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/misc/fsl,qoriq-mc.txt | 196 ------------------
>  .../bindings/misc/fsl,qoriq-mc.yaml           | 187 +++++++++++++++++
>  2 files changed, 187 insertions(+), 196 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt
>  create mode 100644 Documentation/devicetree/bindings/misc/fsl,qoriq-mc.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/fsl,qoriq-mc.example.dtb: dpmac@1: $nodename:0: 'dpmac@1' does not match '^ethernet(@.*)?$'
	from schema $id: http://devicetree.org/schemas/net/fsl,qoriq-mc-dpmac.yaml#

doc reference errors (make refcheckdocs):
Warning: Documentation/networking/device_drivers/ethernet/freescale/dpaa2/overview.rst references a file that doesn't exist: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt*
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt
Documentation/networking/device_drivers/ethernet/freescale/dpaa2/overview.rst: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt*
MAINTAINERS: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240614213109.2518797-1-Frank.Li@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.