Received-SPF: pass (google.com: domain of linux-kernel+bounces-215602-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Gulam Mohamed <gulam.mohamed@oracle.com>
To: "hch@lst.de" <hch@lst.de>
CC: kernel test robot <oliver.sang@intel.com>,
        "oe-lkp@lists.linux.dev"
	<oe-lkp@lists.linux.dev>,
        "lkp@intel.com" <lkp@intel.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "ltp@lists.linux.it" <ltp@lists.linux.it>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "yukuai1@huaweicloud.com"
	<yukuai1@huaweicloud.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>
Subject: RE: [PATCH V4 for-6.10/block] loop: Fix a race between loop detach
 and loop open
Thread-Topic: [PATCH V4 for-6.10/block] loop: Fix a race between loop detach
 and loop open
Thread-Index: AQHavA/KpPG1Y2G/i0Skj77IBfr3QrHGM6eQgACQXwCAASpzQA==
Date: Fri, 14 Jun 2024 23:35:20 +0000
Message-ID: 
 <IA1PR10MB724052E773F52C756F4F295F98C22@IA1PR10MB7240.namprd10.prod.outlook.com>
References: <20240607190607.17705-1-gulam.mohamed@oracle.com>
 <202406112130.a572f72-oliver.sang@intel.com>
 <IA1PR10MB7240B2686664744DB0D8867F98C12@IA1PR10MB7240.namprd10.prod.outlook.com>
 <20240614054534.GA9969@lst.de>
In-Reply-To: <20240614054534.GA9969@lst.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?+X3vrL16KgCIDARKA9x6yf/dL5+sb7OArgKQOPfKdCiUDZWSK8VHFy39O1H4?=
 =?us-ascii?Q?qRHj3O25C/GMiNBy3zJ+NC85KyasJVbI8t32ko92IesoVacN6eyM1tlheCAQ?=
 =?us-ascii?Q?gms5Gg/WtuiO2cw/zWfUlL1imjdZ++UKcr1DueR4UCTWc5D4XOMBeNflvf88?=
 =?us-ascii?Q?SBNN5DsoNHUONQ8iTX2AO5v8DXRn20WZ1odfivXgEkeRcTiEbTfMMmC0sbJu?=
 =?us-ascii?Q?/a6MIhgWOuzMk1fu/VwTaheoHphdzjyOGS5gQ2bo+MuWUrgyqlY2Af4HOG3W?=
 =?us-ascii?Q?qteQeWNO1lhBT2MyUILsZ7kmain0FA+IQQN6E0wABiY1Nn182Aqmq46F1yZ7?=
 =?us-ascii?Q?Ihm8CQGBu0wXSdclddKNgf4H76cpIoZG9l1eSySNeFCLNe1lvXbbRaI/vz7d?=
 =?us-ascii?Q?HgKYYQ8hsZ+VefEP3SQwZVrvvCJ5rX7I5O1g+ltCN3cwqjlLAN7Z7gGOwT86?=
 =?us-ascii?Q?eO83FD/Udps1Qo4JgD4K6xs08HzqMIc8mGPb1rkiNXzVIwm5VgfpN9FJguh5?=
 =?us-ascii?Q?NS87JsW1aJ3gAzrz/MrRDWWvpAMNfh7+hIyAbKI4JC/ptOwVXy532sKBXNj9?=
 =?us-ascii?Q?7jg2oggajgcASH7R443Lgp1+NngtbvkIxwKjmHiJgxxdCGzhqg8k+WcNEHgN?=
 =?us-ascii?Q?bpGa6bnGwF5mr1oRtSty1UQIuNlXfPhrUWXHhwyELOpVXjlst8NnklU6HzIM?=
 =?us-ascii?Q?NMZ6pfjK8BHYto5Bk1bMM+GpqNFZffpAtg7DJTF+InRGgUcrdkeVcYxfO+bp?=
 =?us-ascii?Q?hBUTDCjo+I2GXVHiV8leub7Ycjq85/FojsNfSbplX2u5q5Tv2fKz/zTL48sP?=
 =?us-ascii?Q?377nop8YULo1JDO52y1heCnzIh2IwGCGDn/c2wbvWs/Pp81VIkWIk5z7uoU8?=
 =?us-ascii?Q?GfPo6LPgl1pLjGCKrnIR615V//AV617qAOJNiWAQxwWuVJEPhOVQ4awsffbF?=
 =?us-ascii?Q?yTQmQtHMBuJatrs0aEajiQNgClBiiEi4eE174csAJK6w0Ax2I8kclOXUTk5T?=
 =?us-ascii?Q?LhSbaPqdhXVQaAIKWgLKQigZLyCkFvTjQbbsyhdsAMmTIHwmgOxJ4g8yAWfZ?=
 =?us-ascii?Q?8XZ+yo/KHtQjptnE2D+FVgT/FU6D9bmmQlX7qa5YwxopkvS9iywurEAj0DyK?=
 =?us-ascii?Q?nprNiTEpEVdnxbhGp90QldDBlxTBqM9i4MxkJ1hDVtdUoctoVyftwsjylpvW?=
 =?us-ascii?Q?73oYzuh9dLhLEvY77CS1ikaCRW3jcC4FY5tfH9Hc1BKEnHPtFgfeIzhrhD2N?=
 =?us-ascii?Q?VuVALm2aBfs4puSotmEH7QYMHmyctJB6XOcQcbHBOv+sl8MttAlcSUfV/b9o?=
 =?us-ascii?Q?RUrTc0G1uHGFfqX5k/RfgLF8T98OOHSP0fRH9/sALRtlZRQgXHdt8XsfjCrf?=
 =?us-ascii?Q?4hGKvBUCD3sqUiZXVeEfasNMBMu9pRyqe6//0hSZmkD0mchUxsaRAiCBWmXX?=
 =?us-ascii?Q?cqq+BCgMjnwWMio4oY3DZBGzCBwsgAzKYR/yqoA40+9WJK+Jcfept/mWvuL+?=
 =?us-ascii?Q?hOZiyuOm3JTPTObsTk5uw6LEInYPM4b6qaG8LiikhzcKBTO1uj8cTkKtIOnp?=
 =?us-ascii?Q?pmvrCub3Iv9xfZ3BiGpsAkf1xWMhWU57IDF2CS0l?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	PSrreaHe0SagImVaDwD5X2I8pL0IuAjg0sn0E7AFe9eS76t2L9juB6SF64tb/TUZm505Hnk5bKfRMP9tu0vggZYNXlZvQzjuQGlefp1MxXIde+XeXVGw016sH8ib6ID4zuzWsxy6peM+NCnr3n6zH6Q+s7FrGZkw5lFBFZNC1vwbsfZwRHvo9nAtUJsfujVv7oS9FnIQ5vED+TeqY66ZR5uMdmb0JmdglR7o0QZncKyQCJ2kAZUIpVm1CdIpIkQDQauz7n6qdVxyCr03k+H1u+XLcMI1Nc2jHZdG7kFLgHbARgr5PGydgPwngxmlxJBuk0zbk9DaBy6nw7b/CJ8J3TMDv5c2K8n7n1IMGEISoYRZnsWyae+yjE+c2nKGZE3V0decfrstp8rU+ZLSWNlwA6nLbjjzEqxCmY35OD8zR0G5jJJ080Ube4QIzsTBCr7PE1BeVyBGq5iahU9HYd3mJ6iPeSmlWcU0yW6qldtPMqQQTdDJaxmOwXsv1h3s9M1+pqqkBOR0GYVvcsLoNgNmb70gY97j84NZDmjFRrhaHzD8VGU6zD89FwZJjdQs5NE3evsEveH/NALqzidQrkw7S/ybTV9JkL3NcoF3ASrpTZs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR10MB7240.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21a49f5c-9a51-4758-3598-08dc8ccaa7bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2024 23:35:20.4762
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Oeg69Nntjyn1Dr5Yhc5WBnOIAGNRUiF5z7HzdVO9y3GrHiajblsw3YTIVIOYuHd5xp7vZbwEC3jIw4yIjvB9BBL+NvWyrw/0cPXckJimm4U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4660
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-14_17,2024-06-14_03,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2406140166
X-Proofpoint-ORIG-GUID: jcBhRzrEpXR3yWUx8Hy5WqnjAXyfLXH0
X-Proofpoint-GUID: jcBhRzrEpXR3yWUx8Hy5WqnjAXyfLXH0

Hi Christoph,

> -----Original Message-----
> From: hch@lst.de <hch@lst.de>
> Sent: Friday, June 14, 2024 11:16 AM
> To: Gulam Mohamed <gulam.mohamed@oracle.com>
> Cc: kernel test robot <oliver.sang@intel.com>; oe-lkp@lists.linux.dev;
> lkp@intel.com; linux-block@vger.kernel.org; ltp@lists.linux.it; linux-
> kernel@vger.kernel.org; yukuai1@huaweicloud.com; hch@lst.de;
> axboe@kernel.dk
> Subject: Re: [PATCH V4 for-6.10/block] loop: Fix a race between loop deta=
ch
> and loop open
>=20
> On Thu, Jun 13, 2024 at 09:10:37PM +0000, Gulam Mohamed wrote:
> > I looked at the LTP test case failure and also the function
> tst_detach_device_by_fd() which failed. Our kernel patch will defer all t=
he
> attempts to detach a loop device to the last close, to fix an issue.
> > The tst_detach_device_by_fd() in LTP test case will open the loop devic=
e
> and repeatedly checks for error code ENXIO. As the new approach, as I
> mentioned above, will defer the detach to last close and the last close
> happens *only* when the LTP test function tst_detach_device_by_fd()
> returns, the test will obviously fail. So, Can you please modify the LTP =
test case
> to accommodate the new behaviour of kernel code for loop detach?
> > Please let us know your comments.
>=20
> I still think simply setting the rundown state is the better approach..

Thanks for the review Christoph. I am sending the V5 as you suggested.

Regards,
Gulam Mohamed.