Received-SPF: pass (google.com: domain of linux-kernel+bounces-215621-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1c702815-3f55-4f62-a743-2463f3141650@mail.de>
Date: Sat, 15 Jun 2024 02:20:43 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add FriendlyElec CM3588 NAS
 board
To: Tim Surber <me@timsurber.de>, Heiko Stuebner <heiko@sntech.de>,
 linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Sebastian Reichel <sebastian.reichel@collabora.com>,
 Jonas Karlman <jonas@kwiboo.se>, Space Meyer <me@the-space.agency>,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240609222428.134977-1-seb-dev@mail.de>
 <20240609222428.134977-3-seb-dev@mail.de>
 <bea6657a-62bb-46a3-93be-4b8b4c68aed0@timsurber.de>
From: Sebastian Kropatsch <seb-dev@mail.de>
In-Reply-To: <bea6657a-62bb-46a3-93be-4b8b4c68aed0@timsurber.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Tim,

Am 14.06.2024 um 04:00 schrieb Tim Surber:
> Hi Sebastian,
> 
> I propose the addition of "pwm-beeper" and "gpio-ir-receiver" to the 
> device tree, since they are permanently mounted on the baseboard.

Can you recommend a good way to test the IR receiver? I tried for
a while with evtest but could not see any output:

    evtest /dev/input/event2
    Input driver version is 1.0.1
    Input device ID: bus 0x19 vendor 0x1 product 0x1 version 0x100
    Input device name: "gpio_ir_recv"
    Supported events:
      Event type 0 (EV_SYN)
      Event type 1 (EV_KEY)
        Event code 152 (KEY_SCREENLOCK)
      Event type 2 (EV_REL)
        Event code 0 (REL_X)
        Event code 1 (REL_Y)
      Event type 4 (EV_MSC)
        Event code 4 (MSC_SCAN)
    Key repeat handling:
      Repeat type 20 (EV_REP)
        Repeat code 0 (REP_DELAY)
          Value    500
        Repeat code 1 (REP_PERIOD)
          Value    125
    Properties:
      Property type 5 (INPUT_PROP_POINTING_STICK)
    Testing ... (interrupt to exit)

I only have one TV remote to test, so I'm not even sure that this
is compatible, I haven't touched anything IR-related before.

Cheers,
Sebastian

> On 10.06.2024 00:20, Sebastian Kropatsch wrote:
>> The CM3588 NAS by FriendlyElec pairs the CM3588 compute module, based on
>> the Rockchip RK3588 SoC, with the CM3588 NAS Kit carrier board.
>> To reflect the hardware setup, add device tree sources for the SoM and
>> the NAS daughter board as separate files.
>>
>> Hardware features:
>>      - Rockchip RK3588 SoC
>>      - 4GB/8GB/16GB LPDDR4x RAM
>>      - 64GB eMMC
>>      - MicroSD card slot
>>      - 1x RTL8125B 2.5G Ethernet
>>      - 4x M.2 M-Key with PCIe 3.0 x1 (via bifurcation) for NVMe SSDs
>>      - 2x USB 3.0 (USB 3.1 Gen1) Type-A, 1x USB 2.0 Type-A
>>      - 1x USB 3.0 Type-C with DP AltMode support
>>      - 2x HDMI 2.1 out, 1x HDMI in
>>      - MIPI-CSI Connector, MIPI-DSI Connector
>>      - 40-pin GPIO header
>>      - 4 buttons: power, reset, recovery, MASK, user button
>>      - 3.5mm Headphone out, 2.0mm PH-2A Mic in
>>      - 5V Fan connector, PWM buzzer, IR receiver, RTC battery connector
>>
>> PCIe bifurcation is used to handle all four M.2 sockets at PCIe 3.0 x1
>> speed. Data lane mapping in the DT is done like described in commit
>> f8020dfb311d ("phy: rockchip-snps-pcie3: fix bifurcation on rk3588").
>>
>> This device tree includes support for eMMC, SD card, ethernet, all USB2
>> and USB3 ports, all four M.2 slots, GPU, RTC, buzzer, UART debugging as
>> well as the buttons and LEDs.
>> The GPIOs are labeled according to the schematics.
>>
>> Signed-off-by: Sebastian Kropatsch <seb-dev@mail.de>
>> ---
>>   arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>>   .../rk3588-friendlyelec-cm3588-nas.dts        | 759 ++++++++++++++++++
>>   .../rockchip/rk3588-friendlyelec-cm3588.dtsi  | 655 +++++++++++++++
>>   3 files changed, 1415 insertions(+)
>>   create mode 100644 
>> arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
>>   create mode 100644 
>> arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588.dtsi