Received-SPF: pass (google.com: domain of linux-kernel+bounces-215626-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 14 Jun 2024 18:07:14 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Kamil =?UTF-8?B?SG9yw6Fr?= - 2N <kamilh@axis.com>
Cc: <florian.fainelli@broadcom.com>,
 <bcm-kernel-feedback-list@broadcom.com>, <andrew@lunn.ch>,
 <hkallweit1@gmail.com>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 0/4] net: phy: bcm5481x: add support for BroadR-Reach
 mode
Message-ID: <20240614180714.7f81a9cd@kernel.org>
In-Reply-To: <20240613132055.49207-1-kamilh@axis.com>
References: <20240613132055.49207-1-kamilh@axis.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 13 Jun 2024 15:20:51 +0200 Kamil Hor=C3=A1k - 2N wrote:
> Changes in v6:
>   - Moved the brr-mode flag to separate commit as required by the rules f=
or=20
>     DT binding patches
>   - Renamed some functions to make clear they handle LRE-related stuff
>   - Reordered variable definitions to match the coding style requirements

Doesn't build..

drivers/net/phy/phy-core.c:16:2: error: call to '__compiletime_assert_1283'=
 declared with 'error' attribute: Enum ethtool_link_mode_bit_indices and ph=
ylib are out of sync. If a speed or mode has been added please update phy_s=
peed_to_str and the PHY settings array.

   16 |         BUILD_BUG_ON_MSG(__ETHTOOL_LINK_MODE_MASK_NBITS !=3D 102,
      |         ^