Received-SPF: pass (google.com: domain of linux-kernel+bounces-215631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 14 Jun 2024 18:27:31 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: =?UTF-8?B?Q3PDs2vDoXM=?= Bence <csokas.bence@prolan.hu>
Cc: Frank Li <Frank.Li@freescale.com>, "David S. Miller"
 <davem@davemloft.net>, <imx@lists.linux.dev>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, Richard Cochran <richardcochran@gmail.com>,
 Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>, Clark
 Wang <xiaoning.wang@nxp.com>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared
 on link-down
Message-ID: <20240614182731.3244deef@kernel.org>
In-Reply-To: <0f315501-e8cb-4904-8c43-d9721fdef846@prolan.hu>
References: <20240611080405.673431-1-csokas.bence@prolan.hu>
	<20240613081233.6ff570cd@kernel.org>
	<0f315501-e8cb-4904-8c43-d9721fdef846@prolan.hu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 14 Jun 2024 09:59:16 +0200 Cs=C3=B3k=C3=A1s Bence wrote:
> It only writes 0 if WOL is disabled AND the device has the MULTI_QUEUES=20
> quirk. Otherwise, we either write FEC_ECR_RESET, which resets the device=
=20
> (and the HW changes ECNTRL to its reset value), OR we RMW set the WOL=20
> sleep bits. And then, if some more quirks are set, we set ETHEREN.
>=20
> So I think RMW is the safest route here, instead of trying to keep track=
=20
> of all these different branches, re-read ECNTRL after reset etc.

Okay, just resend without the empty line between tags then.