Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1157828lqs; Fri, 14 Jun 2024 18:28:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUXFTBQw4WxvYkRrFFuv+kfRSNuILufcz1myPnw1zpwxJBOsSdgLT2XYCV/q3H3VRXA86POIPFGTzJvbtlfESBxEu4mJ1wrcLshcUHDBQ== X-Google-Smtp-Source: AGHT+IHux0BIxaqAo/te03YnqSexyFd4rYkUFZb1GxAokRqSeEuhl3T6nf+FC4ZvXCsT8IQNXDyr X-Received: by 2002:a50:a456:0:b0:57c:73fc:a8d7 with SMTP id 4fb4d7f45d1cf-57cbd69dd0dmr2543087a12.14.1718414883037; Fri, 14 Jun 2024 18:28:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718414883; cv=pass; d=google.com; s=arc-20160816; b=anDZuotGLUE8dg3m0wEg5cQ5cEWS87NNV83w3khikuJ9duigPSGyj10b377ZRDoQeQ dE2ajPkVcw3k1cSq6Z5u9QIb7HGfw1KcRe18ucDR9FdXXc1l5G8otQwI06sPBkRahyE2 7AhJJKIOxJz5b3tUlh9l9jtP1o6zwe5baOiMC/v3qTf+okF5DPBlbtLv6VJubciSi2BA gfaanx1RpfTWnHwX9/s6rXGrwqYAuo6xOUcYEdGDFqvWxruCO9UEm0w+NVg/VqtEO8zP az2JOggmhkHccur4km9VD0DTlvguM9hUtvNsmylUSZEWz+VhiMI9458fhL3F3nHTvmNg TfxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=IObPrJ94tAI7XxmQ3jJQOyeLKVgAAAIM25MkSPZRZDM=; fh=mqQxBtrTGnbexyUdd8VGtG++Yv305Sgy2/WADWRoxLI=; b=f84+iU3w0wpaXtZNbKSbbxT68hoUCa3rBvIboiLHozuqsrtWgCmiXNjcYgjAi9x5La AfA0MuZati2XSoyND0h2DakdUeCksKK8/h6TcrW5zK9EBRxUU1tOogHsKwaQDsJxrXNk 4aVp1649RRMNNfqz5uq7ZzCTZk3Ybs6GBOVB0HRxiG7abVNyRlXBMcxDdtdPIPQvseU3 u+/Xmdf1l3O0qB+M+90Tgj5viSAi2AmGPgkL/bLTgu2Qo0ESecCY+PpJuaTuv8yVphfj ao58Ai+KZLE5nheHFTiLm03wyQaDaI1Tl2q+DRfKkL7X6gaGFJ/6UAADz++warwmGxL6 2tbw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=gpBsYYuM; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-215628-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215628-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57cb74477a5si2331641a12.476.2024.06.14.18.28.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 18:28:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215628-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=gpBsYYuM; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-215628-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215628-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 256E01F2310F for ; Sat, 15 Jun 2024 01:19:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1B71F442C; Sat, 15 Jun 2024 01:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gpBsYYuM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466101FB4 for ; Sat, 15 Jun 2024 01:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718414392; cv=none; b=fB1IaGpN+D/oWnloqwSMpm2CgsolAXbaEZz6aox4kU/kOLNM+RU3S5diUgeoKdaKAqIfBt1yPTf9BBt2DTfw1/+T3sYxL8phAQRcQ7UXkPvemi/25n3FSz5lCJKW6mY9enOYZaP5wwHDMakqHmAEc8cmWYUnpvTlr3wXEJLv6a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718414392; c=relaxed/simple; bh=ilNXTmA99Z0S3RmVkDwTAq3gTOlyn5NNkcxVzym5pxo=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ZCo20tLqADswUw7q6gXoTHUE0Nsn3IiJWpjG8h29i9iD/r/iGm0uq3Ug3Tyb7KpSE1OGnMzdyYQdxd4C+x+OJXu9ndPHbG40xDs/T65V04CuXmZ1QkWZ1zBday18DJ69US+tU5hPgI7g90JrQlQd7mmhjvKzAFf3buxIw+FCmQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=gpBsYYuM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A5BDC2BD10; Sat, 15 Jun 2024 01:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718414391; bh=ilNXTmA99Z0S3RmVkDwTAq3gTOlyn5NNkcxVzym5pxo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gpBsYYuMFqpgRL4nip0qVXAWMcvM2hVCCIGgF6FeqesFYqYu5gsDug5FV8kGGtYUk XI1XdXs8YSQsZSQuZoXLqMEUec/2i2AiLk73P8KOq/azYdsqJm0yakL/8FY6VhU3iJ blbPXAXB9IxUFxyND049OFuSImTIHfDwAZNVln+w= Date: Fri, 14 Jun 2024 18:19:50 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm: handle profiling for fake memory allocations during compaction Message-Id: <20240614181950.d5cd06acba24339401c98d6d@linux-foundation.org> In-Reply-To: <20240614230504.3849136-1-surenb@google.com> References: <20240614230504.3849136-1-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Jun 2024 16:05:04 -0700 Suren Baghdasaryan wrote: > During compaction isolated free pages are marked allocated so that they > can be split and/or freed. For that, post_alloc_hook() is used inside > split_map_pages() and release_free_list(). split_map_pages() marks free > pages allocated, splits the pages and then lets alloc_contig_range_noprof() > free those pages. release_free_list() marks free pages and immediately > frees them. This usage of post_alloc_hook() affect memory allocation > profiling because these functions might not be called from an instrumented > allocator, therefore current->alloc_tag is NULL and when debugging is > enabled (CONFIG_MEM_ALLOC_PROFILING_DEBUG=y) that causes warnings. It would be helpful to quote the warnings for the changelog. And a Reported-by:/Closes: if appropriate. I'm assuming we want this in 6.10-rcX? Please help in identifying the Fixes:, for anyone who might be backporting allocation profiling.