Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1160716lqs; Fri, 14 Jun 2024 18:38:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU8yLLuboISJCztlvsioW9JTso8Orm5S7HGPp7AtD2c2YiAwo7gA7EpsrqeSbdHMiAlIzjJtZ3qWuypo/pWQoNRm+ZWXQXuJH+vvPfNdw== X-Google-Smtp-Source: AGHT+IE7XhZeihYF3ROQEmOs2A5s6X6CoBATG6IlP/V72KqCQtQc16dFlLxj1cWq0kQ6uBBUClXk X-Received: by 2002:a05:620a:460e:b0:795:478d:12d4 with SMTP id af79cd13be357-798d241a2a7mr446054885a.21.1718415522525; Fri, 14 Jun 2024 18:38:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718415522; cv=pass; d=google.com; s=arc-20160816; b=DmGf4hSStzrzuCq78NnfP96GcrhiofCitQNLmhBOLHbDsDItJxZuzhg0GkNDABt3ky AOwTfzpJmsPIhYVML/1FNofsRKmgcnOSoAgp0QcOLF/nfsJea2O4BrVyBpwRyca5izp9 0m6lFSYX6c6svWOnGGbuvjtjpTpaoKUEMssdg++/Inp4IDf9Em0i7ULYXzBC/m34SA84 blFo9+p0bqCx8QkeOM9FsMyPbV5L5qltjB8i+VQxRdL3122C8ysuvC1gfw6k5KnNv1Vu ygk6vwBm2eUkGqaHZBmos6hBgPeGOuJWRGtOAp9bAmMgo7TLCXwkDnXuTUb1dMl/2ntB 52pQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=xJhJt3J2nxJAuqKZHd0QwEciJsDRhZULynwju7SQhhA=; fh=mb6Yz25mSnBkxdDiyhQ2KKP2ZnVlxhqCBdECdAB/rMI=; b=R5ItonfnObzLSYKmtbkujn28IyxfPbtbPsfrqALY224ke0vmsp1WRFb/tmsiiVu0kA D74CLJVRbSX0YCznzR1j1FxUx7LyxPVN3iooBEwiagWub2auimr9zXvOZRUJzA+nEUCC I9Hb0EG5O12gX9xeR0ZRuVT22XsXfTbOzGsaTgJ7VBHLn11F/QihqxjYcdq5f7XyFcKD Td0vWVbxhrNniNtHeF5F/F1yK1r3btFeepDQFudl8DFINTQV2KLwD6BUq938L3KQSiOA YtBrMdTJ0KqL8h1i11Vft3Vwoa/Z2HUsBCk5/qFzBe+yMaNaoFMZ6RFHi0irxyyJ73Ia s9xw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ndufresne-ca.20230601.gappssmtp.com header.s=20230601 header.b=kSPcQwB5; arc=pass (i=1 dkim=pass dkdomain=ndufresne-ca.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-215480-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215480-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-798abe598b7si545629485a.632.2024.06.14.18.38.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 18:38:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215480-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@ndufresne-ca.20230601.gappssmtp.com header.s=20230601 header.b=kSPcQwB5; arc=pass (i=1 dkim=pass dkdomain=ndufresne-ca.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-215480-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215480-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3CCC81C22CD3 for ; Fri, 14 Jun 2024 20:30:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3FB0D1AB51B; Fri, 14 Jun 2024 20:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b="kSPcQwB5" Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5651A3BA4 for ; Fri, 14 Jun 2024 20:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718397009; cv=none; b=Xz/SpvjeEKefS6kbNHlDFp5P9ZbvvIeglvf2690EeCRJmZo2cR+BzXMZ/RxUNsMeqIsqqoKvE/S4DlgpgLTAbyvWtjEHztbt/3jb7zRw5gV2Ky8n5XkOPrDoyyDQtBW+wTZVnEqjtTiGqm6PObJW8qgnkUZAk/mQzzMceYg20xQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718397009; c=relaxed/simple; bh=oCiYWKj7fKvXvA09gRXC6Z0ywvUJA/RbhazDFE/5KmM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eNHUvzKlaDFUZV+L0uhWi712wnhg0eM5EOc2GeNAqytgJMSs6TJulYHQg6WHOFOKH2m1zbZgenhNZ+2DAn2xaFOjrQzQFC1fzOSVOMCpq1ahhLgrxKaFv2H0AqPx7036JUgsPcQlx4B8H/+QjGxxoIQkORSGEqnt3QL1Racaq7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ndufresne.ca; spf=none smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b=kSPcQwB5; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ndufresne.ca Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5bacd59e562so1269551eaf.2 for ; Fri, 14 Jun 2024 13:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1718397007; x=1719001807; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xJhJt3J2nxJAuqKZHd0QwEciJsDRhZULynwju7SQhhA=; b=kSPcQwB5kX7mCbmRdxmeIrnwoAahgjP0MsM1DqoXov/MfRJMik0kqSwSKYBCRtsTRs a+YNHQbwTOT+Pw1Hg4FIob860fqyEHva/LTPVJWESwQ6jn5QUIimmHQ9dKzqKiD/4wEm Bo+CQPhLpatLTQQkxHwRtP7XSBmSggGmRD32tpd8+cJ2UjQ4kCu1tCi8a3QwlykSLPGy ZDId1bFhvTMAi6Wg48hvjswrpH9cH8mHnL52c1wN8QRhrAIW9JhhG90QEcHHy1kwhGpY s6aW6Fav/YKMdgo7lIu/0uBkkY1/LIr5nBPsBR1nZv3EDStu5dhOwoNTXCDQpfLKJe0b 14lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718397007; x=1719001807; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xJhJt3J2nxJAuqKZHd0QwEciJsDRhZULynwju7SQhhA=; b=oMmRSviRG9n4TPvXw0/e0cVd9CELJPwnNyRJ9RjvVbXcfVnYInbXR0Llc1jSDnUn2A kIBQmr5bd+k+1Rq1z8+AhsQSt/GC2XveNV7PgSL3COlrEh5b0pk3BMbSMo3BuIDdjkwz qwAwjUKTp9Y93t1jEA5GzawWdaOAnQrALA13BQFxJdSTO+2S1Ulfi3hsCKQfSZU8Esey /RmHGxMiUzT6W09C7jI4jUX+zPqzmMtqDw4OwWd1MFMiFmQll8q2SS58a4nuXwaoZRlY RYSvGs/Wo7XCtVQVeOfO2YOI3o6bmCTfvX0t291nUVpiKmOoNZsELbpw+D86/4ivdtpx +JIA== X-Forwarded-Encrypted: i=1; AJvYcCXFC1BV5VU1xO5PPGZ7CbiUX3eIr5Qb2XRL4AuRShQt+gRPlW9EoLyOeHVZyBOw98F/th8MfyOddudcdivi94G0/fvF5WFY3PEvL0NV X-Gm-Message-State: AOJu0YzQG2HGK+tQRXs99/QrgI9SNh0/k2JfWVu53v5LXsvsKMW/LGhv u9GXuUXwSHdghEz8j1o3su29pg38oj1YdD8ptJ3yCuDPc8x4AE7M59k1D2PCD68= X-Received: by 2002:a05:6358:9103:b0:19f:5317:49a1 with SMTP id e5c5f4694b2df-19fb51658f7mr465229255d.28.1718397007051; Fri, 14 Jun 2024 13:30:07 -0700 (PDT) Received: from nicolas-tpx395.mtl.collabora.ca (mtl.collabora.ca. [66.171.169.34]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5efc23asm22245446d6.126.2024.06.14.13.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 13:30:06 -0700 (PDT) Message-ID: <0faecb255d7e1e67153321d9009f9fc8c0810cd7.camel@ndufresne.ca> Subject: Re: [PATCH 6/9] accel/rocket: Add a new driver for Rockchip's NPU From: Nicolas Dufresne To: Jeffrey Hugo , Tomeu Vizoso , Joerg Roedel , Will Deacon , Robin Murphy , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oded Gabbay , Tomeu Vizoso , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Sumit Semwal , Christian =?ISO-8859-1?Q?K=F6nig?= Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Date: Fri, 14 Jun 2024 16:30:04 -0400 In-Reply-To: <8f93c724-3c86-c0f4-3a84-8a72817e684c@quicinc.com> References: <20240612-6-10-rocket-v1-0-060e48eea250@tomeuvizoso.net> <20240612-6-10-rocket-v1-6-060e48eea250@tomeuvizoso.net> <8f93c724-3c86-c0f4-3a84-8a72817e684c@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, Le vendredi 14 juin 2024 =C3=A0 10:16 -0600, Jeffrey Hugo a =C3=A9crit=C2= =A0: > > + version =3D rocket_read(core, REG_PC_VERSION) + (rocket_read(core, RE= G_PC_VERSION_NUM) & 0xffff); > > + dev_info(rdev->dev, "Rockchip NPU core %d version: %d\n", core->index= , version); >=20 > A properly working driver should be silent by default. This is not universally accepted statement. Most drivers do have a one line "probed/detected" kind of report. Nicolas