Received-SPF: pass (google.com: domain of linux-kernel+bounces-215639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <9f934dc7-bfd6-4f3f-a52c-a33f7a662cae@gmail.com>
Date: Sat, 15 Jun 2024 04:46:11 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next v1] net: wwan: t7xx: Add debug port
To: Vanillan Wang <songjinjian@hotmail.com>
Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
 davem@davemloft.net, johannes@sipsolutions.net, loic.poulain@linaro.org,
 ricardo.martinez@linux.intel.com, m.chetan.kumar@linux.intel.com,
 chandrashekar.devegowda@intel.com, haijun.liu@mediatek.com,
 chiranjeevi.rapolu@linux.intel.com, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, Jinjian Song <jinjian.song@fibocom.com>
References: <MEYP282MB269762C5070B97CD769C8CD5BBC22@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
Content-Language: en-US
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
In-Reply-To: <MEYP282MB269762C5070B97CD769C8CD5BBC22@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 14.06.2024 12:49, Vanillan Wang wrote:
> From: Jinjian Song <jinjian.song@fibocom.com>
> 
> Add support for userspace to switch on the debug port(ADB,MIPC).
>   - ADB port: /dev/ccci_sap_adb
>   - MIPC port: /dev/ttyMIPC0

NAK

The WWAN subsystem was purposely introducted to get rid of this mess of 
char devices and their implementation in drivers. If you want to export 
a port, which type is not available in the WWAN subsystem, then 
introduce a new port to the subsystem and then register it from a driver.

--
Sergey