Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1173247lqs; Fri, 14 Jun 2024 19:27:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXWfD7hFYZkcGbD95iC8D6Ki99fn2xaSyaL7y/DiBiCfr4WigUNbfuLF4lLlkQx/Aa2ry4/LesHG9MjdgaWjbA0f3K6CgvHZsUEUMcmTg== X-Google-Smtp-Source: AGHT+IHSEdW6OS0hK0Cj1+REiev5Jb7EECypqPre1PvmJiDWIKVXVlU9FU0LcaP40HNdwlYjBGdr X-Received: by 2002:a05:622a:2999:b0:443:5470:6f37 with SMTP id d75a77b69052e-44354707f84mr1086391cf.7.1718418453616; Fri, 14 Jun 2024 19:27:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718418453; cv=pass; d=google.com; s=arc-20160816; b=fgU8R7a6T3uTHlhiOx//W4r+qfuLNNC2LaeB+0F153lYG+nt8vWKDj1wilJvtsGsKw rqGfPPkaYQWBHKCd6/RTUAsH1F/IvVhTcYHS1EpI1BP2cE7JXcEedosBtiMDrH2p5sv3 YVtNJPHGn6cYyjPkSi+dpakhsm7Atffsu4b/qEfSmWoNvp4nQ/jeYLU9k6x5a8KdNJAO 7//MhJ3Aj8XYa3jfl6mML3nJ/TBPtsoX3fl2DNmNWJcr+rGpQdEwn9XMB4HT52F8toc0 405HbEvvUzRqIbAatrpYxK0TG5stmGPY44xz+Koyb8OeZgdn6clALD0QVt8UybajSwcn 2HOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=zR/CHZ3tgIs5NmZT7h7xKxwMGmT5J5C4GkKN6LiScvk=; fh=oe/FMrl0ICAWd1HOIBxC59TxmQSuXs8g3jLc/ivpmIQ=; b=uNeqHTCfW70Vkb0pby/vPaRX7eV4kvg/v9rud8/zLgsXHxxqkzIUgelambLq2qk4hd nut5MRcEiQ+KAyVRgJf/TTOMaEU+vjSkYPfELRsg8Bu+nrN0FYbao/rVUS1xAwMFLnjZ hbXHdx6kc+4XbLEzuDLvvQxRNlOgIHySapsQq6uCtlz8aWZAG6aKI0vTk4+m1DtpuCJk OzbY31KMSzzf2W2+jr+cldfOZfYgu0jJk+UUFjSX17lXsGko+/5Zeupp/lo8XQAazpxV wTn1P+9AAmGxFQvFxRfR2z1f5WK3htF2r5SJth7zaXfdZh5z9ymq4B8CcDkjSKV0HH1Z 08jg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R2uKrgsZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-215666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215666-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-44352d5ac08si2960211cf.418.2024.06.14.19.27.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 19:27:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R2uKrgsZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-215666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215666-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 46C2E1C2145A for ; Sat, 15 Jun 2024 02:27:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 74BB2CA6F; Sat, 15 Jun 2024 02:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R2uKrgsZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9952219D8AF; Sat, 15 Jun 2024 02:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718418443; cv=none; b=HAwG5IROobcD6ZvIh+aRaZw7qgxVSiIBA6k9yjqAVCImyZsm43/eTOQfV/aMQD4f9zEhnUvbNpT9e+/J2FEipYexR2qgm8/8bVI3o+9bBoTQhyJKkYrk9FGwDkWOXHbnNkThvvU+G7pvc3bT4uDL07TC3DyfVhvXNbw13lFvyRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718418443; c=relaxed/simple; bh=t8KWBraf+ArgRE1IzbmljHRa8Tm+WCzZh+Q4NDrt4tc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ecGrp5PuVBRa/6XF3EOFRy4+Sz4f3SdHby2l5JdtfkCbUBOcnmMOPNUQqTPac1KyL5h0hf1Ctknh4dRuuuAw5rhwV4xwsOqHr0n+XQfbC4ITWjho8WNytKt9ig7ACE3dmmbyVJ/ISAkfgjseLveyudd4K8VfXcL2IFRy2xx4Myw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R2uKrgsZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94F10C2BD10; Sat, 15 Jun 2024 02:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718418443; bh=t8KWBraf+ArgRE1IzbmljHRa8Tm+WCzZh+Q4NDrt4tc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R2uKrgsZyfkrLppuSWRCNSWlnaR0nryyf+lWWxIToS/Ud/FSrlLNEDC+aj9WWybku jlPIoybPYqcck1AzgN1vNrwvzXYk8+cYU6jF8pWd7/TnHWj4i0jXW48U9PqraQE6fQ jCdvgvZPc3nDol7ha/xZADifkafKfy7PASfA843xJp5Jb7kAua1PyPLIPPmUFJJHUJ KXH7YW3a8hTlBSvK6kEiMnI+6eoRh/EXAfmxN0/lLwN4sCUcCj7fBJ900rgZNRuiXI iJ5zjrFVG3u46ufk1JM4ihbAVf0VLFz82fuAsKxphbGXlGGnTOAN8pc7Bq4H6mvihN WGVJEVBU1f+Qw== Date: Fri, 14 Jun 2024 19:27:21 -0700 From: Jakub Kicinski To: Ziwei Xiao Cc: netdev@vger.kernel.org, jeroendb@google.com, pkaligineedi@google.com, shailend@google.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, willemb@google.com, hramamurthy@google.com, rushilg@google.com, horms@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 5/5] gve: Add flow steering ethtool support Message-ID: <20240614192721.02700256@kernel.org> In-Reply-To: <20240613014744.1370943-6-ziweixiao@google.com> References: <20240613014744.1370943-1-ziweixiao@google.com> <20240613014744.1370943-6-ziweixiao@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 13 Jun 2024 01:47:44 +0000 Ziwei Xiao wrote: > + dev_hold(netdev); > + rtnl_unlock(); If you care about the op being unlocked make the core not take the lock in the first place. The core itself doesn't need it either. Add a flag in the ops to tell the core driver doesn't need the lock. Disappointing :|