Received-SPF: pass (google.com: domain of linux-kernel+bounces-215665-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 14 Jun 2024 19:22:09 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com, pkaligineedi@google.com,
 shailend@google.com, davem@davemloft.net, edumazet@google.com,
 pabeni@redhat.com, willemb@google.com, hramamurthy@google.com,
 rushilg@google.com, horms@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/5] gve: Add flow steering device option
Message-ID: <20240614192209.7c69df0b@kernel.org>
In-Reply-To: <20240613014744.1370943-4-ziweixiao@google.com>
References: <20240613014744.1370943-1-ziweixiao@google.com>
	<20240613014744.1370943-4-ziweixiao@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 13 Jun 2024 01:47:42 +0000 Ziwei Xiao wrote:
> +	if (dev_op_flow_steering &&
> +	    (supported_features_mask & GVE_SUP_FLOW_STEERING_MASK)) {
> +		if (dev_op_flow_steering->max_flow_rules) {
> +			priv->max_flow_rules =
> +				be32_to_cpu(dev_op_flow_steering->max_flow_rules);
> +			dev_info(&priv->pdev->dev,
> +				 "FLOW STEERING device option enabled with max rule limit of %u.\n",
> +				 priv->max_flow_rules);

There's a print to the kernel logs every time driver loads to tell 
the user flow steering is available...

> -	/* DQO supports LRO. */
>  	if (!gve_is_gqi(priv))
> -		priv->dev->hw_features |= NETIF_F_LRO;
> +		priv->dev->hw_features |= NETIF_F_LRO | NETIF_F_NTUPLE;

Yet the uAPI feature which is supposed to let the user know its
supported appears to be set unconditionally.