Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1176736lqs; Fri, 14 Jun 2024 19:42:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVwh5QQOJhQ9n1o58Qz1gZv8rSkruWzsNr4ZYwWTriMUu1nhQVLHDScDQvB+6jgdlXDiJcmxE3eraNY6oqZAINLp2E6Qlr4NZh+5EsS7g== X-Google-Smtp-Source: AGHT+IHGJFYBIWao9d1TD4mdl9fctIkKoDqEt+LdtCl3204/evBCNmAwkPleTmYC2dUVWKSdwJTd X-Received: by 2002:a05:6808:1381:b0:3d2:2230:ecf7 with SMTP id 5614622812f47-3d24e8f2076mr5140801b6e.26.1718419342532; Fri, 14 Jun 2024 19:42:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718419342; cv=pass; d=google.com; s=arc-20160816; b=MLCEMD/gtya2OlIin0+a5eMVzS5bmj1C1dKchKdGAcvzjci4GsE5n5a6XbmOuwIIMC lHjToNihpqFoR77wOjC9JOVmq/G2E3yb3zVdIQUtXhu2Nhp7mUX2emC2G0nt6z12kFPU sXYnZFzHksfY3JpAntXwT1H+/8aQ06NiE15FMqw165nx3+Mzu+d7ROQlKJu23vwhgSkB u/4wO3wcgbC9zJ7l1uErzUbJ7JpSHWgCoNiMry+1Dazq7Db6twgBrDFGubbfmjzt65iP hj1sNrl9GA6/DSoGKmmzmjfA+SYlBhH2TYLK9MSDOAhMhfy8pfxKyDCeTkSKbsMk5tTq sgbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id:dkim-signature; bh=6hAqyrP6UwWj4t+o8mwaPSrgZwEvnY224lZy4GtT7xM=; fh=VhcJnGIGcXYe5/yJ5/dUb+FAPYLpAEegTnVatRCHDpE=; b=I67I5/k5wXxW4k/ptCW350o3uyMT+W6WcBr9+EF3rX3weSjQSkoCnxqgBboYWAYNqR LHdj73uqM/s0eXkkZuRnT0FOJ+Vv6oX4HfggmL7DkLHAkksGlZQ5qMMHproVqmIqy9cM TcOnk5PWn2eFNrUePKDkpx3yUQSeTNEi9Vik4G2+3FYYek3NyD4UGMY8G0coRCgksr+k INspjgsCzBvuaWaSkV5OK9tYbTZ6JPA0G4ZSpdOT/GlQLVXE2XK1yZMbSSETHh8hnI/+ G60boj+rGoB9v4Nx27ilReYXSDgTZt1CiGdsNf5IX35U/kqIIZ+0RHFO5m9KRMuA2bLm 1TDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=qMTmfqny; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-215667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2e1a72fcca58-705ccb3cd73si4591499b3a.155.2024.06.14.19.42.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 19:42:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=qMTmfqny; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-215667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6984228369A for ; Sat, 15 Jun 2024 02:32:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 918918BE8; Sat, 15 Jun 2024 02:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="qMTmfqny" Received: from out203-205-251-53.mail.qq.com (out203-205-251-53.mail.qq.com [203.205.251.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 753AA8825 for ; Sat, 15 Jun 2024 02:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.251.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718418733; cv=none; b=CgFygO4iUrImkBW9cOjDOQiufyQZMBeVipxmrSkptZC/wHD24oFIpPRMgRslggCA90hXXYuWfsJlLXMvygsxwmS5Gf3pPWmSpeuZ+TMnOTLLobNSJv4uAWUf1xgWFFvmh0w2k6Uj5Oe8zHIwg1bhEYkZWPkPpZ/Efo4h91JAdFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718418733; c=relaxed/simple; bh=nbQfgvPdeXIDu8WT65DCVlG5XjQ4nSoRhTiGKfdDpck=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=fOgOKWmbO4pVKI8btx3UEVhaX1yWYI9273LNZmoMsuNLKlvpFH0fIjFx2Rvi2e7SUAjT5Cm91GhKwax6NZ7Y8F7+PNyehnVtbfDV4Viww5FaW/onVjFfbeLcLcOXK2y9oj3b2QV8CfGoYbr/esdgSMMXuWDibUfaye/QHKDgqHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=qMTmfqny; arc=none smtp.client-ip=203.205.251.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1718418421; bh=6hAqyrP6UwWj4t+o8mwaPSrgZwEvnY224lZy4GtT7xM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qMTmfqnyXpedrIneWvUJTFK2up7SLdDSFuroVa4u6BBMphATFEOhPsMrcXESlYX+X Eh0x/ad87VlGnatuyscHFnJbKzpwyIoTMyzjx5gfOsubrZXIJ9xdS5zMxyjuiI6VmA /N4wMcZykn02dCXgaLM1f8Bc1+3LrBettr/be7wQ= Received: from pek-lxu-l1.wrs.com ([111.198.228.103]) by newxmesmtplogicsvrszc13-0.qq.com (NewEsmtp) with SMTP id 6BB9F467; Sat, 15 Jun 2024 10:26:59 +0800 X-QQ-mid: xmsmtpt1718418419turvj0wna Message-ID: X-QQ-XMAILINFO: OQhZ3T0tjf0aO645nJ9CGVH2jDx57WBcUYx8TBpKwHWArjdRqRerZ2dxoZPUDN xRkwaB3CMryy0IhNj/ANG2c1AFAqw0bDpCt2x19N5/32ci4KGQqtyQ/0wkkPTEiLr1Yw8O1ru5z2 mNxw0iDwP9+onIqPJRLef1x5w91wuOycdaeJNOSQLZv+Aez78pPBbMJ177qfIHq7AgNb8I1O4VJY ++wq1iy2kA2GcMdJLnMzMMJukEtSw9IZP7cNnlD6ziELqjzumpRiTBf8q74Mnzd0EdsKye2zZqan iRAdT+27OUEnbGjGPQtl7bzKM57LzwSWJo4cKJHU+f/IAlSDFscA2IDMu2nsef3PIZ9e1YRsJ/f1 8zclKaVAMh3XEiIhMRXYzYLT4wW3LhpZuTSmhqtl4kgaiGfEGAtvP2vL6dQjIZyi1gv7WwGBS5yb 4JhEG5nwL69FSFp43T84768317OrCZg+yq1sZp8oKcSEAFZzoBgLc/3aBeRFj+4qc5U/8XcLaniq xKNw5h+dfOmwKUcPhBPmI7exniGiRd1JiiihBqSotsRkXr5YjHWhOyjO6idwArOdrbKXe+T4gRtF DiOdzUwpilCaA5COsoVnI+YV98cM4yM2pdQeDn9Pg5iKEvyTDzj4BkuhQ1LIGwJ2d2/V2oNqR3xj OkYRLxtr6anA9MzZWPEqnmUgJ1Fhqt7z4GoDj2spX9L5kozdSypcDdTwhdDihk4GLXl5gjRtvKAa rasdc6RELNIZ1IwXqMAj8UwVcuQ0FJ0PhpGgBhyO0DO3NRqa6J5VQvcivHJLu1vLiJ9lq0trw2WA D0ZSKHkISAbGNSVMmMXMUpA4S5SxxmlVM6oC411+iwttxPQk4cf33F9WI2T0/Op5pQCcxSsKTF5u UYjrHK7rXx9tqyKgADGlc2t+ju9w49S6+xr20jlKtzeymGbYUJlAB82IUBCFvubA== X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Edward Adam Davis To: syzbot+4366624c0b5aac4906cf@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [bcachefs?] WARNING in bch2_fs_read_write_early Date: Sat, 15 Jun 2024 10:27:00 +0800 X-OQ-MSGID: <20240615022659.3443907-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <00000000000053e574061ad89521@google.com> References: <00000000000053e574061ad89521@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit please test no write lock in bch2_fs_read_write_early #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2ccbdf43d5e7 diff --git a/fs/bcachefs/snapshot.c b/fs/bcachefs/snapshot.c index 51918acfd726..b27a4327274d 100644 --- a/fs/bcachefs/snapshot.c +++ b/fs/bcachefs/snapshot.c @@ -1566,7 +1566,9 @@ int bch2_delete_dead_snapshots(struct bch_fs *c) return 0; if (!test_bit(BCH_FS_started, &c->flags)) { + down_write(&c->state_lock); ret = bch2_fs_read_write_early(c); + up_write(&c->state_lock); bch_err_msg(c, ret, "deleting dead snapshots: error going rw"); if (ret) return ret;