Received-SPF: pass (google.com: domain of linux-kernel+bounces-215677-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 15 Jun 2024 04:00:56 +0100
From: Al Viro <viro@zeniv.linux.org.uk>
To: Congjie Zhou <zcjie0802@qq.com>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: modify the annotation of vfs_mkdir() in fs/namei.c
Message-ID: <20240615030056.GO1629371@ZenIV>
References: <tencent_3A7366F414667EE52C073850077331ADC709@qq.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_3A7366F414667EE52C073850077331ADC709@qq.com>
Sender: Al Viro <viro@ftp.linux.org.uk>

On Sat, Jun 15, 2024 at 09:59:13AM +0800, Congjie Zhou wrote:
> modify the annotation of @dir and @dentry


>   * vfs_mkdir - create directory
>   * @idmap:	idmap of the mount the inode was found from
> - * @dir:	inode of @dentry
> - * @dentry:	pointer to dentry of the base directory
> + * @dir:	inode of parent dentry of @dentry
> + * @dentry:	pointer to dentry of the new directory

Ugh...  How about 'inode of the parent directory' and 'dentry
of the child to be' instead?