Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1225566lqs; Fri, 14 Jun 2024 23:01:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWA0EE5rWLicwLJ0DejQxFMOnKL4wQCgIb6aFVJ+suPxMxs1VOoO3onUQseRPmZf9uEGPx9FYF00QmsFAfzg+ZMV/apnQzmciQCjndDXw== X-Google-Smtp-Source: AGHT+IGkEmDsrNS9zqGEAkDBtRxdC9WzgYTYoDEmTqpWui2THztt3nzEpw3cC1bUJZZgQjBjkGU0 X-Received: by 2002:a05:620a:2681:b0:795:59a3:3912 with SMTP id af79cd13be357-798d253aa75mr565556085a.46.1718431317388; Fri, 14 Jun 2024 23:01:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718431317; cv=pass; d=google.com; s=arc-20160816; b=g8rwUmghnJmt9h4I1nQCOaKX98ZdgWResiqkTzjoxifpVT2Q2YFlemPuVZBx7CJJzk mhMB3m7W4qikbHY2dlKcj5lNM5lPkyp/ms+rcUvhjyPtszBBT2M0Z04bWDc7uL2jsnxi 6dFLKPc6MB+g1H2hwivH51kSoElDHv4cRNF/GH2ZCeWDIGb5yAy9zJZORtawOX1uxWbm L18cHH9t09jIABSpujWRZqrT+84AW1kcOMhqPPD2oO6T0qErl9YUWxpSZgMMn96ilNOJ mCkGtCsmcIrzprAB4A71DbiOxz+PzPivhpoweGqP0JizwSAHMwMrdcPEgu2+IZWyxrnw 7K5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:feedback-id:dkim-signature :dkim-signature; bh=Ut+CKX+eYnOgJHTPoNOfgg3PZFekCdvoV0ptxsFX8P4=; fh=5EQyDiYgg+kua2A2AF9eJME8jasrrRA/Pgg86y+lzvY=; b=lEQdvEzm7MuzLI+SVu+rB7IG/4snHAVCf4jbR2FDSdLmUrxxZjTakxCKjRJB+AlCFy hzUMCJYkgWjXri8WkZZRRF46G6/dRU1Ru7ZzKOhrLRCMfM3P3A4aXuNm//xp10FpDguJ GmE7khIfKTQH4pNTbxESjZRLN0yEjONuyav6ETZvhkbKEMTntDgVdK9BZ/Nt8Putx4BH Y2Zw7XtfHtkAhMilfUyOX6y2TEQlHvDG9e9aQrp6wjuEEfabK7Jy0G5oo70HWzeXiVwI qdTWkZ7+tgMl5hOrk9MO7xCUB9cilldncQyBuzil12OrYSNA20cT7542Yt6F27Yo1MIm wtdA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm1 header.b=MIeIXuv6; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=RTwuwVLT; arc=pass (i=1 spf=pass spfdomain=sakamocchi.jp dkim=pass dkdomain=sakamocchi.jp dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sakamocchi.jp); spf=pass (google.com: domain of linux-kernel+bounces-215717-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-798aadc67acsi517801685a.202.2024.06.14.23.01.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 23:01:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215717-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm1 header.b=MIeIXuv6; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=RTwuwVLT; arc=pass (i=1 spf=pass spfdomain=sakamocchi.jp dkim=pass dkdomain=sakamocchi.jp dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sakamocchi.jp); spf=pass (google.com: domain of linux-kernel+bounces-215717-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 057521C21429 for ; Sat, 15 Jun 2024 06:01:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AAEE117BBE; Sat, 15 Jun 2024 06:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="MIeIXuv6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RTwuwVLT" Received: from fout8-smtp.messagingengine.com (fout8-smtp.messagingengine.com [103.168.172.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7736179A7 for ; Sat, 15 Jun 2024 06:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718431309; cv=none; b=FoOymPAXNvDuVGLvAzkE4hoCb2d49DX34epd6wxnE/urFyBykDSuCxuNIQvfG8+x19oR8G1rv5H6/mgV/oDGf1WBkHGT1I+IkLexhntbGyBT4ArAYEqzS5KyiBnNlTo09MJxM8mTPQc7N+8ItNU6zAL7H4d8Is6RyCKd5IUaEVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718431309; c=relaxed/simple; bh=POHjLfvVul8Nt2xxauu5W0L4q4Y4dFr1jlfOup9+hcE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eAQAntTGI3n0vAepWtBBgAoYJQntTvmwj5edVtAZqkEAMfn1XRC+aJaqifdt4taTW3/25Gx0EThPq4m54Sg8bvoKhvEt995mNQxkmD9700geUs7C9qetBSk8AskHJerwESbWS214+xT8bxKZu2VIEp1UUWCbmjk4EW43X/1W+bc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=MIeIXuv6; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=RTwuwVLT; arc=none smtp.client-ip=103.168.172.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id EADBC13802E0; Sat, 15 Jun 2024 02:01:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 15 Jun 2024 02:01:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1718431306; x= 1718517706; bh=Ut+CKX+eYnOgJHTPoNOfgg3PZFekCdvoV0ptxsFX8P4=; b=M IeIXuv6UsRJTUvaKnxGh+dyKSt0FqTUQSpZU7Op/eB4ab+9ZBrQI8SIhdrg71lAc TBvcbD+2914XUalxlPnLkWsisoMl2Me0w8pAmRTEK17GW8YDvNfficb3Ns0fzzWr ySTe8sL0OQv97QXchCbG+9kpysJornRPljyCk+nVDjQwclXyrRKS1H3qa8IYUnoj 9zgfLX0HL6cZJtf8xtmQDz9qS2BqvQs0g2X6RqijRZuP2eo6qxHjX6RW4Z2ywkLa I/ac/E8M/Dtdwu/aMQQdeholtq/LI0YkxWwd0oYyJHARU/jztUR9tW3pG+FjPvXe WNEJWeI5eZLWvyhUGg9XA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1718431306; x=1718517706; bh=Ut+CKX+eYnOgJHTPoNOfgg3PZFek CdvoV0ptxsFX8P4=; b=RTwuwVLTWHaQn6lHJlKNTsDg6e6SgMfwd8+PXUNFYSF/ NPdoOCeKi27VTIL+lkx4ephbg/A4lEam7NE4+37wPwUwdUrnV17lMjWcdK1iGzQz Am5t72LKD1RAdAYLOaB76nrDKqptp76KQpAcMBr8+NklcizglcGCYHK5xc03pEvj QFi58nUAtAxSF3mrmvMMA+nCsQmk9T7lCKe12ztkEbVLyKzkiM1JRXtNkjXm33zn PIsTHZj+oNEbxEhz5NLW2CIpAC2NXhsG+6U/tEIdqlAs7o5hg3tl5E8woCwyYIMP sSUdWytuTxIqbgB5B5ZsbN/I/LiBnPueQvcNSvzaVQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvtddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesth dtredttddtvdenucfhrhhomhepvfgrkhgrshhhihcuufgrkhgrmhhothhouceoohdqthgr khgrshhhihesshgrkhgrmhhotggthhhirdhjpheqnecuggftrfgrthhtvghrnhephefhhf ettefgkedvieeuffevveeufedtlefhjeeiieetvdelfedtgfefuedukeeunecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhih esshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Jun 2024 02:01:45 -0400 (EDT) Date: Sat, 15 Jun 2024 15:01:43 +0900 From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] firewire: store the numeric identifier of card in data structure for tracepoint events Message-ID: <20240615060143.GB497879@workstation.local> Mail-Followup-To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20240613131440.431766-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613131440.431766-1-o-takashi@sakamocchi.jp> On Thu, Jun 13, 2024 at 10:14:32PM +0900, Takashi Sakamoto wrote: > Hi, > > In v6.10 kernel, some tracepoints events are added to record > IEEE 1394 asynchronous communication. In the case that multiple 1394 OHCI > controllers are available in Linux system, it is hard to distinguish > the controller used for the communication, since these events have no > member in their data structure to express the used controller. It is a > bit inconvenient to diagnose things. > > This series of patches is an attempt to solve the issue. In Linux > FireWire core, the available controllers are maintained in list, and > each of them has its own numeric identifier (=card_index). In this > series, the index value is added to the data structure. > > I would like to put the change to v6.10-rc4 (or later) as the part of > fixes if receiving no objections. > > Takashi Sakamoto (8): > firewire: core: record card index in tracepoinrts events derived from > async_outbound_complete_template > firewire: core: record card index in tracepoinrts events derived from > async_outbound_initiate_template > firewire: core: record card index in tracepoinrts events derived from > async_inbound_template > firewire: core: record card index in async_phy_outbound_initiate > tracepoints event > firewire: core: record card index in async_phy_outbound_complete > tracepoints event > firewire: core: record card index in async_phy_inbound tracepoints > event > firewire: core: record card index in tracepoinrts events derived from > bus_reset_arrange_template > firewire: core: record card index in bus_reset_handle tracepoints > event > > drivers/firewire/core-card.c | 6 +- > drivers/firewire/core-cdev.c | 6 +- > drivers/firewire/core-topology.c | 2 +- > drivers/firewire/core-transaction.c | 30 ++++---- > include/trace/events/firewire.h | 113 +++++++++++++++++----------- > 5 files changed, 92 insertions(+), 65 deletions(-) Applied to for-linus branch. Thanks Takashi Sakamoto