Received-SPF: pass (google.com: domain of linux-kernel+bounces-215720-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 15 Jun 2024 08:18:41 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: 8250: Fixes: Fix port count mismatch with
 the device
Message-ID: <2024061500-jeep-upchuck-6b3a@gregkh>
References: <20240614090322.2303-1-crescentcy.hsieh@moxa.com>
 <2024061406-simmering-sanded-17ef@gregkh>
 <Zm0odLN7ZJ/qI1nX@localhost.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zm0odLN7ZJ/qI1nX@localhost.localdomain>

On Sat, Jun 15, 2024 at 01:36:52PM +0800, Crescent CY Hsieh wrote:
> On Fri, Jun 14, 2024 at 11:07:29AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Jun 14, 2024 at 05:03:22PM +0800, Crescent Hsieh wrote:
> > > Normally, the number of ports is indicated by the third digit of the
> > > device ID on Moxa PCI serial boards. For example, `0x1121` indicates a
> > > device with 2 ports.
> > > 
> > > However, `CP116E_A_A` and `CP116E_A_B` are exceptions; they have 8
> > > ports, but the third digit of the device ID is `6`.
> > > 
> > > This patch introduces a function to retrieve the number of ports on Moxa
> > > PCI serial boards, addressing the issue described above.
> > > 
> > > Signed-off-by: Crescent Hsieh <crescentcy.hsieh@moxa.com>
> > > ---
> > >  drivers/tty/serial/8250/8250_pci.c | 13 ++++++++++++-
> > >  1 file changed, 12 insertions(+), 1 deletion(-)
> > 
> > What commit id does this fix?
> 
> None, it's just a normal patch, I might have mistakenly added the "fix"
> tag.

You say "fix" twice in the subject line, and it looks like it actually
does resolve a problem in the current code.

Or is this all just a "cleanup" change?

confused,

greg k-h