Received-SPF: pass (google.com: domain of linux-kernel+bounces-215735-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 15 Jun 2024 16:01:58 +0900
From: William Breathitt Gray <wbg@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Judith Mendez <jm@ti.com>, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: ti-eqep: implement over/underflow events
Message-ID: <Zm08ZiyXEgWYLZbc@ishi>
References: <20240609-counter-ti-eqep-over-under-events-v1-1-74fe1632f5ab@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5rDbGY9WaoBneDXG"
Content-Disposition: inline
In-Reply-To: <20240609-counter-ti-eqep-over-under-events-v1-1-74fe1632f5ab@baylibre.com>


--5rDbGY9WaoBneDXG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 09, 2024 at 04:49:33PM -0500, David Lechner wrote:
> This adds support to the TI eQEP counter driver for subscribing to
> overflow and underflow events using the counter chrdev interface.
>=20
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> This is split out from a series that was sent a few years back [1] that
> I never finished, so I'm calling it v2. This was tested on a BeagleBone
> Blue using LEGO MINDSTORMS EV3 motors and this script[2].
>=20
> [1]: https://lore.kernel.org/linux-iio/20211017013343.3385923-2-david@lec=
hnology.com/
> [2]: https://github.com/dlech/linux-counter-ti-eqep-python/blob/3745b0840=
736248d8e60cc675a0f43558fcbb2af/test.py
>=20
> v2 changes:
> * Only clear interrupts that were handled.
> * Don't set default QPOSMAX value.
> * Don't error when setting QPOSMAX to 0.
> * Use regmap_write() when appropriate.
> * Validate watch channel.
> * Use counter_priv().

Hi David,

It's nice to see progress on this again. I remember there being some
sort of interrupt storm if QPOSMAX was set to 0. Is that still the case,
or was it resolved with the changes in this version?

Willia Breathitt Gray

--5rDbGY9WaoBneDXG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZm08ZgAKCRC1SFbKvhIj
KyjmAP9nNugcU2bKySz+yH49JaVB3/oK58jNapUVdysZL/9jlgD7BFQtFn76eBzf
9qFFPWxCic7ze1h/MK2usH9pMwgYYgE=
=qEE6
-----END PGP SIGNATURE-----

--5rDbGY9WaoBneDXG--