Received-SPF: pass (google.com: domain of linux-kernel+bounces-215790-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240613085812.4020-2-shresthprasad7@gmail.com>
 <cc66cca1-33db-4f30-afcf-d256a959896b@yandex.com> <9ce15b81-a8bd-4833-b15e-3e6f240dcf03@kernel.org>
 <495e50aa-6819-457d-8503-00440abc97e3@yandex.com> <58e85008-a268-4555-bafb-f948ade16a63@kernel.org>
 <20240613195629.GA2359753-robh@kernel.org>
In-Reply-To: <20240613195629.GA2359753-robh@kernel.org>
From: Shresth Prasad <shresthprasad7@gmail.com>
Date: Sat, 15 Jun 2024 14:06:45 +0530
Message-ID: <CAE8VWiJr6tTNVmRfxHwYueC6xcNs1sLjw0gASamTaooAmcBnPA@mail.gmail.com>
Subject: Re: [PATCH v3] dt-bindings: phy: rockchip-emmc-phy: Convert to dtschema
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>, Johan Jonker <jbx6244@yandex.com>, vkoul@kernel.org, 
	kishon@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, 
	sebastian.reichel@collabora.com, s.hauer@pengutronix.de, 
	cristian.ciocaltea@collabora.com, andy.yan@rock-chips.com, 
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, 
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, 
	javier.carrasco.cruz@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 14, 2024 at 1:26=E2=80=AFAM Rob Herring <robh@kernel.org> wrote=
:
>
> On Thu, Jun 13, 2024 at 02:52:46PM +0200, Krzysztof Kozlowski wrote:
> > On 13/06/2024 12:33, Johan Jonker wrote:
> > >
> > >
> > > On 6/13/24 12:12, Krzysztof Kozlowski wrote:
> > >> On 13/06/2024 11:44, Johan Jonker wrote:
> > >>>> ---
> > >>>
> > >>> Add ack request from phy maintainer here.
> > >>
> > >
> > >> Why? What do you mean for that? Why phy maintainer needs to ack patc=
hes
> > >> he is going to take?
> > >
> > > See my text below:
> > > From my past converting phy documents experience asking was needed to=
 smooths things up ...
> > > Let me know if things have improved.
> > >
> > > grf.yaml can be busy at times. Let Heiko take care of the merge order=
.
> > > Ask for an ack from the phy maintainers in your commit message below =
a "---"
> > >
> > >>
> > >>>
> > >>>> Changes in v3:
> > >>>>     - fix `reg` in example being too long
> > >>>>
> > >>>> Tested against `rockchip/rk3399-firefly.dtb`, `rockchip/rk3399-ora=
ngepi.dtb`
> > >>>> and `rockchip/rk3399-pinebook-pro.dtb`.
> > >>>>
> > >>>>  .../bindings/phy/rockchip,emmc-phy.yaml       | 79 ++++++++++++++=
+++++
> > >>>>  .../bindings/phy/rockchip-emmc-phy.txt        | 43 ----------
> > >>>>  .../devicetree/bindings/soc/rockchip/grf.yaml |  2 +-
> > >>>>  3 files changed, 80 insertions(+), 44 deletions(-)
> > >>>>  create mode 100644 Documentation/devicetree/bindings/phy/rockchip=
,emmc-phy.yaml
> > >>>>  delete mode 100644 Documentation/devicetree/bindings/phy/rockchip=
-emmc-phy.txt
> > >>>>
> > >>>> diff --git a/Documentation/devicetree/bindings/phy/rockchip,emmc-p=
hy.yaml b/Documentation/devicetree/bindings/phy/rockchip,emmc-phy.yaml
> > >>>> new file mode 100644
> > >>>> index 000000000000..85d74b343991
> > >>>> --- /dev/null
> > >>>> +++ b/Documentation/devicetree/bindings/phy/rockchip,emmc-phy.yaml
> > >>>> @@ -0,0 +1,79 @@
> > >>>
> > >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > >>>
> > >>> You are converting an existing document, so GPL 2 only.
> > >>
> > >
> > >> Which copyrightable part was copied? This comment is not correct in
> > >> general, because conversions are dual-licensed (there are exceptions=
,
> > >> but that's the generic rule).
> > >
> > > Was told to do so in the past by the maintainers(Rob??) for text
> > > documents conversions.(Can't find exactly were in lore, must be in on=
e my first conversion patches)
> > > If someone was submitting as GPL2 long time ago then the derived/conv=
erted work still hold the same license.
> > > Let me know if the consensus has changed.
> >
> > Consensus did not change but I am no sure if you got it right. It was
> > about copied copyrightable text. Which part was copied here?
>
> It is derived from the text binding, so strictly speaking that's derived
> work. Are descriptions (because that's really all we take) enough to be
> copyrightable? That's another question...
>
> I don't know so I err on the side of keep GPL-2.0-only *only*.
>
> Will anyone ever care? Not likely.
>
> Rob

Just to be safe I'll change the license to GPL-2.0-only then.
Thank you everyone for the feedback, I'll fix everything and resend the pat=
ch.

Regards,
Shresth