Received-SPF: pass (google.com: domain of linux-kernel+bounces-215836-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 15 Jun 2024 11:40:50 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Trevor Gamblin <tgamblin@baylibre.com>
Cc: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: adi-axi-adc: improve probe() error messaging
Message-ID: <20240615114050.46d2b0a7@jic23-huawei>
In-Reply-To: <964821b3-dcbb-42b8-9062-2366a4d30a76@baylibre.com>
References: <20240613163407.2147884-1-tgamblin@baylibre.com>
	<57d4659a5abb63d7c085865059b9d71c40371edd.camel@gmail.com>
	<964821b3-dcbb-42b8-9062-2366a4d30a76@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 14 Jun 2024 15:18:12 -0400
Trevor Gamblin <tgamblin@baylibre.com> wrote:

> On 2024-06-14 5:11 a.m., Nuno S=C3=A1 wrote:
> > On Thu, 2024-06-13 at 12:34 -0400, Trevor Gamblin wrote: =20
> >> The current error handling for calls such as devm_clk_get_enabled() in
> >> the adi-axi-adc probe() function means that, if a property such as
> >> 'clocks' (for example) is not present in the devicetree when booting a
> >> kernel with the driver enabled, the resulting error message will be
> >> vague, e.g.:
> >> =20
> >>> adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed wi=
th error -2 =20
> >> Change the devm_clk_get_enabled(), devm_regmap_init_mmio(), and
> >> devm_iio_backend_register() checks to use dev_err_probe() with some
> >> context for easier debugging.
> >>
> >> After the fix:
> >> =20
> >>> adi_axi_adc 44a00000.backend: error -ENOENT: failed to get clock
> >>> adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed wi=
th error -2 =20
> >> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> >> --- =20
> > Somehow feel that in these cases the error log should come from the fun=
ctions we're
> > calling but bah... likely not going happen/change:
> >
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> >
> > (As a suggestion, you may do similar work in the axi-dac driver) =20
>=20
> Thanks. I'll send that early next week after a quick test on a board.
I tweaked the commit text to say
After the change:
as I don't want to see this picked up by a bot for stable.

As a side note, you could have taken the opportunity to add
struct device *dev =3D pdev->dev;
which I think would have reduced a few line lengths without loosing
readability.  Not important though and perhaps not even a good idea :)

Applied to the togreg branch of iio.git and pushed out as testing.
Note I plan to rebase my tree shortly to avoid some merge conflicts
that otherwise occur.  I'll probably do that before I push out
other than as testing.

Thanks,

Jonathan

>=20
> Trevor
>=20
> >
> > - Nuno S=C3=A1
> >
> > =20
>=20