Received-SPF: pass (google.com: domain of linux-kernel+bounces-215843-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 15 Jun 2024 12:54:58 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
	lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
	f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
	srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org,
	allen.lkml@gmail.com, broonie@kernel.org
Subject: Re: [PATCH 5.4 000/202] 5.4.278-rc1 review
Message-ID: <2024061527-skinny-recent-5ed3@gregkh>
References: <20240613113227.759341286@linuxfoundation.org>
 <3ed1ecee-78bb-450e-933f-1e06b1e392bd@roeck-us.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ed1ecee-78bb-450e-933f-1e06b1e392bd@roeck-us.net>

On Thu, Jun 13, 2024 at 09:35:07AM -0700, Guenter Roeck wrote:
> On Thu, Jun 13, 2024 at 01:31:38PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.278 release.
> > There are 202 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sat, 15 Jun 2024 11:31:50 +0000.
> > Anything received after that time might be too late.
> > 
> 
> net/nfc/nci/core.c:1455:15: error:
>       mixing declarations and code is incompatible with standards before C99
>       [-Werror,-Wdeclaration-after-statement]
>  1455 |         unsigned int hdr_size = NCI_CTRL_HDR_SIZE;
> 
> Maybe enable C99 on older kernel branches ?
> 
> The code is
> 
> +static bool nci_valid_size(struct sk_buff *skb)
> +{
> +       BUILD_BUG_ON(NCI_CTRL_HDR_SIZE != NCI_DATA_HDR_SIZE);
> +       unsigned int hdr_size = NCI_CTRL_HDR_SIZE;
> 
> Swapping those two lines would be another possible fix.

Odd, I fixed this for other branches, but it didn't trigger for me here,
must be a build issue somewhere.

I'll go fix it up now, thanks!

greg k-h