Received-SPF: pass (google.com: domain of linux-kernel+bounces-215853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <98cf0387-eb8e-492b-a78b-b21e3f6dd7e3@web.de>
Date: Sat, 15 Jun 2024 13:15:38 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Geetha sowjanya <gakula@marvell.com>, netdev@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Hariprasad Kelam
 <hkelam@marvell.com>, Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
 Sunil Goutham <sgoutham@marvell.com>
References: <20240611162213.22213-2-gakula@marvell.com>
Subject: Re: [net-next PATCH v5 01/10] octeontx2-pf: Refactoring RVU driver
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240611162213.22213-2-gakula@marvell.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:uTBMgqz8/C8=;qrdO8M4BMDbaK2d2cE0VowkzJlc
 9ZBRjWrwDtEvL4fbUchakKlRbJ8y5lyK+5g79jrznRW8v1Xu21g4aU2tSOIiMT1Oj/KHkYu+3
 Snr0IoIaxAe25HS9csndxZy+YUbAKJ7auGfJtwf+4/vUYFOWFNlMvx+DGv3uB2VKKeMjx40Sm
 hv9Ca3LxPJgsVyOAI1vnoGJhxyGU4Yfo74bSSb4M8KojiysQG0damNuQr7xOkY2wIojVj3A34
 OnGNsoa4jO4jNk2TNdbnvmVNX2dpv805f8txt9U0CptYd5Rdo3K9gOdIoqC2APFN/Yztu2Rt7
 PRTL7+r2KVAsap1b2X+ilozlPwwlzCI4gk73iI+8FbPXnyKtY/yW8cvWi2p2zsQvDEHYz/XCE
 fm7ADKcKqq/eY9bm4knscgWh2+zIWBRK26aGK9Cr+f3JK1Ogr2rSqEkuD8p6IuH/gjo3z6r2j
 VCXUykff+qK3b0YVJPVmbaejjkIACTbdtPtHqtZ5WMCy9upYFKzYiouF8DOT2dR/3N75mA9n8
 /QSjQ35r08Bw+V8yfHXX13Cmyw1aGaWBiktsMT3RIjPlrDrD+BYrIIwGWTDGYh4lfyxa7euHv
 VFn5MMOgEeYTl1nlx4ux0odPkSgvOGMFv17lZOl1tBatCXBbXPTkHGjuHFXvJCPmymaY30TAX
 h8RLPvNV0xIE9UKCcoP9nbZY9rJnPAOGsWDMGym0ab8sO5hgXS/gw1kpKun2dhv4ACWxG90xH
 74l7jtaQ8gUaDQ3G9yV214JG93fx5E1znAnLCOUkZ+iE/z6rZjPrflWeQEgSrjRaoigerT5H6
 l6uB5mp3gCv7ovCJnpKF/U73ONY+r5dsipnw7NMkwMqPM=

=E2=80=A6
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
=E2=80=A6
> +void otx2_disable_napi(struct otx2_nic *pf)
>  {
=E2=80=A6
> -		cancel_work_sync(&cq_poll->dim.work);
> +		work =3D &cq_poll->dim.work;
> +		if (work->func)
> +			cancel_work_sync(&cq_poll->dim.work);
=E2=80=A6

I suggest to use the shown local variable once more.

+			cancel_work_sync(work);


=E2=80=A6
> +int otx2_init_rsrc(struct pci_dev *pdev, struct otx2_nic *pf)
> +{
=E2=80=A6
> +	return 0;
> +
> +err_detach_rsrc:
> +	if (pf->hw.lmt_info)
> +		free_percpu(pf->hw.lmt_info);
> +	if (test_bit(CN10K_LMTST, &pf->hw.cap_flag))
> +		qmem_free(pf->dev, pf->dync_lmt);
> +	otx2_detach_resources(&pf->mbox);
> +err_disable_mbox_intr:
> +	otx2_disable_mbox_intr(pf);
> +err_mbox_destroy:
> +	otx2_pfaf_mbox_destroy(pf);
> +err_free_irq_vectors:
> +	pci_free_irq_vectors(hw->pdev);
> +
> +	return err;
> +}
=E2=80=A6

Would you become interested to convert any usages of goto chains
into applications of scope-based resource management?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#=
L8

Regards,
Markus