Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1326879lqs; Sat, 15 Jun 2024 04:28:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUgoKabSV/eXq0/38uni8yENlRePyjA6R+Fzxs3aSQ5n/ZoCadn/0Dx2sQhtuEqj2IW+BEFvf8Zw5TKbymLk3wo6KS7ZBtY8XiTsHT54g== X-Google-Smtp-Source: AGHT+IFe0aBp/MUQ77axYopTCNSECHdPkx3LuZG+xP8BItvvNlMztg6Yv0r3KADijt5+70OWcA+T X-Received: by 2002:a05:651c:1026:b0:2eb:45b9:cb42 with SMTP id 38308e7fff4ca-2ec0e5d13a9mr32652891fa.26.1718450937633; Sat, 15 Jun 2024 04:28:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718450937; cv=pass; d=google.com; s=arc-20160816; b=SMvN71cMa+hupt76SNpSARkYtLgqVtx4FVpSEg90QWuJIxT7bGDv+PhQPzGhy1pxOn 9jfPTFoFIBAARP8vPf/N86xca/ElIib0OX+A1hzBC3gEjtkHWHVNDf0ai8uSGvn/5v/5 KkdUzxbFZJkLN50/0FsNNhblEqxDGLLH+20cXJ0XVTZ0fQoW2S2dh20d2pvGTVX72vFs 9foxj1zIPdKZmBBrlcFSVirDTKZP2tLfKd+Aqz3+ah/muuCtif+CtBIgEbC6heZfYP6p 4VFnwC26wWh0w9YcQRvZlonx+H+IoaDv55Wl0C4V/YPVurh6r0NmcjVQ98klZtiJzuOG kctA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5cfpNhUeQXoiMt8QIStiYYLXtYSXmM9M5tXUD/QDu14=; fh=cLkK1xifJeANe5Qyst5EjYcGa3EzP9zIQ0+WbR1vJlY=; b=IMhepvLUZXsZlN6MHNnyXRFd8ptngH5jNpC3zVo/U6ZHSIxFFR2sNW/YNi2+ai93vE yWqlLOTEDr9LN9mfw0KYtDvjC+VA7j9Fectb2mU8SmS0fWPcIuiQs3v3o+zoH252gA5M isEPna3DKG5zY/xM2oYZsBC/Lzo9R32HGP4HZbRO0lexHwQ0MIXjEq1a3AzjLuE2hD8z gisw+1xd5r/oBtyYbaVSUhIfyHdxY/UrLeW4CeZ8PcK0kr6Mq0Obf0BDPsVz7P0NlLsN y/Eubdiw0qX5SI6nGbkMRnHu+fiEV2iiaRa+Z4cK27cXxiVe6zL3JpmL9kuVTat6z9RB ZycA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CKKdDrmR; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-215724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215724-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57cb72d624esi2617669a12.56.2024.06.15.04.28.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 04:28:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CKKdDrmR; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-215724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215724-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6DBF31F22DB5 for ; Sat, 15 Jun 2024 06:29:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FF9E175BF; Sat, 15 Jun 2024 06:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CKKdDrmR" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F23D171A7; Sat, 15 Jun 2024 06:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718432982; cv=none; b=M+q0W0bfYSiDS7VlT6on93wMog+p7lU1P5/EbSzRYjGPO5+7uK4La2iHYiyyoV2mKm6TBfUG+HLNtuOu+1O0m6PRvC3NInIFeZfP/uI1L9/+KJ1x2NL9KvZYblt9LlbCugQL6JUe8RhTB0g8PMZ0Mu15e2SnNncwSYsNzHzPFOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718432982; c=relaxed/simple; bh=0zM6gJVJvoOmYTuTb0pxv20OuNzO82Jy5LiDFJyCn5Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tEpixJwPxu9MM4FkPqGeJwwFtA+R6EAzS8xCNxqHvEkXiouVMKQjHECfZ+LDudtlCXr1TCEUtk84rdZhjyK5Zims3MNjRUpSWN7iH5XNJZhEnZcYUQBd45KZ6uKjOoTrAk1HtszFG29t0gRM/XiUN2Io+XraGoFILK9xSAlUWz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=CKKdDrmR; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5cfpNhUeQXoiMt8QIStiYYLXtYSXmM9M5tXUD/QDu14=; b=CKKdDrmRm8Oi6I17Cs1sa3UEXm jkl72unEqvU5duMWnvjO8KXokXQTGN1t3XChuMQILlrtvYS3NzEG21+fC1HEsYuNrNG5fJ5CZvBlQ cYr2IS/ymR08lDStsw5h7TpyQ9esEU2flMB3716Sl78UkpMScs++l6c0NaukGTxbcR7lQB5eCzfX2 yBUYfiH0unsAylR1ifdfMApo+E/CVh+U5+QnPMdoWYRt9xA1tDEW6SOrgrlI7wWI3XpfIXIsTI2aI 0cXSVSsINi0HKjwz1x4VW4skYwk9EJ9YBqhguGM4qaxFDFDYfkDLoA0EPXSxD/KBbT1IgdvFoQ8IM nRKjzEqA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIMuw-00000004nqX-3HBv; Sat, 15 Jun 2024 06:29:38 +0000 Date: Fri, 14 Jun 2024 23:29:38 -0700 From: Christoph Hellwig To: Congjie Zhou Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs: modify the annotation of vfs_mkdir() in fs/namei.c Message-ID: References: <20240615030056.GO1629371@ZenIV> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Sat, Jun 15, 2024 at 12:38:32PM +0800, Congjie Zhou wrote: > modify the annotation of @dir and @dentry Well, it is clearly obvious that you modify them from the patch. But why?