Received-SPF: pass (google.com: domain of linux-kernel+bounces-215916-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ac47a370-99ca-4fb9-8fb0-800894d04c57@web.de>
Date: Sat, 15 Jun 2024 17:11:53 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Geetha sowjanya <gakula@marvell.com>, netdev@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Hariprasad Kelam
 <hkelam@marvell.com>, Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
 Sunil Goutham <sgoutham@marvell.com>
References: <20240611162213.22213-3-gakula@marvell.com>
Subject: Re: [net-next PATCH v5 02/10] octeontx2-pf: RVU representor driver
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240611162213.22213-3-gakula@marvell.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:yAljG0BDJiQ=;ezgkplc3NxtvGdIWrHfSknVEaQU
 YqyGLMGqb9EjFAnUDPDtHpsGQsDdunW0qQqYY/GWrkTbq+quoCUy9FHo8VEaF9Q+pU4JJWNBk
 6aHjY9lFCs1y5P6M1TI5RR9u8srzxL7cYIdNgaE2DxsXOsfATWJe14d+PMKaHyqzR70Z2hkxJ
 mqQpUIhGxfQfab79cBiozsoyEGpYtLOqqdng5zkfxICezCAfcizrJYvyXNn/LZ1MomOHogcKy
 QJgnD7KeGDK3+AVv3R7R34B/oiJ9UB3A5jWqOOkyEqrGgDJE5oCquJgiXSaSzuEfu1CgMUqu3
 Tm7wWsOAWZWlZnvvF/8LMBnDE+gRyNy5LXhChx2Kt5Fo97am8j0SOXOUUIQDqdNbrwWic+7MC
 wtofcn8vu625IcvRisVZYhABWY6dym9qeGbUBCGKH5f7t00D5FCMdHzWev9aoOLbIYzpXqM/r
 lv9ye8cvhGajhPAsqE3RRYCc1Phpk7mgV+P/0SFMAnkAHqHB6tsWs7/kjJoTqJuuuuGRKuGth
 w3qlUCyiFc0X2UNneNXIL4GnV4s94+74w+H9AgGtkZjpJIpCpM5DDuVIZkYQAarqH458EWBxt
 lXWjLrhmLjkmSRi8ncpmpkDZJ4AolpSYcrkLO+bYJIUlRynNe+8IuATfTKvbaGswHscRO1/To
 c9Y69ih73KkikrRHV53d4ydqtwPohziskk0eAjXY5BEhvrxDE1+JcobUWOuvmJUxGoGJ4qRwE
 mnr10i2lk40mV8tOSLrz7C91AIPqF3zq5HSv7hm5whbaqvGgzg0c0v7FeX3tLLY0TCzXwK1Ym
 4ef0Ph73u8guAkyJCDUjv/7zIOx8gDAKL/1dnDsl8tD1c=

> This patch adds basic driver for the RVU representor.
=E2=80=A6

Please improve such a change description with imperative wordings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do=
cumentation/process/submitting-patches.rst?h=3Dv6.10-rc3#n94

Can an adjusted summary phrase become also a bit more helpful?
https://elixir.bootlin.com/linux/v6.10-rc3/source/Documentation/process/ma=
intainer-tip.rst#L124


=E2=80=A6
> +static int rvu_get_rep_cnt(struct otx2_nic *priv)
> +{
=E2=80=A6
> +	mutex_lock(&priv->mbox.lock);
> +	req =3D otx2_mbox_alloc_msg_get_rep_cnt(&priv->mbox);
=E2=80=A6
> +exit:
> +	mutex_unlock(&priv->mbox.lock);
> +	return err;
> +}
=E2=80=A6

Would you become interested to apply a statement like =E2=80=9Cguard(mutex=
)(&priv->mbox.lock);=E2=80=9D?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L1=
96


=E2=80=A6
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.h
> @@ -0,0 +1,31 @@
=E2=80=A6
> +#ifndef REP_H
> +#define REP_H
=E2=80=A6

Can unique include guards be more desirable also for this software?

Regards,
Markus