Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1429879lqs;
        Sat, 15 Jun 2024 08:16:58 -0700 (PDT)
X-Forwarded-Encrypted: i=3; AJvYcCXWxawW0rseEDUqiF6osnSKa9UVVSrK0uPhuH5xNHVtPi7CYVfA9IzPrLAPL8JhltF7BTkB9pek6wOF48IyIO+CQwpvdfsO2KiTH/BV1Q==
X-Google-Smtp-Source: AGHT+IEcrt83uPh8X7S9yQz/2kHclE416ScxiLO/7WoedYMZ0mXCmSdgdCRI4KnEbmzaD3HsOffr
X-Received: by 2002:a50:9557:0:b0:57c:6afc:d2a9 with SMTP id 4fb4d7f45d1cf-57cbd8f2a3emr3424084a12.26.1718464617885;
        Sat, 15 Jun 2024 08:16:57 -0700 (PDT)
ARC-Seal: i=2; a=rsa-sha256; t=1718464617; cv=pass;
        d=google.com; s=arc-20160816;
        b=JBcz2epavaeX9XrEVxNvLHLjlxcX/SXM9WHryYPl3fMjSeZSOGJulUBObF0KY95C+x
         ybKY2/eoOLHX5L23Rfu5WzjljYQ59z6PgC1i/h3rBNf7YA+3s9ZDoqaiggAvc4quVrCh
         W/6Or23W0/CfiYQKhnSYJKOaM1EDA3zHuWcnAB62mRUEMiA8qOXZZJ/7c2WsicppgIFy
         g0sMFN6OLtyhAtAbL21zShRXRF+D5z75LtVZ25n+N1+bRRxI2rhteAOqVdovVYEyFtin
         yXpL3YmTkLbPqGl7RCNuHrPMKeVj+hVYlE0aHeMa04+PxUqgEMrvOiO2wTBS7oz01xoo
         Rz1A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=in-reply-to:content-disposition:mime-version:list-unsubscribe
         :list-subscribe:list-id:precedence:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=k6+SnTKbUusEIF0rwEEMPmfFP7oS1BI7RELTSyI4xuk=;
        fh=Icc4ZEQalLCb+b727db90I4AB1uyc71qs2lo5fr9mLU=;
        b=M0B7S2ZbSa7vxvyDlTtUhQdySDtgPI7Lb1b/LlY7TbDxGqkmcBz+SllCkjWE6TBUdY
         Bi/LSiOm90Z48Z7GsEHli1KSqkRrt8tKwOf7TxurQpcsHMGhdAyTSoIX6ajw5I9nwykj
         SCcN3DbZ9ruvX1VZOe5SrTP0UK0Dt3ISxl40kxU3LAsyPaLJz4XNiblEJhoAlitGylnV
         JCDxyWgFfXHGvaP/Hi4f4N8oStqnYdiPaQODVq5Ze4xfRv3SnzkTwBWrCyw6mi+4VmqQ
         q6XPLkxjH4pyPxSH0UHrf2ZRHigr6U80NF1t/vhghTbPNq4E8vHDqTJEPLSs1flhSlUo
         tCig==;
        dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oITqWQkL;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-215917-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215917-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel+bounces-215917-linux.lists.archive=gmail.com@vger.kernel.org>
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249])
        by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57cb742cd7esi2768142a12.339.2024.06.15.08.16.57
        for <linux.lists.archive@gmail.com>
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Sat, 15 Jun 2024 08:16:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel+bounces-215917-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oITqWQkL;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-215917-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215917-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by am.mirrors.kernel.org (Postfix) with ESMTPS id 7E7621F221D0
	for <linux.lists.archive@gmail.com>; Sat, 15 Jun 2024 15:16:57 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EFD549649;
	Sat, 15 Jun 2024 15:16:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oITqWQkL"
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337234437;
	Sat, 15 Jun 2024 15:16:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1718464607; cv=none; b=AzRSLfiL9aR1lY7d/wU0JZV/BxLd/4vC+bspPuar+wp9MacTms4kwFo4hB+3Rz35tiZvmQE5egH1hGotNFBNmv8Dy9UKw2RFI/Sv7+K2y/dVQYsbX9bD0PhPQRJ6Ubv7f4s4gDpHQSWM8JaYCYDLsmYVGxhgPYE3Z8g7K8yyaME=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1718464607; c=relaxed/simple;
	bh=40Wj6XVGNuJpJuinT1FRLIVr94RxlZv+LTy0tHJIxw8=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=FV8wYtrTHctj7Tqo+8I/++fvvOfMk+zQR69teNBbsKihBJoATt50qJAIak5ThUL5fmg+nAhxiqENDhmKrE4Z6CN+A+gUyfdQL7+wm6OPWBbAaQcgBtCc8crWpVy0MIBwPq9AjvcbfWQEbB/X7KTXu1LHBSU9a1LSMoJWpaT71XY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oITqWQkL; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D39B0C116B1;
	Sat, 15 Jun 2024 15:16:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1718464606;
	bh=40Wj6XVGNuJpJuinT1FRLIVr94RxlZv+LTy0tHJIxw8=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=oITqWQkLtoirbzPziEOi8v1w2dJiXHu+NmH1id2OgsJQkJu21MBaSc/z1dJFdFzs2
	 x6jiFctC069hir6E/AtWT/rgAA+qP7/M+PmvgUh4zEAkESVjXTPvWECHcTsN3rpkPK
	 Dvp3g+rO4u6JhEjvVbffH/bWbylm45AVTHRRuD+a9k2n/XcweJSQJFkrc4DcVXatSA
	 w5aaGFOm2SHa2U9qNa/YsqiSMn/x8zkHl9MnFe1r4oERx3YAqub5LgFP3K7m6CjP1b
	 4xbguxZnP1O9UTmBMBl2+6fPm63hqJzVedAsBtjt5HZEQhI0nLXo5K+/e3tzH5/IYg
	 CDAKXPm2TzyIA==
Date: Sat, 15 Jun 2024 16:16:41 +0100
From: Simon Horman <horms@kernel.org>
To: Petr Oros <poros@redhat.com>
Cc: netdev@vger.kernel.org, ivecera@redhat.com,
	przemyslaw.kitszel@intel.com,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Marcin Szycik <marcin.szycik@linux.intel.com>,
	Konrad Knitter <konrad.knitter@intel.com>,
	Marcin Domagala <marcinx.domagala@intel.com>,
	"moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@lists.osuosl.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] ice: use proper macro for testing bit
Message-ID: <20240615151641.GG8447@kernel.org>
References: <20240614094338.467052-1-poros@redhat.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240614094338.467052-1-poros@redhat.com>

On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote:
> Do not use _test_bit() macro for testing bit. The proper macro for this
> is one without underline.

Hi Petr,

it might be nice to include a brief explanation as to
why test_bit() is correct.

> 
> Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
> Signed-off-by: Petr Oros <poros@redhat.com>
> Acked-by: Ivan Vecera <ivecera@redhat.com>

...