Received-SPF: pass (google.com: domain of linux-kernel+bounces-215933-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <21aa7ed7-6440-437d-a591-0da8cce4bc00@baylibre.com>
Date: Sat, 15 Jun 2024 11:30:59 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] counter: ti-eqep: implement over/underflow events
To: William Breathitt Gray <wbg@kernel.org>
Cc: Judith Mendez <jm@ti.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240609-counter-ti-eqep-over-under-events-v1-1-74fe1632f5ab@baylibre.com>
 <Zm08ZiyXEgWYLZbc@ishi>
Content-Language: en-US
From: David Lechner <dlechner@baylibre.com>
In-Reply-To: <Zm08ZiyXEgWYLZbc@ishi>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 6/15/24 2:01 AM, William Breathitt Gray wrote:
> On Sun, Jun 09, 2024 at 04:49:33PM -0500, David Lechner wrote:
>> This adds support to the TI eQEP counter driver for subscribing to
>> overflow and underflow events using the counter chrdev interface.
>>
>> Signed-off-by: David Lechner <dlechner@baylibre.com>
>> ---
>> This is split out from a series that was sent a few years back [1] that
>> I never finished, so I'm calling it v2. This was tested on a BeagleBone
>> Blue using LEGO MINDSTORMS EV3 motors and this script[2].
>>
>> [1]: https://lore.kernel.org/linux-iio/20211017013343.3385923-2-david@lechnology.com/
>> [2]: https://github.com/dlech/linux-counter-ti-eqep-python/blob/3745b0840736248d8e60cc675a0f43558fcbb2af/test.py
>>
>> v2 changes:
>> * Only clear interrupts that were handled.
>> * Don't set default QPOSMAX value.
>> * Don't error when setting QPOSMAX to 0.
>> * Use regmap_write() when appropriate.
>> * Validate watch channel.
>> * Use counter_priv().
> 
> Hi David,
> 
> It's nice to see progress on this again. I remember there being some
> sort of interrupt storm if QPOSMAX was set to 0. Is that still the case,
> or was it resolved with the changes in this version?
> 
> Willia Breathitt Gray

I haven't tried it with the rest of the old series yet, but with this
patch, it is not a problem to set QPOSMAX (ceiling) to 0.