Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1523710lqs; Sat, 15 Jun 2024 12:42:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbP8Wthhf37iLldnxlPpgMI//Invi8OhzqBefOnFSKoIAHdnK5fRGQ61ynEcOE/anVBXfzXSQLwOh/eSVKpYyYE5YJSPjIpbnTmLy2pw== X-Google-Smtp-Source: AGHT+IGo1+HV2EL2xoVab9kDZwyS1sdYt37QZnmDYt8soeSq4X+ROM8Kjl4mLWoDe2S/5bDSZj78 X-Received: by 2002:a17:906:6894:b0:a6f:33d6:2d45 with SMTP id a640c23a62f3a-a6f60dc4e59mr340951666b.60.1718480566362; Sat, 15 Jun 2024 12:42:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718480566; cv=pass; d=google.com; s=arc-20160816; b=Ejk4qTqu/r2/gOtVbmcTLlaGqbMqeMtwhXEautrpjwpuxTMV4uv186nKT8n3VtCVta p/JBdizndKLrMI2GTm12GoDo08rvfx9vosaVT4sBQ8Fb++rGSJpttPbHByqpJ655+nnm WOwNDsQm4ZdMl1yFjB7libXJw5U3SHPvNRSwWdA0YulB7e31V5yUKiRgPQRUgFlP3wME biajgxfXjLHhjrTeLCuZwiQV0wJc5Ys0kdXtvJ/a6V1h5XCFeZiYvFRC1Prc4qxZx/G5 O74WIOd0AuNp1UDTU9DTwxKm83qOBWfBpWFgNhczlV2r+IGo9ZF9t/Dp6mSqDpmXN/Mf fLLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature:dkim-filter; bh=qu/dBFFpqkkgxB6kh0uYEAdu/GrOhLxnW6Dyqt7w/7Y=; fh=ULC+tEOrcYJqwp6wfIuxbWDMfAKHVzTVsDn1M+RzszA=; b=joUA97OS4aeODnemADrsYMZM9UwPceDJF1KyoVui4vSi+mVeXdS8IEQZIr4j8/is66 VPTDzTPxD4yw3EGOPnbpa8o94WfwSf84/AwInDWQzqu2mhIrmXtD9f2i6lVObyp8kVpd t3Y1nZINol8vUspgMaw98JOKLwpb2zu6mT0/ODf1dgOu1mgs3BUtjaEppfCOwrUVTEyA G8uTovwYAt/SdLxcXKknSdAWx+W5nxQDKxaC1/5OlfUdvZlv8WIDGDcRHtFqtpttSgC/ eMTcVud46XGFltMBoFYaBLf38Jr7OZSfGx1Rwd/KOsuP97FVABuJYD74gdyuzhT/d4PP 4aRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=GcrpN0N0; arc=pass (i=1 spf=pass spfdomain=lwn.net dkim=pass dkdomain=lwn.net dmarc=pass fromdomain=lwn.net); spf=pass (google.com: domain of linux-kernel+bounces-215993-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215993-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lwn.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56d437bdsi308027166b.238.2024.06.15.12.42.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 12:42:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-215993-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=GcrpN0N0; arc=pass (i=1 spf=pass spfdomain=lwn.net dkim=pass dkdomain=lwn.net dmarc=pass fromdomain=lwn.net); spf=pass (google.com: domain of linux-kernel+bounces-215993-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-215993-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lwn.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 14AED1F223D1 for ; Sat, 15 Jun 2024 19:42:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3315131A8F; Sat, 15 Jun 2024 19:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b="GcrpN0N0" Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6C6279F0 for ; Sat, 15 Jun 2024 19:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.79.88.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718480558; cv=none; b=QMg+HYDsJjJBYJJAH6Ned4p6SxytimHPcLoVZF/UM5ZyU7qEhZzEPfUNzXRVNacx4bxxj5KHHm5ucyio/Pj1v6KrRGc/4tpt9jylSXJDOfsoJkRUBXdV/4mUtxgBd/wn7pdIgRNE28+h88rtT4ccika9CAiR9a/JA9osunt9iuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718480558; c=relaxed/simple; bh=+UdLH0WPQNR18Vi3J43f0+mQIQUVOhhjt7EdWXjh7RM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=oCCGhp4UviYJrVC2Oz5hMcVnqe4jFfvaapTAZ1ol2wO9S7KqIFp3xMrhl1ShjdEcsSeGXUbEWYtppw4E0/2K8tWw0RpKKlwYp7KlNKG+OW64yUf0kNscbWUgYZI4WrWtbIXi9T1t4ZEEYX0yc2iVqimNJuPAAIYbc1WzhEcGsLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net; spf=pass smtp.mailfrom=lwn.net; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b=GcrpN0N0; arc=none smtp.client-ip=45.79.88.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lwn.net DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net C807445E1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1718480548; bh=qu/dBFFpqkkgxB6kh0uYEAdu/GrOhLxnW6Dyqt7w/7Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GcrpN0N0tznfmqFxn2CHm34o4mNcps2f+0Hvh5w+U/SJgrifUDN/po1A8zypL7JW9 r08mwl13v8jS/zjQ7CP8S18bparEPlZqkvjrdqyLbUBIscjrJiebN/bd3BbPGpmHPN QkgwpPlU2lpRKF1eoFBBx384KBO+6CfVnaF95I+BY1kbicNvvdQTOsvfelo6JPOvZv WU/53Dw1DpfaotF3jGWBPW4IFpXsGIxr4T7skI7EzZCtjXoeuUAoMCNq38+vT+GTd0 aUQUVxpXtWs0l4Lp68PkjpYcpO4vhK+maa2CqmuwAsdGpZ+KVzbr6v79DYc8Y4z/8C HGAgujrSU3y/g== Received: from localhost (unknown [IPv6:2601:280:5e00:625::1fe]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id C807445E1A; Sat, 15 Jun 2024 19:42:27 +0000 (UTC) From: Jonathan Corbet To: Dongliang Mu , Dongliang Mu , Cheng Ziqiu , Yanteng Si , Alex Shi Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] scripts: fix most issues reported by pylint In-Reply-To: <20240615035323.909650-1-dzm91@hust.edu.cn> References: <20240615035323.909650-1-dzm91@hust.edu.cn> Date: Sat, 15 Jun 2024 13:42:26 -0600 Message-ID: <87ikyakn6l.fsf@trenco.lwn.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dongliang Mu writes: > Pylint reports many coding style issues of scripts/checktransupdate.py > > This patch fixes most issues with the following contents: > - add or revise comments for all functions > - use format string suggested by python > > Signed-off-by: Dongliang Mu > --- > scripts/checktransupdate.py | 55 ++++++++++++++++--------------------- > 1 file changed, 24 insertions(+), 31 deletions(-) How does this differ from v1? Please always give that information so reviewers know what's going on. Thanks, jon