Received-SPF: pass (google.com: domain of linux-kernel+bounces-216103-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 15 Jun 2024 20:32:25 -0700
From: Namhyung Kim <namhyung@kernel.org>
To: weilin.wang@intel.com
Cc: Ian Rogers <irogers@google.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Perry Taylor <perry.taylor@intel.com>,
	Samantha Alt <samantha.alt@intel.com>,
	Caleb Biggers <caleb.biggers@intel.com>
Subject: Re: [RFC PATCH v13 9/9] perf test: Add test for Intel TPEBS counting
 mode
Message-ID: <Zm5cydyXAuf71s71@google.com>
References: <20240613033631.199800-1-weilin.wang@intel.com>
 <20240613033631.199800-10-weilin.wang@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240613033631.199800-10-weilin.wang@intel.com>

Hello Weilin,

On Wed, Jun 12, 2024 at 11:36:29PM -0400, weilin.wang@intel.com wrote:
> From: Weilin Wang <weilin.wang@intel.com>
> 
> Intel TPEBS sampling mode is supported through perf record. The counting mode
> code uses perf record to capture retire_latency value and use it in metric
> calculation. This test checks the counting mode code.
> 
> Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> ---
>  .../perf/tests/shell/test_stat_intel_tpebs.sh  | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100755 tools/perf/tests/shell/test_stat_intel_tpebs.sh
> 
> diff --git a/tools/perf/tests/shell/test_stat_intel_tpebs.sh b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> new file mode 100755
> index 000000000000..3c8763b39bd4
> --- /dev/null
> +++ b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> @@ -0,0 +1,18 @@
> +#!/bin/bash
> +# test Intel TPEBS counting mode
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set e
> +
> +# Use this event for testing because it should exist in all platforms
> +e=cache-misses:R
> +
> +# Without this cmd option, default value or zero is returned
> +echo "Testing without --enable-tpebs-recording"
> +result=$(perf stat -e "$e" true 2>&1)
> +[[ "$result" =~ "$e" ]] || exit 1
> +
> +# In platforms that do not support TPEBS, it should execute without error.
> +echo "Testing with --enable-tpebs-recording"
> +result=$(perf stat -e "$e" --enable-tpebs-recording -a sleep 0.01 2>&1)
> +[[ "$result" =~ "perf record" && "$result" =~ "$e" ]] || exit 1

This still gives me errors like:

  In tests/shell/test_stat_intel_tpebs.sh line 13:                                
  [[ "$result" =~ "$e" ]] || exit 1                                               
                  ^--^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally.
                                                                                  
                                                                                  
  In tests/shell/test_stat_intel_tpebs.sh line 18:                                
  [[ "$result" =~ "perf record" && "$result" =~ "$e" ]] || exit 1                 
                                                ^--^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally.
                                                                                  
  For more information:                                                           
    https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid...
  make[4]: *** [tests/Build:90: tests/shell/test_stat_intel_tpebs.sh.shellcheck_log] Error 1
  make[4]: *** Waiting for unfinished jobs....

Please install shellcheck and check the build.

I'm not sure what's the correct fix but it seems the shellcheck
suggested to match '$' as a regex special character.  You may
disable the shellcheck if it's a false alarm.

Thanks,
Namhyung