Received-SPF: pass (google.com: domain of linux-kernel+bounces-216111-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 16 Jun 2024 12:16:21 +0800
From: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: 8250: Fixes: Fix port count mismatch with
 the device
Message-ID: <Zm5nFVCNfLZbW5tK@localhost.localdomain>
References: <20240614090322.2303-1-crescentcy.hsieh@moxa.com>
 <2024061406-simmering-sanded-17ef@gregkh>
 <Zm0odLN7ZJ/qI1nX@localhost.localdomain>
 <2024061500-jeep-upchuck-6b3a@gregkh>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024061500-jeep-upchuck-6b3a@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?07TLAUCBAB+TxQZTVbIoB3IwOFLoqYkuvqL16o+9UAoSk1PKrElZADntBght?=
 =?us-ascii?Q?YhF713aLOQqf0URwBQBvSw7eKvNgy0jbuHwoLFY0ze9GOWk+GIwzUo90k5KW?=
 =?us-ascii?Q?mzLo5V+CQM/GEOmdOUguw8gTY9HfkXkWP7/He7I69tGdwHpcatm6d75jG+q7?=
 =?us-ascii?Q?eeijQjtM/DhSzkgT04QU2NHxgQRJ1sOTo7wmqdZ1p5GgbrVROsTW1+Is/Xe7?=
 =?us-ascii?Q?JdqEp7R3vo528Bzu7yGD3BHMpm6OUpdWaPTKwtC43n0wtRG7OHvX0kdpxqsi?=
 =?us-ascii?Q?43B359SWRJFu0GsOeVuKFXAwfniOkylihT6iWShuKZmKaM4yHivpFqtPZ00Y?=
 =?us-ascii?Q?CrPWtlLpKsiQLgM5wMwBeRUf3xCGfMUOOVoGtOun8YTbj4pVf+0SZt2/HqDl?=
 =?us-ascii?Q?m9gR5Ih7ZNP8MXxd71xPw5+z3+GWdCym3FphQZo9rBgOOjqHp2+vzyHr12aR?=
 =?us-ascii?Q?hnn01dR35j25paLoxZqIetVNpu9jbxW639nivqpUjTQNknc97UJiEBitMCWT?=
 =?us-ascii?Q?Yf9PnVJZne4QYPlkaf+QL5RtsaU1k5aOg6w7/pbtCE/BYxLwaeVrR+Yxcht8?=
 =?us-ascii?Q?vxagjFMFZopEQRUx9RouLayfEqAl1SzidYSEqcnMtvZAsaFjAki9HIkUNR7Q?=
 =?us-ascii?Q?KTCnXkyStFu+Ih8x5V1aIdEJ9CW6HR/QzxE29+hMdfMddJcFfDcj0ORmj+nV?=
 =?us-ascii?Q?lW4hf6XD9THwuHrRMb7Vgw7V+iWtEtwL1uqNqwHLa+7AMU0zCyQesnmH3Dft?=
 =?us-ascii?Q?OLTAiz85cueHjRRVL1f6Y49t51rv/wIhHfFMKkP1PK1heR2Cv0ZrlmsdN+so?=
 =?us-ascii?Q?DHlDmTw+T95M/4qM/vpkNF2bGfGUG4s5cKJ4zzY2IIZF7JNkgFU4akRWSWuo?=
 =?us-ascii?Q?bsf6d05kxhDsVOxoSUDZ94ftTDRl3uTU88SNuJcfE0gnE9TQzeps/syRIDYC?=
 =?us-ascii?Q?Ru9AUcCY8yNwNSaLafpFH1ckDWT4OdkxkrbYVB+dsK3w7ABZ5ZpqUrXbEaJ7?=
 =?us-ascii?Q?WwauryG73hAzlnGIU9UOOSvAuirJa02BFRi4rTw7KAhuWZR9PGWUFuWleyEF?=
 =?us-ascii?Q?iwN4BvXv7UehWJF26ZegsIMoVXES1mkjdNZe4GTUEWQVizCFeZoS5gFYlmYj?=
 =?us-ascii?Q?6Je/girkVMHBsniiarR0q52tPhAHslqcQ4c4KcPQvFLewRTrbeAzjYWSUhW1?=
 =?us-ascii?Q?MdHz07d9WgsnAoDT6sf7j/UC67IXItpZ+Zmcg2T3FAVq7WhIYhugYELSSwNn?=
 =?us-ascii?Q?S+B1iKbWQDynXuITC8l1yfxeWkMZJNQYRW70Mp2PBbmqP4WbV8/W8P0IN4Ez?=
 =?us-ascii?Q?W3OJJi4YHpagacQqM3XlJfQNlaSCpT4z9JF+boZjMzvW5IjS28zNDkJZpvyg?=
 =?us-ascii?Q?8IIzR9SEQCQiEAbJzlAU1fPyJqH3LUkSWMFG96uN/k6+isW6nhL7pP93ZSe2?=
 =?us-ascii?Q?83/TGtSGXGxqLqo9Au3Fu1dtpCKmYLb0X689xLckmIXVhPOXBnxv00GffXWm?=
 =?us-ascii?Q?ln6Jt0IaTy4tsAy3mbl1DCRzXNLRNeGRMahFfNxjskxMRJn766IPlkdMMXAI?=
 =?us-ascii?Q?NKik0jck2EKl0Mfrtv8QEeaY0U9IJwUShPzVr9zZ2hAPq/IhxnmvhCIVHlbg?=
 =?us-ascii?Q?KA=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c911622c-12ce-4b50-e48e-08dc8dbb15c9
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2024 04:16:24.5665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oOqVwZkhhurK5T/LEdwRnm3LLnjBrRlea0kuJAAt+1tHmabNNgPez0bE8sgM9Drsr04iDsxE2r0yXU/uuMm/qr31QzrHXBdesvwBkWKqwvk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR01MB5875

On Sat, Jun 15, 2024 at 08:18:41AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jun 15, 2024 at 01:36:52PM +0800, Crescent CY Hsieh wrote:
> > On Fri, Jun 14, 2024 at 11:07:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Jun 14, 2024 at 05:03:22PM +0800, Crescent Hsieh wrote:
> > > > Normally, the number of ports is indicated by the third digit of the
> > > > device ID on Moxa PCI serial boards. For example, `0x1121` indicates a
> > > > device with 2 ports.
> > > > 
> > > > However, `CP116E_A_A` and `CP116E_A_B` are exceptions; they have 8
> > > > ports, but the third digit of the device ID is `6`.
> > > > 
> > > > This patch introduces a function to retrieve the number of ports on Moxa
> > > > PCI serial boards, addressing the issue described above.
> > > > 
> > > > Signed-off-by: Crescent Hsieh <crescentcy.hsieh@moxa.com>
> > > > ---
> > > >  drivers/tty/serial/8250/8250_pci.c | 13 ++++++++++++-
> > > >  1 file changed, 12 insertions(+), 1 deletion(-)
> > > 
> > > What commit id does this fix?
> > 
> > None, it's just a normal patch, I might have mistakenly added the "fix"
> > tag.
> 
> You say "fix" twice in the subject line, and it looks like it actually
> does resolve a problem in the current code.
> 
> Or is this all just a "cleanup" change?
> 
> confused,

After reviewing what this patch has done, I found that it does fix the
problem of retrieving the wrong number of ports on some Moxa PCI serial
devices. However, this issue is not severe enough to cause any system
problems.

Sorry for the confusion.

---
Sincerely,
Crescent Hsieh