Received-SPF: pass (google.com: domain of linux-kernel+bounces-216121-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9811ea10d647ff687e140976ec50c5ebbe5ecbe5.camel@mastodonlabs.com>
Subject: [PATCH 1/1] kbuild: Fix build target deb-pkg: ln: failed to create
 hard link
From: Thayne Harbaugh <thayne@mastodonlabs.com>
Reply-To: thayne@mastodonlabs.com
To: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>
Date: Sat, 15 Jun 2024 23:34:54 -0600
Organization: Mastodon Labs
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2-2 
Precedence: bulk
MIME-Version: 1.0

From: Thayne Harbaugh <thayne@mastodonlabs.com>

The make deb-pkg target calls debian-orig which attempts to either
hard link the source .tar to the build-output location or copy the
source .tar to the build-output location.  The test to determine
whether to ln or cp is incorrectly expanded by Make and consequently
always attempts to ln the source .tar.  This fix corrects the escaping
of '$' so that the test is expanded by the shell rather than by Make
and appropriately selects between ln and cp.

Signed-off-by: Thayne Harbaugh <thayne@mastodonlabs.com>
---
 scripts/Makefile.package | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.package b/scripts/Makefile.package
index 38653f3e8108..bf016af8bf8a 100644
--- a/scripts/Makefile.package
+++ b/scripts/Makefile.package
@@ -103,7 +103,7 @@ debian-orig: private version =3D $(shell dpkg-parsechan=
gelog -S Version | sed 's/-
 debian-orig: private orig-name =3D $(source)_$(version).orig.tar$(debian-o=
rig-suffix)
 debian-orig: mkdebian-opts =3D --need-source
 debian-orig: linux.tar$(debian-orig-suffix) debian
-	$(Q)if [ "$(df  --output=3Dtarget .. 2>/dev/null)" =3D "$(df --output=3Dt=
arget $< 2>/dev/null)" ]; then \
+	$(Q)if [ "$$(df  --output=3Dtarget .. 2>/dev/null)" =3D "$$(df --output=
=3Dtarget $< 2>/dev/null)" ]; then \
 		ln -f $< ../$(orig-name); \
 	else \
 		cp $< ../$(orig-name); \
--=20
2.43.0