Received-SPF: pass (google.com: domain of linux-kernel+bounces-216162-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 16 Jun 2024 09:32:24 +0200
Message-ID: <87bk415omv.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-sound@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Fix validation of writes to volatile controls
In-Reply-To: <20240614-alsa-selftest-volatile-v1-1-3874f02964b1@kernel.org>
References: <20240614-alsa-selftest-volatile-v1-1-3874f02964b1@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Fri, 14 Jun 2024 18:40:37 +0200,
Mark Brown wrote:
> 
> When validating writes to controls we check that whatever value we wrote
> actually appears in the control.  For volatile controls we cannot assume
> that this will be the case, the value may be changed at any time
> including between our write and read.  Handle this by moving the check
> for volatile controls that we currently do for events to a separate
> block and just verifying that whatever value we read is valid for the
> control.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

I'll pick this in v3 patch set.


thanks,

Takashi