Received-SPF: pass (google.com: domain of linux-kernel+bounces-216206-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 16 Jun 2024 17:46:45 +0900
From: William Breathitt Gray <wbg@kernel.org>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@baylibre.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Lee Jones <lee@kernel.org>, linux-iio@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mfd: stm32-timers: Drop TIM_DIER_CC_IE(x) in favour
 of TIM_DIER_CCxIE(x)
Message-ID: <Zm6mdYBhP1dAMthI@ishi>
References: <cover.1718352022.git.u.kleine-koenig@baylibre.com>
 <0735860960b1b38570bffa5b0de81a97f6e3230e.1718352022.git.u.kleine-koenig@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dCl7/OXUWXzDpqmf"
Content-Disposition: inline
In-Reply-To: <0735860960b1b38570bffa5b0de81a97f6e3230e.1718352022.git.u.kleine-koenig@baylibre.com>


--dCl7/OXUWXzDpqmf
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 14, 2024 at 10:10:13AM +0200, Uwe Kleine-K=F6nig wrote:
> These two defines have the same purpose and this change doesn't
> introduce any differences in drivers/counter/stm32-timer-cnt.o.
>=20
> The only difference between the two is that
>=20
> 	TIM_DIER_CC_IE(1) =3D=3D TIM_DIER_CC2IE
>=20
> while
>=20
> 	TIM_DIER_CCxIE(1) =3D=3D TIM_DIER_CC1IE
>=20
> . That makes it necessary to have an explicit "+ 1" in the user code,
> but IMHO this is a good thing as this is the code locatation that
> "knows" that for software channel 1 you have to use TIM_DIER_CC2IE
> (because software guys start counting at 0, while the relevant hardware
> designer started at 1).
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@baylibre.com>

I concur with Lee Jones that the subject should be renamed. Regardless,
here's my ack for the code changes.

Acked-by: William Breathitt Gray <wbg@kernel.org>

--dCl7/OXUWXzDpqmf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZm6mdQAKCRC1SFbKvhIj
K30lAQDsaSV5Lc4QTe+SNucCUL6Fa1IDxYIgK4zoGmqxb9xPwwD9F2jDmowZBtn1
G4nggdLs3gGlZTYbXuMu9YnjuVjaTgk=
=v9Mi
-----END PGP SIGNATURE-----

--dCl7/OXUWXzDpqmf--